starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ENHANCED_KEY flag missing when releasing RightAlt #22464

New Issue
Open
opened 2026-01-31 08:14:08 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 08:14:08 +00:00
Owner
Copy Link

Originally created by @o-sdn-o on GitHub (Oct 28, 2024).

Windows Terminal version

current main

Windows build number

10.0.19045.4894

Other Software

No response

Steps to reproduce

  1. Run the following c++ code:
#include <iostream>
#include <windows.h>
int main()
{
    INPUT_RECORD rec;
    DWORD count;
    while (true)
    {
        ::ReadConsoleInputW(::GetStdHandle(STD_INPUT_HANDLE), &rec, 1, &count);
        if (rec.EventType == KEY_EVENT)
        {
            std::cout << "type: KEY_EVENT" << std::hex
                      << ", down: " << rec.Event.KeyEvent.bKeyDown
                      << ", ENHANCED_KEY: " << !!(rec.Event.KeyEvent.dwControlKeyState & ENHANCED_KEY)
                      << ", ctrl: 0x" << rec.Event.KeyEvent.dwControlKeyState
                      << ", vcod: 0x" << rec.Event.KeyEvent.wVirtualKeyCode
                      << ", scod: 0x" << rec.Event.KeyEvent.wVirtualScanCode
                      << ", wchr: 0x" << rec.Event.KeyEvent.uChar.UnicodeChar << '\n';
        }
    }
}
  1. Press LeftCtrl key, press RightCtrl key, check ENHANCED_KEY flag.
  2. Press LeftAlt key, press RightAlt key, check ENHANCED_KEY flag.

Expected Behavior

The ENHANCED_KEY flag is present when RightAlt is pressed and released.

The current conhost.exe is not affected by this issue.

Actual Behavior

The ENHANCED_KEY flag is absent when RightAlt is released, but is present when RightAlt is pressed.

Originally created by @o-sdn-o on GitHub (Oct 28, 2024). ### Windows Terminal version current main ### Windows build number 10.0.19045.4894 ### Other Software _No response_ ### Steps to reproduce 1. Run the following c++ code: ```c++ #include <iostream> #include <windows.h> int main() { INPUT_RECORD rec; DWORD count; while (true) { ::ReadConsoleInputW(::GetStdHandle(STD_INPUT_HANDLE), &rec, 1, &count); if (rec.EventType == KEY_EVENT) { std::cout << "type: KEY_EVENT" << std::hex << ", down: " << rec.Event.KeyEvent.bKeyDown << ", ENHANCED_KEY: " << !!(rec.Event.KeyEvent.dwControlKeyState & ENHANCED_KEY) << ", ctrl: 0x" << rec.Event.KeyEvent.dwControlKeyState << ", vcod: 0x" << rec.Event.KeyEvent.wVirtualKeyCode << ", scod: 0x" << rec.Event.KeyEvent.wVirtualScanCode << ", wchr: 0x" << rec.Event.KeyEvent.uChar.UnicodeChar << '\n'; } } } ``` 2. Press LeftCtrl key, press RightCtrl key, check ENHANCED_KEY flag. 3. Press LeftAlt key, press RightAlt key, check ENHANCED_KEY flag. ### Expected Behavior The ENHANCED_KEY flag is present when RightAlt is pressed and released. The current conhost.exe is not affected by this issue. ### Actual Behavior The ENHANCED_KEY flag is absent when RightAlt is released, but is present when RightAlt is pressed.
claunia added the Help WantedIssue-BugArea-InputProduct-Terminal labels 2026-01-31 08:14:08 +00:00
claunia commented 2026-01-31 08:14:09 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Oct 29, 2024):

It might be located here, when manually sending an Alt key release:

8d3f12b1c0/src/cascadia/WindowsTerminal/WindowThread.cpp (L223-L234)

The subsequent call to _GetPressedModifierKeys() does not return any pressed Alt keys, so the extended key flag is lost:

8d3f12b1c0/src/cascadia/TerminalControl/TermControl.cpp (L1466-L1475)

The solution is to take the ENHANCED_KEY flag from lParam (24th bit) of the WM_KEYUP message.

@o-sdn-o commented on GitHub (Oct 29, 2024): It might be located here, when manually sending an Alt key release: https://github.com/microsoft/terminal/blob/8d3f12b1c065a965974cd6b5bc7a81176ffb0f1b/src/cascadia/WindowsTerminal/WindowThread.cpp#L223-L234 The subsequent call to _GetPressedModifierKeys() does not return any pressed Alt keys, so the extended key flag is lost: https://github.com/microsoft/terminal/blob/8d3f12b1c065a965974cd6b5bc7a81176ffb0f1b/src/cascadia/TerminalControl/TermControl.cpp#L1466-L1475 The solution is to take the ENHANCED_KEY flag from lParam (24th bit) of the [WM_KEYUP message](https://learn.microsoft.com/en-us/windows/win32/inputdev/wm-keyup).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Help Wanted Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22464
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?