starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Epic: Fix remaining issues with non-client drawing #2248

New Issue
Closed
opened 2026-01-30 22:50:34 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:50:34 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Jun 26, 2019).

Misc. Window Management bucket

  • Make sure caption controls "dim out" when window loses NC focus (WM_NCACTIVATE?)
  • #1840 When we're maximized, the system thinks we're a full-screen app. We need to jiggle the window by 1px or something.

Others:

  • #2001 Make sure MinMaxCloseControl supports FullScreen & Tablet Mode
  • #2100 When a dialog is open, the titlebar is the wrong color
    • Also: #4744 Investigate Acrylic in titlebar / not using a HRGN for the titlebar
  • #1230 I have to restart the new terminal to see the effects of changing between light and dark windows theme.
  • #2541 When the window is maximized, there should be no padding above the tabs
  • #3440 Windows Terminal does not open with button displaying "maximized" state
  • #4288 Maximize and minimize window buttons incorrect rendering
  • strange bar appear while maximized #8384
Fixed in `master`
  • Suspicious remains of previous window borders flash up when closing the window (#3222) (PR#3394)
  • White border at the bottom of the window. (#3064) (PR #3394)
  • Stop creating and throwing away so many HRGNs during move-size. (PR #3394)
  • #3136 we learned that CXDRAG and CYDRAG are not the right things to use; use the right things. (PR #3394)
  • #1307 Thick border around window, and drag handles should not be only over that border. (PR #3394)
  • #1897 There's a bunch of duplicated work, well, everywhere. (PR #3394)
  • make the window border have distinct edges (right now it blends in with white/black things); consider the user's accent color somehow?
    • Could this be solved just by not NCPAINTing, and letting DWM draw our window shadow again?

Possibly related:

  • #1859 The border width should match the value from the system theme
Fixed in <0.6
  • Switch from _ - X to real or real-looking caption controls

Definitely related, because we're handling WM_NCPAINT:

  • [huge bucket] look at getting the window shadow back (PR #1898)
  • make the window border less round on top (PR #1898)

Maybe related:

  • make the window border less painfully black/white

Misc. Window Management bucket

  • consider giving NonClientIslandWindow knowledge about its caption button box for a more direct connection (PR #1948)
  • #1780 Double clicking on the drag bar to maximize does not update the maximize button icon
  • Make sure maximize button maintains correct state when window is maximized in any manner
  • #1055 Window edges are cut off when the window is maximized on a secondary display (PR #1921)
  • #2028 Clicking on the TitleBar does not close the dropdown menu
  • #2268 Maximizing terminal when window is across two monitors causes bars to bleed across monitor.

Others:

  • #1913 Dark Theme requires settings reload (PR #2107)
Originally created by @DHowett-MSFT on GitHub (Jun 26, 2019). Misc. Window Management bucket * [ ] Make sure caption controls "dim out" when window loses NC focus (`WM_NCACTIVATE`?) * [x] #1840 When we're maximized, the system thinks we're a full-screen app. We need to jiggle the window by 1px or something. Others: * [ ] #2001 Make sure MinMaxCloseControl supports FullScreen & Tablet Mode * [x] #2100 When a dialog is open, the titlebar is the wrong color - [x] Also: #4744 Investigate Acrylic in titlebar / not using a `HRGN` for the titlebar * [x] #1230 I have to restart the new terminal to see the effects of changing between light and dark windows theme. * [x] #2541 When the window is maximized, there should be no padding above the tabs * [x] #3440 Windows Terminal does not open with button displaying "maximized" state * [x] #4288 Maximize and minimize window buttons incorrect rendering * [x] strange bar appear while maximized #8384 <details> <summary>Fixed in `master`</summary> * [x] Suspicious remains of previous window borders flash up when closing the window (#3222) (PR#3394) * [x] White border at the bottom of the window. (#3064) (PR #3394) * [x] Stop creating and throwing away so many `HRGN`s during move-size. (PR #3394) * [x] #3136 we learned that `CXDRAG` and `CYDRAG` are not the right things to use; use the right things. (PR #3394) * [x] #1307 Thick border around window, and drag handles should _not_ be only over that border. (PR #3394) * [x] #1897 There's a bunch of duplicated work, well, everywhere. (PR #3394) * [x] make the window border have distinct edges (right now it blends in with white/black things); consider the user's accent color somehow? - Could this be solved just by not `NCPAINT`ing, and letting DWM draw our window shadow again? Possibly related: * [x] #1859 The border width should match the value from the system theme </details> <details> <summary>Fixed in &lt;0.6</summary> * [x] Switch from `_` `-` `X` to real or real-looking caption controls Definitely related, because we're handling `WM_NCPAINT`: * [x] [huge bucket] look at getting the window shadow back (PR #1898) * [x] make the window border less round on top (PR #1898) Maybe related: * [x] make the window border less painfully black/white Misc. Window Management bucket * [x] _consider_ giving NonClientIslandWindow knowledge about its caption button box for a more direct connection (PR #1948) * [x] #1780 Double clicking on the drag bar to maximize does not update the maximize button icon * [x] Make sure maximize button maintains correct state when window is maximized in any manner * [x] #1055 Window edges are cut off when the window is maximized on a secondary display (PR #1921) * [x] #2028 Clicking on the TitleBar does not close the dropdown menu * [x] #2268 Maximizing terminal when window is across two monitors causes bars to bleed across monitor. Others: * [x] #1913 Dark Theme requires settings reload (PR #2107) </details>
claunia added the Needs-Tag-FixProduct-TerminalArea-UserInterfaceIssue-Scenario labels 2026-01-30 22:50:34 +00:00
claunia commented 2026-01-30 22:50:36 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 5, 2019):

We need to handle the window message for theme change probably.

@DHowett-MSFT commented on GitHub (Aug 5, 2019): We need to handle the window message for theme change probably.
claunia commented 2026-01-30 22:50:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 4, 2022):

Closing this one out since #2001 is really the only thing left in it.

@zadjii-msft commented on GitHub (Jan 4, 2022): Closing this one out since #2001 is really the only thing left in it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Scenario Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2248
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?