starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[High Contrast] "Failed to reload settings" warning isn't legible #22492

New Issue
Open
opened 2026-01-31 08:15:03 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 08:15:03 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Nov 4, 2024).

Originally assigned to: @carlos-zamora on GitHub.

Image

Originally created by @carlos-zamora on GitHub (Nov 4, 2024). Originally assigned to: @carlos-zamora on GitHub. ![Image](https://github.com/user-attachments/assets/93024e28-1b51-4837-b1d2-aff44a212536)
claunia commented 2026-01-31 08:15:04 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Nov 7, 2024):

Did some research:

  • The color used is ErrorTextBrush (Color=ThemeResource SystemErrorTextColor)here: 52262b05fa/src/cascadia/TerminalApp/App.xaml (L44)
  • We build that message using _BuildErrorRun in TerminalWindow: 52262b05fa/src/cascadia/TerminalApp/TerminalWindow.cpp (L111)
  • For whatever reason, SystemErrorTextColor doesn't have a high contrast value, so we just end up using yellow instead.
  • I've tried messing with the XAML and I wasn't able to get it to use a theme resource instead. Since we're getting the color via code in TerminalWindow.cpp, we basically have to evaluate which theme dictionary to use at runtime, which makes this a bit more complex.

The good news is, we really only have this kind of illegible text when the Contrast Theme has a light background (i.e. Desert). I'm assigning priority 3 and adding the help-wanted label on it.

@carlos-zamora commented on GitHub (Nov 7, 2024): Did some research: - The color used is `ErrorTextBrush` (Color=ThemeResource `SystemErrorTextColor`)here: https://github.com/microsoft/terminal/blob/52262b05fa0a97d2d3a0fce0990840ffc0fa53f1/src/cascadia/TerminalApp/App.xaml#L44 - We build that message using `_BuildErrorRun` in `TerminalWindow`: https://github.com/microsoft/terminal/blob/52262b05fa0a97d2d3a0fce0990840ffc0fa53f1/src/cascadia/TerminalApp/TerminalWindow.cpp#L111 - For whatever reason, `SystemErrorTextColor` doesn't have a high contrast value, so we just end up using yellow instead. - I've tried messing with the XAML and I wasn't able to get it to use a theme resource instead. Since we're getting the color via code in TerminalWindow.cpp, we basically have to evaluate which theme dictionary to use at runtime, which makes this a bit more complex. The good news is, we really only have this kind of illegible text when the Contrast Theme has a light background (i.e. Desert). I'm assigning priority 3 and adding the help-wanted label on it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Help Wanted Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22492
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?