starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Releasing both pressed Shift keys (left+right) reports only one #22571

New Issue
Open
opened 2026-01-31 08:17:17 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 08:17:17 +00:00
Owner
Copy Link

Originally created by @o-sdn-o on GitHub (Nov 20, 2024).

Windows Terminal version

current main

Windows build number

10.0.19045.5011

Other Software

No response

Steps to reproduce

  1. Activate "debug tap" pane.
    • Add the global setting (near the top of your JSON file): 
      "debugFeatures": true
    • Open a new tab while holding down both left and right Alt .
  2. Press and release both Shift keys simultaneously.

Expected Behavior

There are four reports in the "debug tap" pane:

  • The first Shift key was pressed.
  • The second Shift key was pressed.
  • Some Shift key was released.
  • The remaining Shift key was released.

Actual Behavior

Image

There are only three reports in the "debug tap" pane:

  • The first Shift key was pressed.
  • The second Shift key was pressed.
  • Some Shift key was released.
Originally created by @o-sdn-o on GitHub (Nov 20, 2024). ### Windows Terminal version current main ### Windows build number 10.0.19045.5011 ### Other Software _No response_ ### Steps to reproduce 1. Activate "debug tap" pane. - Add the global setting (near the top of your JSON file): ``` "debugFeatures": true ``` - Open a new tab while holding down both left and right Alt . 2. Press and release both Shift keys simultaneously. ### Expected Behavior There are four reports in the "debug tap" pane: - The first Shift key was pressed. - The second Shift key was pressed. - Some Shift key was released. - The remaining Shift key was released. ### Actual Behavior ![Image](https://github.com/user-attachments/assets/e4e03c3d-6d12-4b8e-aa9c-625ffda013c2) There are only three reports in the "debug tap" pane: - The first Shift key was pressed. - The second Shift key was pressed. - Some Shift key was released.
claunia added the Help WantedIssue-BugPriority-3Area-InputProduct-Terminal labels 2026-01-31 08:17:18 +00:00
claunia commented 2026-01-31 08:17:18 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Nov 20, 2024):

Since the operating system (at least 10.0.19045.5011) does not generate a right Shift key release WM_KEYUP event after detecting a second Shift key pressed, the possible solution is to use a timer to track the right Shift key down state in the thread's keyboard buffer. This works reliably with a 33ms tick timer.

@o-sdn-o commented on GitHub (Nov 20, 2024): Since the operating system (at least 10.0.19045.5011) does not generate a right Shift key release `WM_KEYUP` event after detecting a second Shift key pressed, the possible solution is to use a timer to track the right Shift key down state in the thread's keyboard buffer. This works reliably with a 33ms tick timer.
claunia commented 2026-01-31 08:17:19 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Nov 20, 2024):

Thanks for filing! Does this repro in conhost /?

@carlos-zamora commented on GitHub (Nov 20, 2024): Thanks for filing! Does this repro in conhost /?
claunia commented 2026-01-31 08:17:19 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Nov 21, 2024):

Does this repro in conhost /?

Yes, this issue is also reproduced in conhost.

#include <iostream>
#include <windows.h>

int main()
{
    DWORD count;
    INPUT_RECORD r;
    HANDLE input = ::GetStdHandle(STD_INPUT_HANDLE);
    while (true)
    {
        ::ReadConsoleInputW(input, &r, 1, &count);
        if (r.EventType == KEY_EVENT)
        {
            std::cout << "type: KEY_EVENT" << std::hex
                << ", down: " << r.Event.KeyEvent.bKeyDown
                << ", ctrl: " << r.Event.KeyEvent.dwControlKeyState
                << ", count: " << r.Event.KeyEvent.wRepeatCount
                << ", vcod: " << r.Event.KeyEvent.wVirtualKeyCode
                << ", scod: " << r.Event.KeyEvent.wVirtualScanCode
                << ", wchr: " << (int)r.Event.KeyEvent.uChar.UnicodeChar << '\n';
        }
    }
}

Image

@o-sdn-o commented on GitHub (Nov 21, 2024): >Does this repro in conhost /? Yes, this issue is also reproduced in conhost. ```c++ #include <iostream> #include <windows.h> int main() { DWORD count; INPUT_RECORD r; HANDLE input = ::GetStdHandle(STD_INPUT_HANDLE); while (true) { ::ReadConsoleInputW(input, &r, 1, &count); if (r.EventType == KEY_EVENT) { std::cout << "type: KEY_EVENT" << std::hex << ", down: " << r.Event.KeyEvent.bKeyDown << ", ctrl: " << r.Event.KeyEvent.dwControlKeyState << ", count: " << r.Event.KeyEvent.wRepeatCount << ", vcod: " << r.Event.KeyEvent.wVirtualKeyCode << ", scod: " << r.Event.KeyEvent.wVirtualScanCode << ", wchr: " << (int)r.Event.KeyEvent.uChar.UnicodeChar << '\n'; } } } ``` ![Image](https://github.com/user-attachments/assets/218e2d31-73d4-447e-b271-23ea02594459)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Help Wanted Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22571
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?