starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

x-markdown - right click Select All crashes #22588

New Issue
Open
opened 2026-01-31 08:17:47 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 08:17:47 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Nov 25, 2024).

Originally assigned to: @lhecker on GitHub.

Steps to reproduce

Load up a markdown document in an x-markdown pane. Right click the body text and Select All.

Actual Behavior

It blow up

Originally created by @DHowett on GitHub (Nov 25, 2024). Originally assigned to: @lhecker on GitHub. ### Steps to reproduce Load up a markdown document in an `x-markdown` pane. Right click the body text and Select All. ### Actual Behavior It blow up
claunia added the Issue-BugProduct-TerminalArea-UserInterfaceSeverity-Crash labels 2026-01-31 08:17:48 +00:00
claunia commented 2026-01-31 08:17:48 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Aug 20, 2025):

Confirmed that #18854 did not fix this crash, unfortunately

Getting the markdown pane to work was a little finicky, so here's some easy repro steps:

  1. Add this action to your settings.json:
        {
            "command": 
            {
                "action": "splitPane",
                "type": "x-markdown"
            },
            "id": "User.splitPane.3C8060F8"
        }
  1. Have a markdown file handy (I included a simple one here)
    markdown.md
  2. open markdown pane: Command Palette > "x-markdown" > invoke action
  3. Paste path to markdown file in pane (no quotes!)
  4. Press "load" button (first one to right of text box)
  5. right click body text > "Select All"

Stack:

 	KernelBase.dll!00007ffd68ea879a()	Unknown
 	[External Code]	
>	Microsoft.Terminal.UI.dll!winrt::throw_hresult(const winrt::hresult result, const std::source_location & sourceInformation) Line 5070	C++
 	Microsoft.Terminal.UI.dll!winrt::impl::consume_Windows_UI_Xaml_Controls_IRichTextBlock<winrt::Windows::UI::Xaml::Controls::IRichTextBlock>::SelectAll() Line 15533	C++
 	Microsoft.Terminal.UI.dll!winrt::Microsoft::Terminal::UI::implementation::TextMenuFlyout::SelectAll_Click(const winrt::Windows::Foundation::IInspectable & __formal, const winrt::Windows::UI::Xaml::RoutedEventArgs & __formal) Line 184	C++
 	Microsoft.Terminal.UI.dll!winrt::impl::delegate<winrt::Windows::UI::Xaml::RoutedEventHandler,`winrt::Windows::UI::Xaml::RoutedEventHandler::implementation<winrt::Microsoft::Terminal::UI::implementation::TextMenuFlyout,void (__cdecl winrt::Microsoft::Terminal::UI::implementation::TextMenuFlyout::*)(winrt::Windows::Foundation::IInspectable const &,winrt::Windows::UI::Xaml::RoutedEventArgs const &)>'::`1'::<lambda_181_>>::Invoke(void * sender, void * e) Line 4671	C++
 	[External Code]	
 	WindowsTerminal.exe!WindowEmperor::HandleCommandlineArgs(int nCmdShow) Line 494	C++
 	WindowsTerminal.exe!wWinMain(HINSTANCE__ * __formal, HINSTANCE__ * __formal, wchar_t * __formal, int nCmdShow) Line 126	C++
 	[External Code]

Hoping this makes it easier to debug for whoever comes along next 😊

@carlos-zamora commented on GitHub (Aug 20, 2025): Confirmed that #18854 did not fix this crash, unfortunately Getting the markdown pane to work was a little finicky, so here's some easy repro steps: 1. Add this action to your settings.json: ```js { "command": { "action": "splitPane", "type": "x-markdown" }, "id": "User.splitPane.3C8060F8" } ``` 2. Have a markdown file handy (I included a simple one here) [markdown.md](https://github.com/user-attachments/files/21906906/markdown.md) 3. open markdown pane: Command Palette > "x-markdown" > invoke action 4. Paste path to markdown file in pane (**no quotes!**) 5. Press "load" button (first one to right of text box) 6. right click body text > "Select All" Stack: ``` KernelBase.dll!00007ffd68ea879a() Unknown [External Code] > Microsoft.Terminal.UI.dll!winrt::throw_hresult(const winrt::hresult result, const std::source_location & sourceInformation) Line 5070 C++ Microsoft.Terminal.UI.dll!winrt::impl::consume_Windows_UI_Xaml_Controls_IRichTextBlock<winrt::Windows::UI::Xaml::Controls::IRichTextBlock>::SelectAll() Line 15533 C++ Microsoft.Terminal.UI.dll!winrt::Microsoft::Terminal::UI::implementation::TextMenuFlyout::SelectAll_Click(const winrt::Windows::Foundation::IInspectable & __formal, const winrt::Windows::UI::Xaml::RoutedEventArgs & __formal) Line 184 C++ Microsoft.Terminal.UI.dll!winrt::impl::delegate<winrt::Windows::UI::Xaml::RoutedEventHandler,`winrt::Windows::UI::Xaml::RoutedEventHandler::implementation<winrt::Microsoft::Terminal::UI::implementation::TextMenuFlyout,void (__cdecl winrt::Microsoft::Terminal::UI::implementation::TextMenuFlyout::*)(winrt::Windows::Foundation::IInspectable const &,winrt::Windows::UI::Xaml::RoutedEventArgs const &)>'::`1'::<lambda_181_>>::Invoke(void * sender, void * e) Line 4671 C++ [External Code] WindowsTerminal.exe!WindowEmperor::HandleCommandlineArgs(int nCmdShow) Line 494 C++ WindowsTerminal.exe!wWinMain(HINSTANCE__ * __formal, HINSTANCE__ * __formal, wchar_t * __formal, int nCmdShow) Line 126 C++ [External Code] ``` Hoping this makes it easier to debug for whoever comes along next 😊
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22588
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?