starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Trigger Redraw Crash #22617

New Issue
Open
opened 2026-01-31 08:18:39 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 08:18:39 +00:00
Owner
Copy Link

Originally created by @shmuelie on GitHub (Dec 2, 2024).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.21.3231.0

Windows build number

10.0.26335.0

Other Software

No response

Steps to reproduce

Unsure 😅

Expected Behavior

To not crash

Actual Behavior

Access Violation exception, see Watson Bucket 20f45815-12a1-7b5a-eadf-5a6297346f30

Originally created by @shmuelie on GitHub (Dec 2, 2024). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.21.3231.0 ### Windows build number 10.0.26335.0 ### Other Software _No response_ ### Steps to reproduce Unsure 😅 ### Expected Behavior To not crash ### Actual Behavior `Access Violation` exception, see Watson Bucket 20f45815-12a1-7b5a-eadf-5a6297346f30
claunia added the Area-RenderingIssue-BugProduct-TerminalSeverity-Crash labels 2026-01-31 08:18:40 +00:00
claunia commented 2026-01-31 08:18:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 11, 2024):

internal dupe chain leads to MSFT:54447014,

`ACCESS_VIOLATION_c0000005_Microsoft.Terminal.Control.dll!
Microsoft::Console::VirtualTerminal::StateMachine::ProcessString

@zadjii-msft commented on GitHub (Dec 11, 2024): internal dupe chain leads to MSFT:54447014, `ACCESS_VIOLATION_c0000005_Microsoft.Terminal.Control.dll! Microsoft::Console::VirtualTerminal::StateMachine::ProcessString
claunia commented 2026-01-31 08:18:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 11, 2024):

and no hits for that on 1.22. @shmuelie if you use Terminal Preview, does this go away?

@zadjii-msft commented on GitHub (Dec 11, 2024): and no hits for that on 1.22. @shmuelie if you use Terminal Preview, does this go away?
claunia commented 2026-01-31 08:18:41 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Dec 12, 2024):

Ah fuck I figured it out. And I typed out such a long message before that...

Here's where we destroy the renderer:
bfab5fde4d/src/cascadia/TerminalControl/ControlCore.cpp (L227-L233)

But during the problematic call we only hold a strong reference to the Terminal, not the ControlCore:
bfab5fde4d/src/cascadia/TerminalControl/ControlCore.cpp (L197-L201)

In other words, the ControlCore gets destroyed while we're holding onto the dysfunctional corpse of a terminal.

@lhecker commented on GitHub (Dec 12, 2024): Ah fuck I figured it out. And I typed out such a long message before that... Here's where we destroy the renderer: https://github.com/microsoft/terminal/blob/bfab5fde4d09ae138b9a26c8fd8fb071d5f5f193/src/cascadia/TerminalControl/ControlCore.cpp#L227-L233 But during the problematic call we only hold a strong reference to the `Terminal`, not the `ControlCore`: https://github.com/microsoft/terminal/blob/bfab5fde4d09ae138b9a26c8fd8fb071d5f5f193/src/cascadia/TerminalControl/ControlCore.cpp#L197-L201 In other words, the `ControlCore` gets destroyed while we're holding onto the dysfunctional corpse of a terminal.
claunia commented 2026-01-31 08:18:41 +00:00
Author
Owner
Copy Link

@shmuelie commented on GitHub (Dec 13, 2024):

and no hits for that on 1.22. @shmuelie if you use Terminal Preview, does this go away?

I've not been able to reproduce it since the first crash so can't say

@shmuelie commented on GitHub (Dec 13, 2024): > and no hits for that on 1.22. [@shmuelie](https://github.com/shmuelie) if you use Terminal Preview, does this go away? I've not been able to reproduce it since the first crash so can't say
claunia commented 2026-01-31 08:18:42 +00:00
Author
Owner
Copy Link

@shmuelie commented on GitHub (Dec 26, 2024):

Just hit it again today on 1.23.3582.0

@shmuelie commented on GitHub (Dec 26, 2024): Just hit it again today on 1.23.3582.0
claunia commented 2026-01-31 08:18:42 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jul 2, 2025):

I think this may have been fixed by #18632.

@lhecker commented on GitHub (Jul 2, 2025): I think this may have been fixed by #18632.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22617
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?