starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Make sure foo.ico,0 works as an icon specifier #22658

New Issue
Open
opened 2026-01-31 08:19:44 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 08:19:44 +00:00
Owner
Copy Link

Originally created by @Slim08 on GitHub (Dec 12, 2024).

Windows Terminal version

1.21.3231.0

Windows build number

10.0.19045.5198

Other Software

No response

Steps to reproduce

Change default PNG resource with any std Windows ICO resource and you get one behavior. Add ",0" at the end for another behavior. Both together would be correct as a whole. Individually, both are wrong.

Screenshots

Expected Behavior

Correct usage of the icon resource for the given place it's supposed to be displayed.

Actual Behavior

Wrong or no icon displayed in taskbar jump list or in app.

Originally created by @Slim08 on GitHub (Dec 12, 2024). ### Windows Terminal version 1.21.3231.0 ### Windows build number 10.0.19045.5198 ### Other Software _No response_ ### Steps to reproduce Change default PNG resource with any std Windows ICO resource and you get one behavior. Add ",0" at the end for another behavior. Both together would be correct as a whole. Individually, both are wrong. [Screenshots](https://postimg.cc/gallery/pP9SHw6) ### Expected Behavior Correct usage of the icon resource for the given place it's supposed to be displayed. ### Actual Behavior Wrong or no icon displayed in taskbar jump list or in app.
claunia commented 2026-01-31 08:19:45 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 12, 2024):

Screenshots from the link

Image
Image

@zadjii-msft commented on GitHub (Dec 12, 2024): Screenshots from the link ![Image](https://github.com/user-attachments/assets/a5fe07a1-e804-4dc0-a974-e68dba091609) ![Image](https://github.com/user-attachments/assets/d8e76634-ced1-4a71-be61-e9a347ee58e5)
claunia commented 2026-01-31 08:19:45 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 8, 2025):

Thanks for the report!

Yes, it looks like we need to make sure foo.ico,0 works.

However: you appear to be using a custom shell.

Confirming that this works in the normal Windows 10 shell:

Image

If your custom shell does not support icon file references, file a bug on them. Thanks!

Also, why are you placing icon files in system32?

@DHowett commented on GitHub (Jan 8, 2025): Thanks for the report! Yes, it looks like we need to make sure `foo.ico,0` works. However: you appear to be using a custom shell. Confirming that this works in the normal Windows 10 shell: ![Image](https://github.com/user-attachments/assets/0b21f5be-7cf3-4e26-a7b6-54c2804a3bcf) If your custom shell does not support icon file references, file a bug on them. Thanks! _Also, why are you placing icon files in system32?_
claunia commented 2026-01-31 08:19:46 +00:00
Author
Owner
Copy Link

@Slim08 commented on GitHub (Jan 13, 2025):

Yes, it looks like we need to make sure foo.ico,0 works.

Thanks.

However: you appear to be using a custom shell.

I'm not 100% sure, but the taskbar context menu there could potentially be influenced by StartIsBack which I have installed and which I'm not going to uninstall over this. Other than that, I'm using the default Aero theme of Windows 10.

Also, why are you placing icon files in system32?

Since Terminal is a UWP app, I can't place the icon resource inside its installation directory. Any serious reason I couldn't / shouldn't put it in system32?

@Slim08 commented on GitHub (Jan 13, 2025): > Yes, it looks like we need to make sure foo.ico,0 works. Thanks. > However: you appear to be using a custom shell. I'm not 100% sure, but the taskbar context menu there could potentially be influenced by StartIsBack which I have installed and which I'm not going to uninstall over this. Other than that, I'm using the default Aero theme of Windows 10. > Also, why are you placing icon files in system32? Since Terminal is a UWP app, I can't place the icon resource inside its installation directory. Any serious reason I couldn't / shouldn't put it in system32?
claunia commented 2026-01-31 08:19:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 13, 2025):

Any serious reason I couldn't / shouldn't put it in system32?

It makes your settings less portable, and won't be backed up or (in the future) roamed elsewhere with the rest of your user data. You can put icons in the same folder as your settings and refer to them with ms-appdata:// URIs, or place them in your user Documents folder which will be synced or roamed.

You may want to report a bug to StartIsBack that they are handling jump list icon references incorrectly.

@DHowett commented on GitHub (Jan 13, 2025): > Any serious reason I couldn't / shouldn't put it in system32? It makes your settings less portable, and won't be backed up or (in the future) roamed elsewhere with the rest of your user data. You can put icons in the same folder as your settings and refer to them with `ms-appdata://` URIs, or place them in your user Documents folder which _will_ be synced or roamed. You may want to report a bug to StartIsBack that they are handling jump list icon references incorrectly.
claunia commented 2026-01-31 08:19:46 +00:00
Author
Owner
Copy Link

@Slim08 commented on GitHub (Jan 14, 2025):

Yeah, well, I don't do all that fancy roaming, syncing or whatever. If I need to, I reinstall my OS fresh with all my custom stuff already backed up on a USB manually. So I don't care about portability or whatever.

StartIsBack is a Windows 10 exclusive app and out of active development for years. There is nothing going to change that, with even Microsoft dropping support next year.
I'm still not 100% sure that the jump list even is StartIsBack's fault. Plus,

Yes, it looks like we need to make sure foo.ico,0 works.

Not only, StartIsBack is handling icon references incorrectly around here, right?

@Slim08 commented on GitHub (Jan 14, 2025): Yeah, well, I don't do all that fancy roaming, syncing or whatever. If I need to, I reinstall my OS fresh with all my custom stuff already backed up on a USB manually. So I don't care about portability or whatever. StartIsBack is a Windows 10 exclusive app and out of active development for years. There is nothing going to change that, with even Microsoft dropping support next year. I'm still not 100% sure that the jump list even is StartIsBack's fault. Plus, > Yes, it looks like we need to make sure foo.ico,0 works. Not only, StartIsBack is handling icon references incorrectly around here, right?
claunia commented 2026-01-31 08:19:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 14, 2025):

Not only, StartIsBack is handling icon references incorrectly around here, right?

Yes. That's why we've kept the bug open instead of closing it.

To be clear, there are two issues here:

  • One in Terminal, for not supporting foo.ico,0
  • One in StartIsBack or whatever is providing your custom jump list UI, for not supporting foo.ico without an index1 .

There is nothing going to change that, with even Microsoft dropping support next year.

Ok. Yes, I would not expect Microsoft dropping support for Windows 10 to suddenly return StartIsBack to active development. That seems like a concern for the original author of StartIsBack.

  1. Considering that it works in unmodified Windows 10 (see above) ↩︎

@DHowett commented on GitHub (Jan 14, 2025): > Not only, StartIsBack is handling icon references incorrectly around here, right? Yes. That's why we've kept the bug open instead of closing it. To be clear, there are two issues here: - One in Terminal, for not supporting `foo.ico,0` - One in StartIsBack _or whatever is providing your custom jump list UI_, for not supporting `foo.ico` without an index[^1]. > There is nothing going to change that, with even Microsoft dropping support next year. Ok. Yes, I would not expect Microsoft dropping support for Windows 10 to suddenly return StartIsBack to active development. That seems like a concern for the original author of StartIsBack. [^1]: Considering that it works in unmodified Windows 10 ([see above](https://github.com/microsoft/terminal/issues/18317#issuecomment-2578804527))
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22658
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?