starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

After changing the settings, settings.json will be quickly modified. #23085

New Issue
Closed
opened 2026-01-31 08:31:52 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 08:31:52 +00:00
Owner
Copy Link

Originally created by @LoneTyde on GitHub (Mar 28, 2025).

Originally assigned to: @PankajBhojwani on GitHub.

Windows Terminal version

1.22.10731.0

Windows build number

1000.26100.54.0

Other Software

No response

Steps to reproduce

  1. Open Windows Terminal.
  2. Open settings.
    1. Randomly change a configuration (a configuration that can cause changes to the settings.json file).
  4. After the settings.json file is modified, it will be rewritten frantically, and the terminal will flash rapidly until it becomes unresponsive and eventually crashes.

https://github.com/user-attachments/assets/e7a66435-df13-430b-88a8-3de8f3f4f048

Expected Behavior

No response

Actual Behavior

After the settings.json file is modified, it will be rewritten frantically, and the terminal will flash rapidly until it becomes unresponsive and eventually crashes.

Originally created by @LoneTyde on GitHub (Mar 28, 2025). Originally assigned to: @PankajBhojwani on GitHub. ### Windows Terminal version 1.22.10731.0 ### Windows build number 1000.26100.54.0 ### Other Software _No response_ ### Steps to reproduce 1. Open Windows Terminal. 2. Open settings. 3. 3. Randomly change a configuration (a configuration that can cause changes to the settings.json file). 4. After the settings.json file is modified, it will be rewritten frantically, and the terminal will flash rapidly until it becomes unresponsive and eventually crashes. https://github.com/user-attachments/assets/e7a66435-df13-430b-88a8-3de8f3f4f048 ### Expected Behavior _No response_ ### Actual Behavior After the settings.json file is modified, it will be rewritten frantically, and the terminal will flash rapidly until it becomes unresponsive and eventually crashes.
claunia added the Area-SettingsIssue-BugNeeds-Tag-FixProduct-Terminal labels 2026-01-31 08:31:52 +00:00
claunia commented 2026-01-31 08:31:53 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 2, 2025):

Well, that's not good.

@DHowett commented on GitHub (Apr 2, 2025): Well, that's not good.
claunia commented 2026-01-31 08:31:53 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 2, 2025):

Would you be able to share your settings file? If possible, would you also be able to grab the two different copies? I know that may be tough given the tight timing.

As you've intuited, settings should be stable once written 😆

@DHowett commented on GitHub (Apr 2, 2025): Would you be able to share your settings file? If possible, would you also be able to grab the two different copies? I know that may be tough given the tight timing. As you've intuited, settings should be stable once written 😆
claunia commented 2026-01-31 08:31:53 +00:00
Author
Owner
Copy Link

@LoneTyde commented on GitHub (Apr 3, 2025):

Would you be able to share your settings file? If possible, would you also be able to grab the two different copies? I know that may be tough given the tight timing.

As you've intuited, settings should be stable once written 😆

Thank you for your reply. The following is the configuration file where I encountered the problem. You can reproduce it using the relevant version of Windows Terminal.

settings.json

@LoneTyde commented on GitHub (Apr 3, 2025): > Would you be able to share your settings file? If possible, would you also be able to grab the two different copies? I know that may be tough given the tight timing. > > As you've intuited, settings should be stable once written 😆 --- Thank you for your reply. The following is the configuration file where I encountered the problem. You can reproduce it using the relevant version of Windows Terminal. [settings.json](https://github.com/user-attachments/files/19579648/settings.json)
claunia commented 2026-01-31 08:31:54 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Aug 27, 2025):

Thanks for sharing! Took a look under the debugger and found the issue:

        {
            "commands": 
            [
                {
                    "command": 
                    {
                        "action": "newTab",
                        "profile": "${profile.name}"
                    },
                    "icon": "${profile.icon}",
                    "iterateOn": "profiles",
                    "name": "${profile.name}"
                }
            ],
            "keys": "ctrl+shift+k",
            "name": "Anew"
        }

The "keys" property here is from a legacy syntax. Nowadays, users are expected to use the "keybindings" top-level property to bind "keys" to an action id "id". Finding the "keys" property causes the action map to set _fixupsAppliedDuringLoad to true, then trigger a write to settings.json. However, the new settings.json ends up having the same problem, which results in an endless loop of writing to the settings.json!

On your end, adding an action id to the "Anew" command and binding it in the "keybindings" array fixes the issue. Should look something like this:

"actions": 
    [
        // other actions...
        {
            "commands": 
            [
                {
                    "command": 
                    {
                        "action": "newTab",
                        "profile": "${profile.name}"
                    },
                    "icon": "${profile.icon}",
                    "iterateOn": "profiles",
                    "name": "${profile.name}"
                }
            ],
            "id": "anewID",
            "name": "Anew"
        }
    ],
"keybindings": 
    [
        {
            "id": "anewID",
            "keys": "ctrl+shift+k"
        }
        // other key bindings...
    ]

Assigning @PankajBhojwani since he's working on the action map.

@carlos-zamora commented on GitHub (Aug 27, 2025): Thanks for sharing! Took a look under the debugger and found the issue: ```js { "commands": [ { "command": { "action": "newTab", "profile": "${profile.name}" }, "icon": "${profile.icon}", "iterateOn": "profiles", "name": "${profile.name}" } ], "keys": "ctrl+shift+k", "name": "Anew" } ``` The `"keys"` property here is from a legacy syntax. Nowadays, users are expected to use the `"keybindings"` top-level property to bind `"keys"` to an action id `"id"`. Finding the `"keys"` property causes the action map to set `_fixupsAppliedDuringLoad` to true, then trigger a write to settings.json. However, the new settings.json ends up having the same problem, which results in an endless loop of writing to the settings.json! On your end, adding an action id to the `"Anew"` command and binding it in the `"keybindings"` array fixes the issue. Should look something like this: ```js "actions": [ // other actions... { "commands": [ { "command": { "action": "newTab", "profile": "${profile.name}" }, "icon": "${profile.icon}", "iterateOn": "profiles", "name": "${profile.name}" } ], "id": "anewID", "name": "Anew" } ], "keybindings": [ { "id": "anewID", "keys": "ctrl+shift+k" } // other key bindings... ] ``` Assigning @PankajBhojwani since he's working on the action map.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23085
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?