starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

"Color selection" off-by-one regression: it colors 1 cell past the end #23090

New Issue
Closed
opened 2026-01-31 08:32:01 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:32:01 +00:00
Owner
Copy Link

Originally created by @jazzdelightsme on GitHub (Mar 28, 2025).

Originally assigned to: @carlos-zamora on GitHub.

Windows Terminal version

1.23.10732.0

Windows build number

10.0.26388.1001

Other Software

No response

Steps to reproduce

I use the "Color Selection" feature a lot, and often the "all matches" variant, which lets you select some text, and then change the fg/bg color for all occurrences of the selected text.

Recently it started coloring one cell past the end of the selection. In the screenshot below, I selected "abcd", but the colorization applies to "abcde" (as well as "abcdeX", demonstrating that the search is not similarly afected):

Image

Expected Behavior

Just the "abcd" should have been colorized.

Actual Behavior

Colorization included one character past the end.

Originally created by @jazzdelightsme on GitHub (Mar 28, 2025). Originally assigned to: @carlos-zamora on GitHub. ### Windows Terminal version 1.23.10732.0 ### Windows build number 10.0.26388.1001 ### Other Software _No response_ ### Steps to reproduce I use the "Color Selection" feature a lot, and often the "all matches" variant, which lets you select some text, and then change the fg/bg color for all occurrences of the selected text. Recently it started coloring one cell past the end of the selection. In the screenshot below, I selected "abcd", but the colorization applies to "abcde" (as well as "abcdeX", demonstrating that the search is not similarly afected): ![Image](https://github.com/user-attachments/assets/6258a18f-d941-443d-9f3e-c7fd6750dbe3) ### Expected Behavior Just the "abcd" should have been colorized. ### Actual Behavior Colorization included one character past the end.
claunia commented 2026-01-31 08:32:04 +00:00
Author
Owner
Copy Link

@jazzdelightsme commented on GitHub (Mar 28, 2025):

As we all know, the two hardest things in computer science are naming things, cache invalidation, and off-by-one errors. :D

@jazzdelightsme commented on GitHub (Mar 28, 2025): As we all know, the two hardest things in computer science are naming things, cache invalidation, and off-by-one errors. :D
claunia commented 2026-01-31 08:32:04 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 28, 2025):

Alas, another victim of #18106

@DHowett commented on GitHub (Mar 28, 2025): Alas, another victim of #18106
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23090
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?