starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Triple-click to select logical line #23232

New Issue
Closed
opened 2026-01-31 08:36:07 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 08:36:07 +00:00
Owner
Copy Link

Originally created by @ebarzilay-godaddy on GitHub (May 5, 2025).

Description of the new feature

One very useful feature of xterm is that triple-clicking will (by default) select a whole logical line.

When is it useful?

Imagine sshing to some server and looking at a json-per-line log file with long lines. Looks like something is wrong in some area on the screen, so you want to look at that whole line -- how do you do that?

With xterm, I triple-click, and get the whole line. Winterm, OTOH, will select just the random physical line I clicked on.

I think that not only would it be good to have this functionality, it would also be better than the default in many cases.

Proposed technical implementation details

I don't know how it's implemented, but it looks like winterm does keep track of logical lines, so that information could be used instead of the physical line.

(I'm guessing the above because resizing the window shows that the logical lines are rewrapped; and also if I select a bunch of physical lines that come from a number of long lines, the resulting text has the proper logical newlines, rather than having them at the points where the text got wrapped.)

Originally created by @ebarzilay-godaddy on GitHub (May 5, 2025). ### Description of the new feature One very useful feature of xterm is that triple-clicking will (by default) select a whole ***logical*** line. ## When is it useful? Imagine sshing to some server and looking at a json-per-line log file with long lines. Looks like something is wrong in some area on the screen, so you want to look at that whole line -- how do you do that? With xterm, I triple-click, and get the whole line. Winterm, OTOH, will select just the random physical line I clicked on. I think that not only would it be good to have this functionality, it would also be better than the default in many cases. ### Proposed technical implementation details I don't know how it's implemented, but it looks like winterm *does* keep track of logical lines, so that information could be used instead of the physical line. (I'm guessing the above because resizing the window shows that the logical lines are rewrapped; and also if I select a bunch of physical lines that come from a number of long lines, the resulting text has the proper logical newlines, rather than having them at the points where the text got wrapped.)
claunia commented 2026-01-31 08:36:11 +00:00
Author
Owner
Copy Link

@ebarzilay-godaddy commented on GitHub (May 5, 2025):

Sorry, forgot to add that #9881 looks related, but the issue there is choosing just the user input, and nothing about what is the "line" that gets selected.

@ebarzilay-godaddy commented on GitHub (May 5, 2025): Sorry, forgot to add that #9881 looks related, but the issue there is choosing just the user input, and nothing about what is the "line" that gets selected.
claunia commented 2026-01-31 08:36:11 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 5, 2025):

See also #1553.

@j4james commented on GitHub (May 5, 2025): See also #1553.
claunia commented 2026-01-31 08:36:11 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 7, 2025):

I think this is a good call! We should do this (and I don't necessarily think we should make it configurable.) It just makes sense.

@DHowett commented on GitHub (May 7, 2025): I think this is a good call! We should do this (and I don't necessarily think we should make it configurable.) It just makes sense.
claunia commented 2026-01-31 08:36:11 +00:00
Author
Owner
Copy Link

@albus-droid commented on GitHub (May 8, 2025):

06f736bebe/src/cascadia/TerminalControl/ControlCore.cpp (L2032-L2035)

06f736bebe/src/cascadia/TerminalCore/TerminalSelection.cpp (L299-L302)

06f736bebe/src/buffer/out/Row.cpp (L182)

I noticed that .WasWrapForced() marks wrapped rows in the buffer. Would using this in SelectionExpansion::Line for selection be the right approach to implement this?

@albus-droid commented on GitHub (May 8, 2025): https://github.com/microsoft/terminal/blob/06f736bebe84eda0c34b935a875eebe031a899b7/src/cascadia/TerminalControl/ControlCore.cpp#L2032-L2035 https://github.com/microsoft/terminal/blob/06f736bebe84eda0c34b935a875eebe031a899b7/src/cascadia/TerminalCore/TerminalSelection.cpp#L299-L302 https://github.com/microsoft/terminal/blob/06f736bebe84eda0c34b935a875eebe031a899b7/src/buffer/out/Row.cpp#L182 I noticed that `.WasWrapForced()` marks wrapped rows in the buffer. Would using this in `SelectionExpansion::Line` for selection be the right approach to implement this?
claunia commented 2026-01-31 08:36:11 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 8, 2025):

I think so, yes!

@DHowett commented on GitHub (May 8, 2025): I think so, yes!
claunia commented 2026-01-31 08:36:12 +00:00
Author
Owner
Copy Link

@albus-droid commented on GitHub (May 8, 2025):

I'm interested to work on this

@albus-droid commented on GitHub (May 8, 2025): I'm interested to work on this
claunia commented 2026-01-31 08:36:12 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 8, 2025):

Give it a shot! We would love to review a pull request for this. 😃

@DHowett commented on GitHub (May 8, 2025): Give it a shot! We would love to review a pull request for this. 😃
claunia commented 2026-01-31 08:36:12 +00:00
Author
Owner
Copy Link

@albus-droid commented on GitHub (May 8, 2025):

I have created a draft PR and would be happy to make any changes

@albus-droid commented on GitHub (May 8, 2025): I have created a draft PR and would be happy to make any changes
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl good first issue Help Wanted Issue-Task Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23232
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?