starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Safe solution fix issues RTL Text in Windows Terminal #23242

New Issue
Closed
opened 2026-01-31 08:36:24 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:36:24 +00:00
Owner
Copy Link

Originally created by @n-mr on GitHub (May 9, 2025).

Description of the new feature

What's the safe solution?
We enable RTL only if the text is Arabic (by default)
We add code that checks: Does the line contain RTL characters (such as Arabic)

This is the best balance between supporting Arabic and preserving the rest of the functionality
to fix this issues
A function that checks if the text contains Arabic letters.

bool ContainsArabic(const std::wstring& text)
{
for (wchar_t ch : text)
{
if ((ch >= 0x0600 && ch <= 0x06FF) || // Arabic
(ch >= 0x0750 && ch <= 0x077F) || // Arabic Supplement
(ch >= 0x08A0 && ch <= 0x08FF)) // Arabic Extended
{
return true;
}
}
return false;
}

if (ContainsArabic(text))
{
layout->SetReadingDirection(DWRITE_READING_DIRECTION_RIGHT_TO_LEFT);
layout->SetFlowDirection(DWRITE_FLOW_DIRECTION_RIGHT_TO_LEFT);
}

The contains Arabic function checks for Unicode between \u0600 to \u06FF.

Good Luck The biggest company in the world don't have solution for RTL Text Issue 😎

Proposed technical implementation details

No response

Originally created by @n-mr on GitHub (May 9, 2025). ### Description of the new feature What's the safe solution? We enable RTL only if the text is Arabic (by default) We add code that checks: Does the line contain RTL characters (such as Arabic) This is the best balance between supporting Arabic and preserving the rest of the functionality to fix this issues A function that checks if the text contains Arabic letters. bool ContainsArabic(const std::wstring& text) { for (wchar_t ch : text) { if ((ch >= 0x0600 && ch <= 0x06FF) || // Arabic (ch >= 0x0750 && ch <= 0x077F) || // Arabic Supplement (ch >= 0x08A0 && ch <= 0x08FF)) // Arabic Extended { return true; } } return false; } if (ContainsArabic(text)) { layout->SetReadingDirection(DWRITE_READING_DIRECTION_RIGHT_TO_LEFT); layout->SetFlowDirection(DWRITE_FLOW_DIRECTION_RIGHT_TO_LEFT); } The contains Arabic function checks for Unicode between \u0600 to \u06FF. **Good Luck** The biggest **company** in the world don't have solution for RTL Text Issue 😎 ### Proposed technical implementation details _No response_
claunia added the Issue-FeatureResolution-Duplicate labels 2026-01-31 08:36:25 +00:00
claunia commented 2026-01-31 08:36:26 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 9, 2025):

Thanks for the recommendation!

We are not using DWrite TextLayouts. This code is not applicable.

This is, broadly, a /duplicate of #538.

@DHowett commented on GitHub (May 9, 2025): Thanks for the recommendation! We are not using DWrite TextLayouts. This code is not applicable. This is, broadly, a /duplicate of #538.
claunia commented 2026-01-31 08:36:26 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (May 9, 2025):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service[bot] commented on GitHub (May 9, 2025): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! <!-- Policy app identification https://img.shields.io/static/v1?label=PullRequestIssueManagement. -->
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23242
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?