starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add support for OSC 52 clipboard copies in conhost #23288

New Issue
Closed
opened 2026-01-31 08:37:50 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:37:50 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (May 23, 2025).

Description of the new feature

Windows Terminal supports OSC 52 and so conhost should too.

Proposed technical implementation details

This is super easy to do and only requires us to fill out this function:
2d64a3a4ab/src/host/outputStream.cpp (L277-L286)

To do so, we need to extend the Clipboard class to expose this function (in a more convenient way though):
2d64a3a4ab/src/interactivity/win32/clipboard.hpp (L38)

(Note that you need to set Host.EXE as your startup project.)

Originally created by @lhecker on GitHub (May 23, 2025). ### Description of the new feature Windows Terminal supports OSC 52 and so conhost should too. ### Proposed technical implementation details This is super easy to do and only requires us to fill out this function: https://github.com/microsoft/terminal/blob/2d64a3a4ab0d0d1c5b9085a022f5319460ef68d7/src/host/outputStream.cpp#L277-L286 To do so, we need to extend the `Clipboard` class to expose this function (in a more convenient way though): https://github.com/microsoft/terminal/blob/2d64a3a4ab0d0d1c5b9085a022f5319460ef68d7/src/interactivity/win32/clipboard.hpp#L38 (Note that you need to set `Host.EXE` as your startup project.)
claunia commented 2026-01-31 08:37:52 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 25, 2025):

I actually have a old branch with an implementation for this, but it wasn't as easy as you might imagine. As far as I understand, you can only access the clipboard from the main window thread, so I had to post a custom message from the CopyToClipboard handler to pass on the content to the Window::ConsoleWindowProc, and then set the clipboard from there. It all seemed a bit hacky, which is why I abandoned it, but maybe there's an easier solution that I'm missing.

See also #13408, which was kind of tracking this issue amongst other things.

@j4james commented on GitHub (May 25, 2025): I actually have a old branch with an implementation for this, but it wasn't as easy as you might imagine. As far as I understand, you can only access the clipboard from the main window thread, so I had to post a custom message from the `CopyToClipboard` handler to pass on the content to the `Window::ConsoleWindowProc`, and then set the clipboard from there. It all seemed a bit hacky, which is why I abandoned it, but maybe there's an easier solution that I'm missing. See also #13408, which was kind of tracking this issue amongst other things.
claunia commented 2026-01-31 08:37:52 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 26, 2025):

As far as I understand, you can only access the clipboard from the main window thread

Oh right! Yes, I think that's correct. Reading the clipboard without the HWND is possible but not writing it.

@lhecker commented on GitHub (May 26, 2025): > As far as I understand, you can only access the clipboard from the main window thread Oh right! Yes, I think that's correct. Reading the clipboard without the HWND is possible but not writing it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Help Wanted In-PR Issue-Task Needs-Tag-Fix Priority-2 Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23288
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?