starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crashes when drag drop object has certain path pattern #23347

New Issue
Closed
opened 2026-01-31 08:39:36 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 08:39:36 +00:00
Owner
Copy Link

Originally created by @8LWXpg on GitHub (Jun 8, 2025).

Windows Terminal version

1.22.11141.0

Windows build number

10.0.26100.0

Other Software

Wrote a basic Winforms app that performs file/folder drag drop

private void DragSource_MouseMove(object sender, MouseEventArgs e)
{
	if (e.Button != MouseButtons.Left)
	{
		return;
	}

	var dataObject = new DataObject(DataFormats.FileDrop, _path);
	DragDropEffects result = DoDragDrop(dataObject, Globals.ArgParser.Move ? DragDropEffects.Move : DragDropEffects.Copy);
	if (result is DragDropEffects.Move or DragDropEffects.Copy)
	{
		Application.Exit();
	}
}

02f21dca32/dwag/DrageSourceForm.cs (L65-L78)

Steps to reproduce

Certain path pattern cause wt to crash

  • Forward slash: E:/test.txt
  • Relative path: E:\test\..\test.txt, ., .\test.txt

https://github.com/user-attachments/assets/22a38ef8-88d8-49d4-8f75-0ce91d218b07

Expected Behavior

Handles path properly.

Actual Behavior

Crashes

Originally created by @8LWXpg on GitHub (Jun 8, 2025). ### Windows Terminal version 1.22.11141.0 ### Windows build number 10.0.26100.0 ### Other Software Wrote a basic Winforms app that performs file/folder drag drop ```cs private void DragSource_MouseMove(object sender, MouseEventArgs e) { if (e.Button != MouseButtons.Left) { return; } var dataObject = new DataObject(DataFormats.FileDrop, _path); DragDropEffects result = DoDragDrop(dataObject, Globals.ArgParser.Move ? DragDropEffects.Move : DragDropEffects.Copy); if (result is DragDropEffects.Move or DragDropEffects.Copy) { Application.Exit(); } } ``` https://github.com/8LWXpg/dwag/blob/02f21dca322850c3fb2786f0e07ed2c630dcab4f/dwag/DrageSourceForm.cs#L65-L78 ### Steps to reproduce Certain path pattern cause wt to crash - Forward slash: `E:/test.txt` - Relative path: `E:\test\..\test.txt`, `.`, `.\test.txt` https://github.com/user-attachments/assets/22a38ef8-88d8-49d4-8f75-0ce91d218b07 ### Expected Behavior Handles path properly. ### Actual Behavior Crashes
claunia commented 2026-01-31 08:39:39 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 11, 2025):

Well, that's not good.

@DHowett commented on GitHub (Jun 11, 2025): Well, that's not good.
claunia commented 2026-01-31 08:39:39 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 11, 2025):

I first thought that it would be a problem in our path translation code, but you're pasting into an untranslated terminal control... so it's probably in the general drop handler here:

557a193cb7/src/cascadia/TerminalControl/TermControl.cpp (L3174-L3257)

@DHowett commented on GitHub (Jun 11, 2025): I first thought that it would be a problem in our path translation code, but you're pasting into an untranslated terminal control... so it's probably in the general drop handler here: https://github.com/microsoft/terminal/blob/557a193cb7affac7b1564c5fcd6d3a2ddc7e5fd6/src/cascadia/TerminalControl/TermControl.cpp#L3174-L3257
claunia commented 2026-01-31 08:39:40 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Jun 12, 2025):

What is the FullName ?. Powershell wouldn't give the RelativePath for FullName. It would give the fully rooted path. So im betting there is something in the path that Terminal doesnt like. Any change you could comment that? @8LWXpg

@jamespack commented on GitHub (Jun 12, 2025): What is the `FullName` ?. Powershell wouldn't give the `RelativePath` for `FullName`. It would give the fully rooted path. So im betting there is something in the path that Terminal doesnt like. Any change you could comment that? @8LWXpg
claunia commented 2026-01-31 08:39:40 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Jun 12, 2025):

Nevermind. It is the relative path. My bad.

@jamespack commented on GitHub (Jun 12, 2025): Nevermind. It is the relative path. My bad.
claunia commented 2026-01-31 08:39:40 +00:00
Author
Owner
Copy Link

@8LWXpg commented on GitHub (Jun 14, 2025):

The PR just prevent crashes but still not resolving relative path and forward slash, right?

@8LWXpg commented on GitHub (Jun 14, 2025): The PR just prevent crashes but still not resolving relative path and forward slash, right?
claunia commented 2026-01-31 08:39:41 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Jun 15, 2025):

Correct

@jamespack commented on GitHub (Jun 15, 2025): Correct
claunia commented 2026-01-31 08:39:41 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Jun 15, 2025):

The storage apis returned null. Hence the crash. That's upstream from terminal. Not sure where that bug should be filed if at all.

@jamespack commented on GitHub (Jun 15, 2025): The storage apis returned null. Hence the crash. That's upstream from terminal. Not sure where that bug should be filed if at all.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?