starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

VERSIONINFO resource is non-compliant #23426

New Issue
Closed
opened 2026-01-31 08:41:51 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:41:51 +00:00
Owner
Copy Link

Originally created by @alabuzhev on GitHub (Jul 7, 2025).

Originally assigned to: @DHowett on GitHub.

Windows Terminal version

1.24.2507.04001

Windows build number

Irrelevant

Other Software

No response

Steps to reproduce

  1. Get the latest terminal nightly.
  2. Pick any PE binary from the distribution, e.g. OpenConsole.exe.
  3. Extract its VERSIONINFO resource using third party tools.
  4. Do the same for any other typical Windows binary, e.g. conhost.exe.
  5. Compare both.

Expected Behavior

The basic structure should be consistent (see below).

Actual Behavior

There are quite a few differences:

Image

The most problematic one is that VarFileInfo.Translation is inconsistent with StringFileInfo header:

  • VarFileInfo.Translation is [0, 1200] => [language neutral, Unicode]
  • StringFileInfo header is "040904b0" => [U.S. English, Unicode]

This ultimately means that third-party apps cannot query version information of these binaries using VerQueryValue API, because they are supposed to obtain the language-codepage pair from VarFileInfo.Translation first, serialise it as %04x%04x and use that as a key to request data from a corresponding block in StringFileInfo, but serialising [0, 1200] obviously yields "000004b0", which is not there.

Image

Notice that the StringFileInfo block is missing. The tool has failed to find it in OpenConsole.

Minor issues:

  • All the Windows binaries and probably most of binaries in the wild these days set FILEOS to VOS_NT_WINDOWS32 (0x40004), i.e. "Win32 subsystem running on NT", which is probably the only reasonable combination anyway. In WT binaries it is for some reason set to just 0x4, i.e. VOS__WINDOWS32. The high word is 0, implying that the base OS is VOS_UNKNOWN. Not a big deal, but can be confusing.
  • Spaces in LegalCopyright seems to be off.
  • FileDescription could be better :)

Very minor issues:

  • When I build locally, binaries don't include version info, is it by design?
Originally created by @alabuzhev on GitHub (Jul 7, 2025). Originally assigned to: @DHowett on GitHub. ### Windows Terminal version 1.24.2507.04001 ### Windows build number Irrelevant ### Other Software _No response_ ### Steps to reproduce 1. Get the latest terminal nightly. 2. Pick any PE binary from the distribution, e.g. OpenConsole.exe. 3. Extract its VERSIONINFO resource using third party tools. 4. Do the same for any other typical Windows binary, e.g. conhost.exe. 5. Compare both. ### Expected Behavior The basic structure should be consistent (see below). ### Actual Behavior There are quite a few differences: <img width="1488" height="502" alt="Image" src="https://github.com/user-attachments/assets/32f58d88-bb97-4c05-b815-30cf4da211dd" /> The most problematic one is that VarFileInfo.Translation is inconsistent with StringFileInfo header: - VarFileInfo.Translation is [0, 1200] => [language neutral, Unicode] - StringFileInfo header is "040904b0" => [U.S. English, Unicode] This ultimately means that third-party apps cannot query version information of these binaries using [VerQueryValue](https://learn.microsoft.com/en-us/windows/win32/api/winver/nf-winver-verqueryvaluew) API, because they are [supposed to](https://learn.microsoft.com/en-us/windows/win32/api/winver/nf-winver-verqueryvaluew#examples) obtain the [language-codepage pair](https://learn.microsoft.com/en-us/windows/win32/menurc/stringfileinfo-block#remarks) from VarFileInfo.Translation first, serialise it as %04x%04x and use that as a key to request data from a corresponding block in StringFileInfo, but serialising [0, 1200] obviously yields "**0000**04b0", which is not there. <img width="889" height="409" alt="Image" src="https://github.com/user-attachments/assets/72b95048-a2b8-4b24-b1c2-71d6d6fcdecb" /> Notice that the StringFileInfo block is missing. The tool has failed to find it in OpenConsole. Minor issues: - All the Windows binaries and probably most of binaries in the wild these days set FILEOS to VOS_NT_WINDOWS32 (0x40004), i.e. "Win32 subsystem running on NT", which is probably the only reasonable combination anyway. In WT binaries it is for some reason set to just 0x4, i.e. VOS__WINDOWS32. The high word is 0, implying that the base OS is VOS_UNKNOWN. Not a big deal, but can be confusing. - Spaces in LegalCopyright seems to be off. - FileDescription could be better :) Very minor issues: - When I build locally, binaries don't include version info, is it by design?
claunia added the Issue-BugPriority-3Needs-Tag-FixProduct-MetaArea-Build labels 2026-01-31 08:41:53 +00:00
claunia commented 2026-01-31 08:41:55 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 9, 2025):

So, this one has an interesting history! We used to rely on the Windows internal versioning rules through some lovecraftian horror of a build system. We (I) identified this specific issue early on, worked around it (#5274):

02f173d504/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (L1063)

This introduces a magic LCID constant (0x0409). By default, Package ES emits
version resource information that says we're localized to ... language zero.
It also emits a language-coded version block for 0x0409 (en-US).

These two things cannot both be true. Collapse the wave function by hardcoding
0x0409.

... and decided it was out of our hands to handle.

Since then, though, we forked their code and made it not depend on the rest of their terrible build system.

We {sh,c}ould probably fix it now.

@DHowett commented on GitHub (Jul 9, 2025): So, this one has an interesting history! We used to rely on the Windows internal versioning rules through some lovecraftian horror of a build system. We (I) identified this specific issue early on, worked around it (#5274): https://github.com/microsoft/terminal/blob/02f173d504d82a05da048981c56b7402c11b6c0c/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp#L1063 > This introduces a magic LCID constant (0x0409). By default, Package ES emits > version resource information that says we're localized to ... language zero. > It also emits a language-coded version block for 0x0409 (en-US). > > These two things cannot both be true. Collapse the wave function by hardcoding > 0x0409. ... and decided it was out of our hands to handle. Since then, though, we forked their code and made it not depend on the rest of their terrible build system. We {sh,c}ould probably fix it now.
claunia commented 2026-01-31 08:41:55 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 9, 2025):

When I build locally, binaries don't include version info, is it by design?

Alas, it is. Now that we nominally "own" the versioning package, I think we could fix this. It's just a nuget package with some pre-build rules. I actually really like it - it's like NerdBank's GitVersion but not awful.

@DHowett commented on GitHub (Jul 9, 2025): > When I build locally, binaries don't include version info, is it by design? Alas, it is. Now that we nominally "own" the versioning package, I think we could fix this. It's just a nuget package with some pre-build rules. I actually really like it - it's like NerdBank's GitVersion but not awful.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Bug Needs-Tag-Fix Priority-3 Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23426
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?