starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Memory leak #23524

New Issue
Open
opened 2026-01-31 08:44:43 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 08:44:43 +00:00
Owner
Copy Link

Originally created by @PetarPetrushev on GitHub (Aug 16, 2025).

Windows Terminal version

1.22.12111.0

Windows build number

10.0.26100.4946

Other Software

No response

Steps to reproduce

Enter curl https://s1.cubzyn.net/other/curl.me.php (which curls a large amount of binary to the terminal)
And now even if the user closes the terminal window even after the command finished the console window and PTY process uses many gigabytes of RAM and continues to use more until it crashes. I have attached the source code of the PHP script.

curl.me.php

Expected Behavior

Since binary is being sent to terminal some issues are expected such as bells, messed up terminal or messed up input. However not a large memory leak.

Actual Behavior

Terminal freezes when command finishes due to the memory leak and leaks gigabytes of memory in the PTY host process until it crashes.

Originally created by @PetarPetrushev on GitHub (Aug 16, 2025). ### Windows Terminal version 1.22.12111.0 ### Windows build number 10.0.26100.4946 ### Other Software _No response_ ### Steps to reproduce Enter **curl https://s1.cubzyn.net/other/curl.me.php** (which curls a large amount of binary to the terminal) And now even if the user closes the terminal window even after the command finished the console window and PTY process uses many gigabytes of RAM and continues to use more until it crashes. I have attached the source code of the PHP script. [curl.me.php](https://github.com/user-attachments/files/21806483/curl.me.php) ### Expected Behavior Since binary is being sent to terminal some issues are expected such as bells, messed up terminal or messed up input. However not a large memory leak. ### Actual Behavior Terminal freezes when command finishes due to the memory leak and leaks gigabytes of memory in the PTY host process until it crashes.
claunia commented 2026-01-31 08:44:44 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 20, 2025):

So, there are a couple places where we cache in-progress VT sequences (SOS, APC, PM, DCS, and OSC); if you spam a bunch of random data you will eventually generate a control sequence introducer and cause us to start buffering...

But also,

... why?

@DHowett commented on GitHub (Aug 20, 2025): So, there are a couple places where we cache in-progress VT sequences (SOS, APC, PM, DCS, and OSC); if you spam a bunch of random data you _will_ eventually generate a control sequence introducer and cause us to start buffering... But also, ... why?
claunia commented 2026-01-31 08:44:45 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 15, 2025):

I have tried this locally with and without the use of curl and could not observe a memory leak myself. Unassigning this issue until someone can reproduce and investigate this.

@lhecker commented on GitHub (Oct 15, 2025): I have tried this locally with and without the use of `curl` and could not observe a memory leak myself. Unassigning this issue until someone can reproduce and investigate this.
claunia commented 2026-01-31 08:44:45 +00:00
Author
Owner
Copy Link

@PetarPetrushev commented on GitHub (Oct 15, 2025):

Hi. I just retried this and did not experience the memory leak so I think it may have been patched by a different change.

@PetarPetrushev commented on GitHub (Oct 15, 2025): Hi. I just retried this and did not experience the memory leak so I think it may have been patched by a different change.
claunia commented 2026-01-31 08:44:45 +00:00
Author
Owner
Copy Link

@PetarPetrushev commented on GitHub (Oct 15, 2025):

Hi. After doing some more testing this is still and issue and you can reproduce it if you run the command a few more times as the PHP script randomizes the output. I had the issue happen to me after about 5 trys. Try it a few more times as it is random. When it happened this time it froze my PC and i had to reboot.

@PetarPetrushev commented on GitHub (Oct 15, 2025): Hi. After doing some more testing this is still and issue and you can reproduce it if you run the command a few more times as the PHP script randomizes the output. I had the issue happen to me after about 5 trys. Try it a few more times as it is random. When it happened this time it froze my PC and i had to reboot.
claunia commented 2026-01-31 08:44:45 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 15, 2025):

I've tried it lots and lots of times now and couldn't get it to reproduce.

@lhecker commented on GitHub (Oct 15, 2025): I've tried it lots and lots of times now and couldn't get it to reproduce.
claunia commented 2026-01-31 08:44:45 +00:00
Author
Owner
Copy Link

@PetarPetrushev commented on GitHub (Oct 15, 2025):

I will test it on a new fresh installed VM to see if it occurs. I will attach a video if it.

@PetarPetrushev commented on GitHub (Oct 15, 2025): I will test it on a new fresh installed VM to see if it occurs. I will attach a video if it.
claunia commented 2026-01-31 08:44:46 +00:00
Author
Owner
Copy Link

@PetarPetrushev commented on GitHub (Oct 15, 2025):

Actualy im having some issues getting the VM to work however the issue still occurs for me. I am on windows [Version 10.0.26100.6899] terminal: 1.23.12811.0

@PetarPetrushev commented on GitHub (Oct 15, 2025): Actualy im having some issues getting the VM to work however the issue still occurs for me. I am on windows [Version 10.0.26100.6899] terminal: 1.23.12811.0
claunia commented 2026-01-31 08:44:46 +00:00
Author
Owner
Copy Link

@psnet commented on GitHub (Nov 7, 2025):

Hi. After doing some more testing this is still and issue and you can reproduce it if you run the command a few more times as the PHP script randomizes the output. I had the issue happen to me after about 5 trys. Try it a few more times as it is random. When it happened this time it froze my PC and i had to reboot.

I think for reproducible example you can pregenerate 10 files and curl these pregenerated files each. Find that one who do memory leak and update this issue with that uploaded STATIC file instead of .php file, so everyone can reproduce that case.

@psnet commented on GitHub (Nov 7, 2025): > Hi. After doing some more testing this is still and issue and you can reproduce it if you run the command a few more times as the PHP script randomizes the output. I had the issue happen to me after about 5 trys. Try it a few more times as it is random. When it happened this time it froze my PC and i had to reboot. I think for reproducible example you can **pregenerate** 10 files and `curl` these pregenerated files each. Find that **one** who do memory leak and update this issue with that **uploaded** **_STATIC_** file instead of `.php` file, so everyone can reproduce that case.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Quality Impact-Correctness Issue-Bug Priority-3 Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23524
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?