starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Accessibility issues post-#19344 #23639

New Issue
Open
opened 2026-01-31 08:47:56 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:47:56 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Sep 24, 2025).

Originally assigned to: @lhecker on GitHub.

CC @lhecker

Compared the following two versions side-by-side:

  • commit e80aadd98 on Release config (immediately previous to PR #19344)
  • WT Canary OpenConsole on 9/23/2025 v1.25.2651.0 (should point to commit 4600c4791 aka PR #19344)

Tested with Narrator and NVDA. NVDA works fine. The following issues were found with Narrator.

Scenario 1: inputting text

Scenario: type "12345" slowly
Expected: screen reader should say "1 2 3 4 5" as it writes each character
Actual: screen reader says "1 1 2 2 3 3 4 4 5 5"

Looks like there's a "local echo". In Windows Terminal, this would normally be caused by the screen reader reading the input character then the newly drawn character. It might be possible that a similar thing is now happening here. We got around it in #12358 by checking if the output text matched the input text, and suppressing that notification.

Scenario 2: moving the cursor

Scenario: with the cursor at the right end of "12345", slowly press the left button
Expected: screen reader should read each character as the cursor is on top of it
Actual: screen reader is silent

NOTE: it looks like the screen reader normally reads the character specifically when the cursor blinks. Definitely bizarre.

Scenario 3: deleting text

Scenario: with the cursor at the right end of "12345", slowly press the backspace button
Expected: screen reader should say "5 4 3 2 1" as it deletes each character
Actual: screen reader is silent

Debugging Tips

AccEvent

Docs: https://learn.microsoft.com/en-us/windows/win32/winauto/accessible-event-watcher
Path: "C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\accevent.exe"

You can use this to take a look at any accessibility events that are being dispatched.
The main ones to look out for are...

  • Text_TextChanged: should be raised whenever text is changed (added, deleted, etc.)
  • Text_TextSelectionChanged: raised whenever the selection of text changes, or whenever the insertion point (caret) moves among the text.

It looks like the second one isn't being dispatched at all, so that'll probably go a long way to fixing the issues above.

Telemetry

We have some telemetry set up for UIA here: 4600c4791b/src/types/UiaTracing.cpp (L13)

I'm totally blanking on the app I used to hook into this guid, but you should be able to register the guid and see exactly what is running under the hood. Feel free to update UiaTracing.cpp and UiaTextRangeBase.cpp accordingly if you want more information than what's provided.

Other helpful docs and tips

https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-implementingtextandtextrange

It may be worth running OpenConsole as a Release config, I've had trouble sometimes where the Debug config is too slow and the screen reader times out.

Originally created by @carlos-zamora on GitHub (Sep 24, 2025). Originally assigned to: @lhecker on GitHub. CC @lhecker Compared the following two versions side-by-side: - commit e80aadd98 on Release config (immediately previous to PR #19344) - WT Canary OpenConsole on 9/23/2025 v1.25.2651.0 (should point to commit 4600c4791 aka PR #19344) Tested with Narrator and NVDA. NVDA works fine. The following issues were found with Narrator. ## Scenario 1: inputting text Scenario: type "12345" slowly Expected: screen reader should say "1 2 3 4 5" as it writes each character Actual: screen reader says "1 1 2 2 3 3 4 4 5 5" Looks like there's a "local echo". In Windows Terminal, this would normally be caused by the screen reader reading the input character then the newly drawn character. It might be possible that a similar thing is now happening here. We got around it in #12358 by checking if the output text matched the input text, and suppressing that notification. ## Scenario 2: moving the cursor Scenario: with the cursor at the right end of "12345", slowly press the left button Expected: screen reader should read each character as the cursor is on top of it Actual: screen reader is silent NOTE: it looks like the screen reader normally reads the character specifically when the cursor blinks. Definitely bizarre. ## Scenario 3: deleting text Scenario: with the cursor at the right end of "12345", slowly press the backspace button Expected: screen reader should say "5 4 3 2 1" as it deletes each character Actual: screen reader is silent ### Debugging Tips #### AccEvent Docs: https://learn.microsoft.com/en-us/windows/win32/winauto/accessible-event-watcher Path: "C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\accevent.exe" You can use this to take a look at any accessibility events that are being dispatched. The main ones to look out for are... - Text_TextChanged: should be raised whenever text is changed (added, deleted, etc.) - Text_TextSelectionChanged: raised whenever the selection of text changes, or whenever the insertion point (caret) moves among the text. It looks like the second one isn't being dispatched at all, so that'll probably go a long way to fixing the issues above. #### Telemetry We have some telemetry set up for UIA here: https://github.com/microsoft/terminal/blob/4600c4791b6dbe81c40497f0d0af1d0457ec0b8c/src/types/UiaTracing.cpp#L13 I'm totally blanking on the app I used to hook into this guid, but you should be able to register the guid and see exactly what is running under the hood. Feel free to update UiaTracing.cpp and UiaTextRangeBase.cpp accordingly if you want more information than what's provided. #### Other helpful docs and tips https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-implementingtextandtextrange It may be worth running OpenConsole as a Release config, I've had trouble sometimes where the Debug config is too slow and the screen reader times out.
claunia added the Product-ConhostIssue-BugPriority-1Area-Accessibility labels 2026-01-31 08:47:56 +00:00
claunia commented 2026-01-31 08:47:57 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 24, 2025):

Tested with Narrator and NVDA. NVDA works fine. The following issues were found with Narrator.

Oof. I only tested this with NVDA. 🤦 Thank you for doing this!
FWIW, Narrator uses MSAA and not UIA. 🥲

@lhecker commented on GitHub (Sep 24, 2025): > Tested with Narrator and NVDA. NVDA works fine. The following issues were found with Narrator. Oof. I only tested this with NVDA. 🤦 Thank you for doing this! FWIW, Narrator uses MSAA and not UIA. 🥲
claunia commented 2026-01-31 08:47:57 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 24, 2025):

Scenario 1 is because I'm passing exclusive coordinates to AccessibilityNotifier::RegionChanged even though it expects inclusive ones (= need to decrement them).

Scenario 2 is making me nuts, because I seem to be doing the exact same thing as the old code, but it doesn't work.

Scenario 3 is because I'm not sorting the coordinates to AccessibilityNotifier::RegionChanged in ascending order and because I'm raising the new contents, not the old contents (= spaces when backspacing).

@lhecker commented on GitHub (Sep 24, 2025): Scenario 1 is because I'm passing exclusive coordinates to `AccessibilityNotifier::RegionChanged` even though it expects inclusive ones (= need to decrement them). Scenario 2 is making me nuts, because I seem to be doing the exact same thing as the old code, but it doesn't work. Scenario 3 is because I'm not sorting the coordinates to `AccessibilityNotifier::RegionChanged` in ascending order _and_ because I'm raising the _new_ contents, not the old contents (= spaces when backspacing).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Issue-Bug Priority-1 Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23639
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?