starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Equals method in OpenSettingsArgs contains extra semicolon #23656

New Issue
Open
opened 2026-01-31 08:48:25 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 08:48:25 +00:00
Owner
Copy Link

Originally created by @Ujjansh05 on GitHub (Oct 2, 2025).

In ActionArgs.h, the Equals method of the OpenSettingsArgs class contains an extra semicolon after the closing brace:

Image 
bool Equals(const IActionArgs& other)
{
    auto otherAsUs = other.try_as<OpenSettingsArgs>();
    if (otherAsUs)
    {
        return otherAsUs->_Target == _Target;
    }
    return false;
};

While syntactically allowed, this is considered poor style and is flagged in the documentation. It should be removed for clarity and consistency with WinRT/C++ coding conventions.

bool Equals(const IActionArgs& other)
{
    auto otherAsUs = other.try_as<OpenSettingsArgs>();
    if (otherAsUs)
    {
        return otherAsUs->_Target == _Target;
    }
    return false;
}

Impact
Minor stylistic issue, but fixing it improves code readability and maintains consistent coding standards.

Originally created by @Ujjansh05 on GitHub (Oct 2, 2025). In ActionArgs.h, the Equals method of the OpenSettingsArgs class contains an extra semicolon after the closing brace: <img width="1828" height="960" alt="Image" src="https://github.com/user-attachments/assets/0c6db4d3-500d-4b4d-9576-ee7b48735aec" /> ``` bool Equals(const IActionArgs& other) { auto otherAsUs = other.try_as<OpenSettingsArgs>(); if (otherAsUs) { return otherAsUs->_Target == _Target; } return false; }; ``` While syntactically allowed, this is considered poor style and is flagged in the documentation. It should be removed for clarity and consistency with WinRT/C++ coding conventions. ``` bool Equals(const IActionArgs& other) { auto otherAsUs = other.try_as<OpenSettingsArgs>(); if (otherAsUs) { return otherAsUs->_Target == _Target; } return false; } ``` Impact Minor stylistic issue, but fixing it improves code readability and maintains consistent coding standards.
claunia added the Needs-TriageNeeds-Tag-Fix labels 2026-01-31 08:48:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?