starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Command line buffer insertion error in WSL #238

New Issue
Closed
opened 2026-01-30 21:46:35 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 21:46:35 +00:00
Owner
Copy Link

Originally created by @tealsuki on GitHub (Apr 29, 2018).

Microsoft Windows [Version 10.0.16299.371]

Context: This issue was discovered after editing the same command multiple times, after the length of the command extended past the window boundary. Reproducibility may vary.

  • Attempted to create a long chain command with a python utility to retrieve files from Internet Archive

tealsuki@DESKTOP-NENQ6QK:/mnt/d/temp$ ia search 'collection:solarsystemcollection' --itemlist | parallel --no-notice -j4 'ia download {} --glob="*.jpg|*.jpeg"'

  • Decide to cancel and change parameters (CTRL+C, followed by UPARROW to return to command in buffer, followed by cursoring through and editing the command)

tealsuki@DESKTOP-NENQ6QK:/mnt/d/temp$ ia search 'collection:printer-manuals-lexmark' --itemlist | parallel --no-notice -j4 'ia download {} --glob="*.pdf"'

image

  • What's wrong / what should be happening instead:

Command fails silently in this instance.
Upon returning to it in the buffer, it is revealed that the insertion point was in the incorrect position, parts of the displayed text were chopped out when the first character was inserted.

image

  • Additional notes
    When editing the command, pressing the up arrow once more to traverse the buffer, and then pressing the down arrow to return to what Bash has saved as the "workspace" command (my description) will present the actual state of the command again.

Traversing the buffer multiple steps may affect reproducibility
Resizing the window may also affect reproducibility

May be related to WSL#1307 WSL#1497 and WSL#1756

  • Console settings:
    image image
Originally created by @tealsuki on GitHub (Apr 29, 2018). ### Microsoft Windows [Version 10.0.16299.371] Context: This issue was discovered after editing the same command multiple times, after the length of the command extended past the window boundary. Reproducibility may vary. * Attempted to create a long chain command with a python utility to retrieve files from Internet Archive `tealsuki@DESKTOP-NENQ6QK:/mnt/d/temp$ ia search 'collection:solarsystemcollection' --itemlist | parallel --no-notice -j4 'ia download {} --glob="*.jpg|*.jpeg"'` * Decide to cancel and change parameters (CTRL+C, followed by UPARROW to return to command in buffer, followed by cursoring through and editing the command) `tealsuki@DESKTOP-NENQ6QK:/mnt/d/temp$ ia search 'collection:printer-manuals-lexmark' --itemlist | parallel --no-notice -j4 'ia download {} --glob="*.pdf"'` ![image](https://user-images.githubusercontent.com/1473126/39403873-9084dbb4-4b5c-11e8-9225-66ea8061cd0c.png) * What's wrong / what should be happening instead: Command fails silently in this instance. Upon returning to it in the buffer, it is revealed that the insertion point was in the incorrect position, parts of the displayed text were chopped out when the first character was inserted. ![image](https://user-images.githubusercontent.com/1473126/39403892-e4ee176a-4b5c-11e8-8dd9-b9dc43277e7b.png) * Additional notes When editing the command, pressing the up arrow once more to traverse the buffer, and then pressing the down arrow to return to what Bash has saved as the "workspace" command (my description) will present the actual state of the command again. Traversing the buffer multiple steps may affect reproducibility Resizing the window may also affect reproducibility May be related to [WSL#1307](https://github.com/Microsoft/WSL/issues/1307) [WSL#1497](https://github.com/Microsoft/WSL/issues/1497) and [WSL#1756](https://github.com/Microsoft/WSL/issues/1756) * Console settings: ![image](https://user-images.githubusercontent.com/1473126/39403730-2bcb1344-4b59-11e8-9f3b-86b8b25a5341.png) ![image](https://user-images.githubusercontent.com/1473126/39403734-35dc821e-4b59-11e8-9d15-ff3447e6f561.png)
claunia commented 2026-01-30 21:46:36 +00:00
Author
Owner
Copy Link

@tealsuki commented on GitHub (Apr 30, 2018):

Issue persists in Windows 10 Version 1803

tempsnip

Judging by the "so" leftover from the previous command, and the unexpected immediate visual deletion of the "' " (single quote and a space) the internal cursor seemed to assume it was 2 places to the right of where I'd intended to begin deletion with the visual cursor (positioned at the closing single quote). This appears to also be limited to the last executed command in my test. Further traversal does not produce the same effect.

Also important to note that the length of the deletion/cursor shift may not always be 2 characters, it happens to be the case with this particular command's length and buffer/window configuration. More rigorous testing is necessary.

@tealsuki commented on GitHub (Apr 30, 2018): Issue persists in Windows 10 Version 1803 ![tempsnip](https://user-images.githubusercontent.com/1473126/39451589-8733b2c0-4ca5-11e8-8c10-292f2bb1cbc4.png) Judging by the "so" leftover from the previous command, and the unexpected immediate visual deletion of the "' " (single quote and a space) the internal cursor seemed to assume it was 2 places to the right of where I'd intended to begin deletion with the visual cursor (positioned at the closing single quote). This appears to also be limited to the last executed command in my test. Further traversal does not produce the same effect. Also important to note that the length of the deletion/cursor shift may not always be 2 characters, it happens to be the case with this particular command's length and buffer/window configuration. More rigorous testing is necessary.
claunia commented 2026-01-30 21:46:36 +00:00
Author
Owner
Copy Link

@tfinn81 commented on GitHub (Jun 26, 2019):

Still having this issue in 1803 build 17134.765.

@tfinn81 commented on GitHub (Jun 26, 2019): Still having this issue in 1803 build 17134.765.
claunia commented 2026-01-30 21:46:36 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jun 27, 2019):

That build is two major versions out of date. Learning that it still reproduces as of approximately two (at this point) years ago is not helpful 😄

@DHowett-MSFT commented on GitHub (Jun 27, 2019): That build is _two major versions_ out of date. Learning that it still reproduces as of approximately two (at this point) years ago is not helpful :smile:
claunia commented 2026-01-30 21:46:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 22, 2021):

@tealsuki Is this still happening for you (especially in the Windows Terminal)? This report's a few years old now and hasn't had any bumps on any recent builds of Windows, so it's entirely possible that this is something we just fixed along the way.

@zadjii-msft commented on GitHub (Nov 22, 2021): @tealsuki Is this still happening for you (especially in the Windows Terminal)? This report's a few years old now and hasn't had any bumps on any _recent_ builds of Windows, so it's entirely possible that this is something we just fixed along the way.
claunia commented 2026-01-30 21:46:37 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 26, 2021):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Nov 26, 2021): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Needs-Author-Feedback Needs-Repro No-Recent-Activity Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#238
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?