starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Color Picker Lightness Bar/Selector Inoperative #23812

New Issue
Closed
opened 2026-01-31 08:53:16 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:53:16 +00:00
Owner
Copy Link

Originally created by @McCovican on GitHub (Nov 17, 2025).

Originally assigned to: @carlos-zamora on GitHub.

Windows Terminal version

1.23.12811.0 && 1.24.2812.0

Windows build number

10.0.19045.6575

Other Software

No response

Steps to reproduce

  • Open the settings menu of Windows Terminal (stable or preview);
  • Go to any option that allows you to customize the colour;
  • Click "More Colors";
  • A colour-picker menu opens up;
  • The large, main square lets you select hue & saturation – this works fine;
  • The thin vertical bar on the right is to select the colour lightness value;
  • Click on it;

Expected Behavior

You are meant to be able to click a linear y-axis location on this bar, which changes the lightness value of the selected colour.
The bar should also visibly display a gradient of all the lightness values possible for the current hue/saturation selected in the main 2D square box to the left.

Image

Actual Behavior

Clicking on the lightness bar does nothing. Zero feedback whatsoever;
The bar also does not display a lightness gradient – instead, it shows only the actual colour selected. This colour can be influenced by what is selected in the X/Y hue/lightness box, but the lightness value seems to be based solely on the original colour of the property that you're currently modifying. (You can see that it very doesn't match the shade of blue selected in the box)

Image

NB: Ultimately, the colour can be fully configured by setting the hex value manually in the config, but man, that's a right faff.

PS: I actually would've expected the hue to be the thin bar, with lightness/saturation in the larger box. But if the X/Y box is to be hue/saturation, I would then expect the lightness value on the right to dynamically impact the colours shown in the main X/Y box. Ultimately not critical, but if the main box doesn't dynamically update, you'd need to add a new UI element somewhere that accurately represents the currently-selected colour.

Originally created by @McCovican on GitHub (Nov 17, 2025). Originally assigned to: @carlos-zamora on GitHub. ### Windows Terminal version 1.23.12811.0 && 1.24.2812.0 ### Windows build number 10.0.19045.6575 ### Other Software _No response_ ### Steps to reproduce - Open the settings menu of Windows Terminal (stable or preview); - Go to any option that allows you to customize the colour; - Click "More Colors"; - A colour-picker menu opens up; - The large, main square lets you select hue & saturation – this works fine; - The thin vertical bar on the right is to select the colour lightness value; - Click on it; ### Expected Behavior You are meant to be able to click a linear y-axis location on this bar, which changes the lightness value of the selected colour. The bar should also visibly display a gradient of all the lightness values possible for the current hue/saturation selected in the main 2D square box to the left. <img width="1092" height="676" alt="Image" src="https://github.com/user-attachments/assets/ce6deb78-d819-4981-afd5-45594c3a0a47" /> ### Actual Behavior Clicking on the lightness bar does nothing. Zero feedback whatsoever; The bar also does not display a lightness gradient – instead, it shows only the actual colour selected. This colour can be influenced by what is selected in the X/Y hue/lightness box, but the lightness value seems to be based solely on the original colour of the property that you're currently modifying. (You can see that it very doesn't match the shade of blue selected in the box) <img width="1092" height="676" alt="Image" src="https://github.com/user-attachments/assets/fb4ec5ab-384b-49c4-950f-c3eb1171baf4" /> NB: Ultimately, the colour can be fully configured by setting the hex value manually in the config, but man, that's a right faff. PS: I actually would've expected the *hue* to be the thin bar, with lightness/saturation in the larger box. But if the X/Y box is to be hue/saturation, I would then expect the lightness value on the right to dynamically impact the colours shown in the main X/Y box. Ultimately not *critical*, but if the main box doesn't dynamically update, you'd need to add a *new* UI element *somewhere* that accurately represents the currently-selected colour.
claunia added the Issue-BugNeeds-Tag-FixProduct-TerminalArea-UserInterface labels 2026-01-31 08:53:16 +00:00
claunia commented 2026-01-31 08:53:18 +00:00
Author
Owner
Copy Link

@McCovican commented on GitHub (Nov 19, 2025):

Update: So, this seems to only happen when altering colours that are in a profile. I just found the whole custom colour schemes thing and...

Image

Seems my assumption about the right-side bar being for lightness was in error. Altering colours in a profile (eg: caret colour) is just missing the entire lower-half of the colour-picker box.

@McCovican commented on GitHub (Nov 19, 2025): Update: So, this seems to only happen when altering colours that are *in a profile*. I just found the whole custom colour schemes thing and... <img width="1092" height="676" alt="Image" src="https://github.com/user-attachments/assets/65efdf47-bc87-4d54-ba7a-8b4f36724de9" /> Seems my assumption about the right-side bar being for lightness was in error. Altering colours in a profile (eg: caret colour) is just missing the entire lower-half of the colour-picker box.
claunia commented 2026-01-31 08:53:18 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Nov 19, 2025):

Thanks for filing! Yeah, so the profiles use a custom control I created called the NullableColorPicker. This reuses the color picker in WinUI, but it handles the conversion between the color type Terminal uses and the one WinUI uses. The color picker for color schemes just uses the built-in WinUI one.

There's several customizations that can be applied to the WinUI one (see below). Looks like we should enable a few more of them like "IsMoreButtonVisible" and "IsColorSliderVisible", at least.

Image
@carlos-zamora commented on GitHub (Nov 19, 2025): Thanks for filing! Yeah, so the profiles use a custom control I created called the `NullableColorPicker`. This reuses the color picker in WinUI, but it handles the conversion between the color type Terminal uses and the one WinUI uses. The color picker for color schemes just uses the built-in WinUI one. There's several customizations that can be applied to the WinUI one (see below). Looks like we should enable a few more of them like "IsMoreButtonVisible" and "IsColorSliderVisible", at least. <img width="814" height="588" alt="Image" src="https://github.com/user-attachments/assets/717de7b0-6884-4ccd-85e2-8656c7344df5" />
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?