starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Regression: CorvusSKK candidate window invisible in Windows Terminal Preview 1.24.251216004 #23946

New Issue
Closed
opened 2026-01-31 08:56:57 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 08:56:57 +00:00
Owner
Copy Link

Originally created by @hirsaeki on GitHub (Jan 8, 2026).

Windows Terminal version

1.24.251216004

Windows build number

26200.7462

Other Software

CorvusSKK: 3.3.1

Steps to reproduce

  1. Install Windows Terminal Preview 1.24.251216004-preview.
  2. Ensure CorvusSKK 3.3.1 is installed and set as the current IME.
  3. Launch Windows Terminal Preview (non-elevated; not running as Administrator).
  4. Open a tab (e.g., PowerShell).
  5. Switch to Japanese input with CorvusSKK.
  6. Type a reading (e.g., nihongo).
  7. Trigger conversion / candidate selection (e.g., Space / usual CorvusSKK conversion action).

Expected Behavior

Candidate window / composition UI should be visible near the caret position, allowing normal candidate selection.

Actual Behavior

Candidate window / composition UI is not visible.
However, conversion still happens internally (confirming commits some candidate), so selection becomes “blind”.

Originally created by @hirsaeki on GitHub (Jan 8, 2026). ### Windows Terminal version 1.24.251216004 ### Windows build number 26200.7462 ### Other Software **CorvusSKK:** `3.3.1` ### Steps to reproduce 1. Install Windows Terminal **Preview** `1.24.251216004-preview`. 2. Ensure **CorvusSKK 3.3.1** is installed and set as the current IME. 3. Launch Windows Terminal Preview (non-elevated; not running as Administrator). 4. Open a tab (e.g., PowerShell). 5. Switch to Japanese input with CorvusSKK. 6. Type a reading (e.g., `nihongo`). 7. Trigger conversion / candidate selection (e.g., Space / usual CorvusSKK conversion action). ### Expected Behavior Candidate window / composition UI should be visible near the caret position, allowing normal candidate selection. ### Actual Behavior Candidate window / composition UI is **not visible**. However, conversion still happens internally (confirming commits some candidate), so selection becomes “blind”.
claunia added the Needs-TriageIssue-Bug labels 2026-01-31 08:56:58 +00:00
claunia commented 2026-01-31 08:56:59 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jan 12, 2026):

This seems awfully similar to #19670. Curiously, Sogou IME doesn't work on 1.23 and works on 1.24, while your IME doesn't work on 1.24 either.

Here are all relevant changes between the last v1.23.* Preview version and the newest v1.24.* Preview version. I checked each one again whether they could've caused this:

git log --oneline v1.23.12102.0..v1.24.3504.0 src/cascadia/WindowsTerminal/WindowEmperor.cpp src/tsf/Implementation.cpp
  • b277e4b51 Fix cursor being hidden when pressing modifier keys (#19473)
    ✅ This only ensures we call HideCursor less often.
  • 5c543bb2b Gracefully handle unavailable TSF from SYSTEM account (#19635)
    ✅ This only fixes a null-pointer crash.
  • 7e69a2e96 Fix a WPF<>TSF crash by avoiding TF_TMAE_CONSOLE (#19584)
    ❌ This is the most likely culprit, due to the introduction of TF_TMAE_UIELEMENTENABLEDONLY and TF_TMAE_NOACTIVATETIP.
  • b38489b67 Allow creating new windows on another virtual desktop (#19458)
    ✅ Unrelated to any IME code paths.
  • 671552671 Use the actual process image instead of module filename to dedup session (#19415)
    ✅ Unrelated to any IME code paths.
  • 6f5b293a5 Avoid reentrancy issues when dropping AppHost, even harder (#19395)
    ✅ Fixes a crash on exit.
  • 3a57ba54a Avoid reentrancy issues when dropping AppHost (#19296)
    ✅ Fixes a crash on exit.
  • fc465bdae Fix CoreWindow being destroyed after handoff (#19298)
    ✅ Fixes a crash on startup.
  • f2b30b4e1 Improve TSF color filtering logic (re: QQPinyin) (#19117)
    ✅ Fixes IME text rendering on our side.
  • 02f173d50 Include the hash of the SID in the Window Class and Mutant (#19109)
    ✅ Unrelated to any IME code paths.
  • ac07afebc Fix a crash during commandline handoff (#19096)
    ✅ Fixes a crash on startup.
  • a25d968fe Move ConPTY handoff logic into WindowEmperor (#19088)
    ❔ Big refactoring and may cause this issue if the WinUI creation is different now.
  • b47fdfc7e Fix support for the Tencent QQPinyin IME (#19046)
    ✅ Fixes IME text rendering on our side.
  • b50eaa19e Add branding and unpackaged metadata to a few telemetry events (#18926)
    ✅ Unrelated to any IME code paths.
  • 26cd15a14 Eagerly persist on WM_ENDSESSION (#18912)
    ✅ Fixes an issue on exit.
  • f769597d8 Persist window layout every few minutes (#18898)
    ✅ Unrelated to any IME code paths.
  • 69fc2d94e Clean up persisted windows after the feature is disabled (#18910)
    ✅ Fixes an issue on exit.
  • 96d1407c5 Fix bugs introduced in #18623 (#18635)
    ✅ Fixes an issue on exit.
  • e1be2f4c7 Fix persistence of the last closed window (#18623)
    ✅ Fixes an issue on exit.

In short, I believe it's #19584 due to TF_TMAE_UIELEMENTENABLEDONLY or TF_TMAE_NOACTIVATETIP. I can test that later. If it's indeed the culprit, I'd normally revert it immediately, but...

conhost used to use these flags for a decade and it still does if you enable the "Legacy Console" in its settings. Wouldn't that mean that it's actually a bug in Corvus SKK? If I check the CorvusSKK source code, I can see that it does use GUID_TFCAT_TIPCAP_UIELEMENTENABLED at least:
adc110ad83/imcrvtip/Register.cpp (L18)

@lhecker commented on GitHub (Jan 12, 2026): This seems awfully similar to #19670. Curiously, Sogou IME doesn't work on 1.23 and works on 1.24, while your IME doesn't work on 1.24 either. Here are all relevant changes between the last v1.23.* Preview version and the newest v1.24.* Preview version. I checked each one again whether they could've caused this: ```sh git log --oneline v1.23.12102.0..v1.24.3504.0 src/cascadia/WindowsTerminal/WindowEmperor.cpp src/tsf/Implementation.cpp ``` * b277e4b51 Fix cursor being hidden when pressing modifier keys ([#19473](https://github.com/microsoft/terminal/pull/19473)) ✅ This only ensures we call `HideCursor` less often. * 5c543bb2b Gracefully handle unavailable TSF from SYSTEM account ([#19635](https://github.com/microsoft/terminal/pull/19635)) ✅ This only fixes a null-pointer crash. * 7e69a2e96 Fix a WPF<>TSF crash by avoiding TF_TMAE_CONSOLE ([#19584](https://github.com/microsoft/terminal/pull/19584)) ❌ This is the most likely culprit, due to the introduction of `TF_TMAE_UIELEMENTENABLEDONLY` and `TF_TMAE_NOACTIVATETIP`. * b38489b67 Allow creating new windows on another virtual desktop ([#19458](https://github.com/microsoft/terminal/pull/19458)) ✅ Unrelated to any IME code paths. * 671552671 Use the actual process image instead of module filename to dedup session ([#19415](https://github.com/microsoft/terminal/pull/19415)) ✅ Unrelated to any IME code paths. * 6f5b293a5 Avoid reentrancy issues when dropping AppHost, even harder ([#19395](https://github.com/microsoft/terminal/pull/19395)) ✅ Fixes a crash on exit. * 3a57ba54a Avoid reentrancy issues when dropping AppHost ([#19296](https://github.com/microsoft/terminal/pull/19296)) ✅ Fixes a crash on exit. * fc465bdae Fix CoreWindow being destroyed after handoff ([#19298](https://github.com/microsoft/terminal/pull/19298)) ✅ Fixes a crash on startup. * f2b30b4e1 Improve TSF color filtering logic (re: QQPinyin) ([#19117](https://github.com/microsoft/terminal/pull/19117)) ✅ Fixes IME text rendering on our side. * 02f173d50 Include the hash of the SID in the Window Class and Mutant ([#19109](https://github.com/microsoft/terminal/pull/19109)) ✅ Unrelated to any IME code paths. * ac07afebc Fix a crash during commandline handoff ([#19096](https://github.com/microsoft/terminal/pull/19096)) ✅ Fixes a crash on startup. * a25d968fe Move ConPTY handoff logic into WindowEmperor ([#19088](https://github.com/microsoft/terminal/pull/19088)) ❔ Big refactoring and may cause this issue if the WinUI creation is different now. * b47fdfc7e Fix support for the Tencent QQPinyin IME ([#19046](https://github.com/microsoft/terminal/pull/19046)) ✅ Fixes IME text rendering on our side. * b50eaa19e Add branding and unpackaged metadata to a few telemetry events ([#18926](https://github.com/microsoft/terminal/pull/18926)) ✅ Unrelated to any IME code paths. * 26cd15a14 Eagerly persist on WM_ENDSESSION ([#18912](https://github.com/microsoft/terminal/pull/18912)) ✅ Fixes an issue on exit. * f769597d8 Persist window layout every few minutes ([#18898](https://github.com/microsoft/terminal/pull/18898)) ✅ Unrelated to any IME code paths. * 69fc2d94e Clean up persisted windows after the feature is disabled ([#18910](https://github.com/microsoft/terminal/pull/18910)) ✅ Fixes an issue on exit. * 96d1407c5 Fix bugs introduced in #18623 ([#18635](https://github.com/microsoft/terminal/pull/18635)) ✅ Fixes an issue on exit. * e1be2f4c7 Fix persistence of the last closed window ([#18623](https://github.com/microsoft/terminal/pull/18623)) ✅ Fixes an issue on exit. In short, I believe it's #19584 due to `TF_TMAE_UIELEMENTENABLEDONLY` or `TF_TMAE_NOACTIVATETIP`. I can test that later. If it's indeed the culprit, I'd normally revert it immediately, but... conhost used to use these flags for a decade and it still does if you enable the "Legacy Console" in its settings. Wouldn't that mean that it's actually a bug in Corvus SKK? If I check the CorvusSKK source code, I can see that it does use `GUID_TFCAT_TIPCAP_UIELEMENTENABLED` at least: https://github.com/nathancorvussolis/corvusskk/blob/adc110ad83ef8f2673c775989cbf64004b862b5d/imcrvtip/Register.cpp#L18
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#23946
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?