[PR #1] [MERGED] Use invariant culture for parsing double values #24030

Open
opened 2026-01-31 09:01:00 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1
Author: @MindGirl
Created: 8/12/2017
Status: Merged
Merged: 8/14/2017
Merged by: @khouzam

Base: masterHead: xmlschemaparser


📝 Commits (1)

  • a313826 Use invariant culture for parsing double values

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 tools/ColorTool/ColorTool/XmlSchemeParser.cs (+4 -3)

📄 Description

iTerm2 color schemes could not be parsed when using a non-english locale. This fixes the issue.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1 **Author:** [@MindGirl](https://github.com/MindGirl) **Created:** 8/12/2017 **Status:** ✅ Merged **Merged:** 8/14/2017 **Merged by:** [@khouzam](https://github.com/khouzam) **Base:** `master` ← **Head:** `xmlschemaparser` --- ### 📝 Commits (1) - [`a313826`](https://github.com/microsoft/terminal/commit/a313826830707b132a20718b16caba351bd3cbab) Use invariant culture for parsing double values ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `tools/ColorTool/ColorTool/XmlSchemeParser.cs` (+4 -3) </details> ### 📄 Description iTerm2 color schemes could not be parsed when using a non-english locale. This fixes the issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:01:00 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24030