starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #145] [CLOSED] Feature/powershell compatibility #24070

New Issue
Closed
opened 2026-01-31 09:01:15 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:01:15 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/145
Author: @theunrepentantgeek
Created: 4/1/2018
Status: ❌ Closed

Base: master ← Head: feature/powershell-compatibility

📝 Commits (2)

  • a9360de Add --powershell (-p) option for powershell compatibility
  • 168d560 Write a diagnostic if any unexpected argument is supplied

📊 Changes

2 files changed (+19 additions, -6 deletions)

View changed files

📝 tools/ColorTool/ColorTool/Program.cs (+12 -0)
📝 tools/ColorTool/ColorTool/Resources.resx (+7 -6)

📄 Description

The PowerShell console doesn't use the DARK_BLACK slot from the colour table for the console background; it uses the DARK_MAGENTA slot instead.

This PR adds options -p and --powershell to modify the colour table by copying the value from DARK_BLACK over DARK_MAGENTA so it works for PowerShell windows.

If this isn't done, the background of the PowerShell window has ... unexpected effects. Eg solarized_dark appears with a magenta background, and solarized_light appears with light blue.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/145 **Author:** [@theunrepentantgeek](https://github.com/theunrepentantgeek) **Created:** 4/1/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/powershell-compatibility` --- ### 📝 Commits (2) - [`a9360de`](https://github.com/microsoft/terminal/commit/a9360de3ea8561293d395ec9d70d5f9d64001c97) Add --powershell (-p) option for powershell compatibility - [`168d560`](https://github.com/microsoft/terminal/commit/168d560f605ab89c07b5552377d2a1929dbdff1a) Write a diagnostic if any unexpected argument is supplied ### 📊 Changes **2 files changed** (+19 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `tools/ColorTool/ColorTool/Program.cs` (+12 -0) 📝 `tools/ColorTool/ColorTool/Resources.resx` (+7 -6) </details> ### 📄 Description The PowerShell console doesn't use the DARK_BLACK slot from the colour table for the console background; it uses the DARK_MAGENTA slot instead. This PR adds options `-p` and `--powershell` to modify the colour table by copying the value from DARK_BLACK over DARK_MAGENTA so it works for PowerShell windows. If this isn't done, the background of the PowerShell window has ... *unexpected* effects. Eg `solarized_dark` appears with a magenta background, and `solarized_light` appears with light blue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:01:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24070
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?