starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #466] [MERGED] Add one half color schemes #24140

New Issue
Open
opened 2026-01-31 09:01:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:01:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/466
Author: @rkeithhill
Created: 5/7/2019
Status: ✅ Merged
Merged: 5/14/2019
Merged by: @miniksa

Base: master ← Head: add-one-half-color-schemes

📝 Commits (4)

  • c7c7dbb Add One Half Dark & Light color schemes
  • 7bd04ef WIP: Add One Half Dark/Lite schemes to settings
  • ee16cf7 Address PR feedback - use gsl::narrow()
  • dd628a3 Fix reversed OneHalfLight fg/bg colors

📊 Changes

1 file changed (+66 additions, -4 deletions)

View changed files

📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+66 -4)

📄 Description

This is close I think but what I see in the One Half Light theme as described here duplicates the dark colors for the light colors. On Windows w/colortool, I see that duplication for One Half Dark but not One Half Light. Should I emulate what colortool is using for the schemes? Also there are some "off-by-one" issues with the colortool scheme RGB values - at least as compared to the link above. Not sure which I should follow.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/466 **Author:** [@rkeithhill](https://github.com/rkeithhill) **Created:** 5/7/2019 **Status:** ✅ Merged **Merged:** 5/14/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `add-one-half-color-schemes` --- ### 📝 Commits (4) - [`c7c7dbb`](https://github.com/microsoft/terminal/commit/c7c7dbbdff8b38e89c68d142bb4562a989c88f8c) Add One Half Dark & Light color schemes - [`7bd04ef`](https://github.com/microsoft/terminal/commit/7bd04efcf8b4561ca75ed75e5985d21f0755328c) WIP: Add One Half Dark/Lite schemes to settings - [`ee16cf7`](https://github.com/microsoft/terminal/commit/ee16cf7a525ea0ef25a108f3b00ffba9dcf06e64) Address PR feedback - use gsl::narrow() - [`dd628a3`](https://github.com/microsoft/terminal/commit/dd628a330f159fbfa4a7623af004648fe6985556) Fix reversed OneHalfLight fg/bg colors ### 📊 Changes **1 file changed** (+66 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+66 -4) </details> ### 📄 Description This is close I think but what I see in the One Half Light theme as described [here](https://packagecontrol.io/packages/One%20Half%20Color%20Schemes) duplicates the dark colors for the light colors. On Windows w/colortool, I see that duplication for One Half Dark but not One Half Light. Should I emulate what colortool is using for the schemes? Also there are some "off-by-one" issues with the colortool scheme RGB values - at least as compared to the link above. Not sure which I should follow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:01:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?