starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #553] [MERGED] static analysis fixes #24173

New Issue
Open
opened 2026-01-31 09:01:49 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:01:49 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/553
Author: @ebudai
Created: 5/8/2019
Status: ✅ Merged
Merged: 5/23/2019
Merged by: @DHowett-MSFT

Base: master ← Head: master

📝 Commits (10+)

  • f0e0587 static analysis fixes
  • a4c1e4f fixes from review
  • 5f69489 missed one fix
  • 6595055 missed another one
  • 512ed19 using C++ style casts
  • fd4da54 explicit delete changed to reset(nullptr)
  • 57e5298 fix for null apiMsg.OtherId during tracing in Compare()
  • 208388d changed INVALID_ID macro to constexpr
  • 49bc63e properly handle null ReplyMsg in ConsoleIoThread()
  • c83c9d7 missed changing tabs to spaces

📊 Changes

15 files changed (+125 additions, -125 deletions)

View changed files

📝 src/buffer/out/OutputCell.hpp (+1 -1)
📝 src/host/ft_uia/KeyPressTests.cs (+1 -1)
📝 src/host/screenInfo.cpp (+2 -2)
📝 src/host/srvinit.cpp (+1 -1)
📝 src/host/utf8ToWideCharParser.cpp (+5 -2)
📝 src/interactivity/win32/UiaTextRange.cpp (+3 -3)
📝 src/interactivity/win32/UiaTextRange.hpp (+2 -1)
📝 src/interactivity/win32/window.cpp (+99 -103)
📝 src/propsheet/fontdlg.cpp (+1 -1)
📝 src/propslib/RegistrySerialization.cpp (+1 -1)
📝 src/renderer/base/thread.cpp (+2 -2)
📝 src/renderer/vt/tracing.cpp (+1 -1)
📝 src/server/ApiMessage.cpp (+2 -2)
📝 src/server/DeviceComm.cpp (+3 -3)
📝 src/server/DeviceComm.h (+1 -1)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/553 **Author:** [@ebudai](https://github.com/ebudai) **Created:** 5/8/2019 **Status:** ✅ Merged **Merged:** 5/23/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`f0e0587`](https://github.com/microsoft/terminal/commit/f0e05877e905a818e89f9911a6f4bac915bcb16e) static analysis fixes - [`a4c1e4f`](https://github.com/microsoft/terminal/commit/a4c1e4f105de53c6651749431ddee8aa17cb1980) fixes from review - [`5f69489`](https://github.com/microsoft/terminal/commit/5f694891cbc4ad8aab6b3d60541f7fdc9d8a2fe7) missed one fix - [`6595055`](https://github.com/microsoft/terminal/commit/65950553fee0fef6c870ed27ab984f9216808249) missed another one - [`512ed19`](https://github.com/microsoft/terminal/commit/512ed19fb1c58928e640f690dfd25ad02b6287f0) using C++ style casts - [`fd4da54`](https://github.com/microsoft/terminal/commit/fd4da54dfaf31c3fda6b2f2e0caaccc04a4498a5) explicit delete changed to reset(nullptr) - [`57e5298`](https://github.com/microsoft/terminal/commit/57e5298580ecb83aee5602407cf612dbb436b804) fix for null apiMsg.OtherId during tracing in Compare() - [`208388d`](https://github.com/microsoft/terminal/commit/208388ddd58aea03383b4909b000c6fb36b6ccfc) changed INVALID_ID macro to constexpr - [`49bc63e`](https://github.com/microsoft/terminal/commit/49bc63e411375466b3731cec10f54b5848db77d8) properly handle null ReplyMsg in ConsoleIoThread() - [`c83c9d7`](https://github.com/microsoft/terminal/commit/c83c9d7270dd886c160669b64f8a5583e2aec1cd) missed changing tabs to spaces ### 📊 Changes **15 files changed** (+125 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/OutputCell.hpp` (+1 -1) 📝 `src/host/ft_uia/KeyPressTests.cs` (+1 -1) 📝 `src/host/screenInfo.cpp` (+2 -2) 📝 `src/host/srvinit.cpp` (+1 -1) 📝 `src/host/utf8ToWideCharParser.cpp` (+5 -2) 📝 `src/interactivity/win32/UiaTextRange.cpp` (+3 -3) 📝 `src/interactivity/win32/UiaTextRange.hpp` (+2 -1) 📝 `src/interactivity/win32/window.cpp` (+99 -103) 📝 `src/propsheet/fontdlg.cpp` (+1 -1) 📝 `src/propslib/RegistrySerialization.cpp` (+1 -1) 📝 `src/renderer/base/thread.cpp` (+2 -2) 📝 `src/renderer/vt/tracing.cpp` (+1 -1) 📝 `src/server/ApiMessage.cpp` (+2 -2) 📝 `src/server/DeviceComm.cpp` (+3 -3) 📝 `src/server/DeviceComm.h` (+1 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:01:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24173
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?