starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #686] [MERGED] Blink the cursor #24246

New Issue
Open
opened 2026-01-31 09:02:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:11 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/686
Author: @dkter
Created: 5/10/2019
Status: ✅ Merged
Merged: 5/14/2019
Merged by: @DHowett-MSFT

Base: master ← Head: master

📝 Commits (7)

  • e735633 Blink cursor
  • 4f07561 Merge remote-tracking branch 'origin/master'
  • f4a60f2 Fix formatting
  • b51927d Re-organize cursor blinking code as per @zadjii-msft's request
  • c569dba Respect user's system cursor speed setting
  • ba3dbee Remove assignment of registrationtoken
  • ed93625 Fix spacing

📊 Changes

4 files changed (+80 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+63 -1)
📝 src/cascadia/TerminalControl/TermControl.h (+5 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+10 -0)
📝 src/cascadia/TerminalCore/Terminal.hpp (+2 -0)

📄 Description

Resolves #665. Behaviour was discussed a bit there:

  • When the window is not in focus, the cursor is not shown.
  • When the user is typing, the cursor is constantly shown.
  • Otherwise, the cursor blinks.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/686 **Author:** [@dkter](https://github.com/dkter) **Created:** 5/10/2019 **Status:** ✅ Merged **Merged:** 5/14/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`e735633`](https://github.com/microsoft/terminal/commit/e735633e01dd7e74489bf87a82ba9c1aa6c4a471) Blink cursor - [`4f07561`](https://github.com/microsoft/terminal/commit/4f075613db9b2040a2448cec4f920d86634aabe1) Merge remote-tracking branch 'origin/master' - [`f4a60f2`](https://github.com/microsoft/terminal/commit/f4a60f273842c9b1a16f36c4d1b13d4793984cf7) Fix formatting - [`b51927d`](https://github.com/microsoft/terminal/commit/b51927d165405baa32c8b27ec869701b3ae68696) Re-organize cursor blinking code as per @zadjii-msft's request - [`c569dba`](https://github.com/microsoft/terminal/commit/c569dba5d2ef671dba0ccf0bb98811c04ef10c38) Respect user's system cursor speed setting - [`ba3dbee`](https://github.com/microsoft/terminal/commit/ba3dbeeef3ccf82aba7e8063a2f34132b23b8ec0) Remove assignment of registrationtoken - [`ed93625`](https://github.com/microsoft/terminal/commit/ed936255cc294745edb9243471e4e04a1a5a524e) Fix spacing ### 📊 Changes **4 files changed** (+80 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+63 -1) 📝 `src/cascadia/TerminalControl/TermControl.h` (+5 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+10 -0) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+2 -0) </details> ### 📄 Description Resolves #665. Behaviour was discussed a bit there: - When the window is not in focus, the cursor is not shown. - When the user is typing, the cursor is constantly shown. - Otherwise, the cursor blinks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?