starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #690] [MERGED] Improvements to TerminalInput #24253

New Issue
Open
opened 2026-01-31 09:02:13 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:13 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/690
Author: @Nicholas-Baron
Created: 5/11/2019
Status: ✅ Merged
Merged: 5/30/2019
Merged by: @adiviness

Base: master ← Head: master

📝 Commits (10+)

  • bdb587d Specified the destructor of TerminalInput as default
  • 0dac0ea Simplified GetKeymappingLength
  • 34d62e5 Simplified GetKeyMapping
  • 8d9f26e Removed a redundant assignment
  • 9cdc19c Added auto deduction to some variables
  • ed084e6 Merged the public sections of TerminalInput
  • 3b590e2 Implied the destructor for TerminalInput
  • 075abc4 Removed GetKeyMappingLength and GetKeyMapping from public interface
  • 497463b Deleted or defaulted all six special member functions.
  • 6665feb Removed extraneous newlines

📊 Changes

2 files changed (+28 additions, -28 deletions)

View changed files

📝 src/terminal/input/terminalInput.cpp (+9 -24)
📝 src/terminal/input/terminalInput.hpp (+19 -4)

📄 Description

Modernization and light cleanup of TerminalInput.cpp and .hpp.

Addresses Issue #685

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/690 **Author:** [@Nicholas-Baron](https://github.com/Nicholas-Baron) **Created:** 5/11/2019 **Status:** ✅ Merged **Merged:** 5/30/2019 **Merged by:** [@adiviness](https://github.com/adiviness) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`bdb587d`](https://github.com/microsoft/terminal/commit/bdb587dc359481c97961b776703e67f11bd6b94a) Specified the destructor of TerminalInput as default - [`0dac0ea`](https://github.com/microsoft/terminal/commit/0dac0ea607f80af1cfd8049ff34348905bc4e787) Simplified GetKeymappingLength - [`34d62e5`](https://github.com/microsoft/terminal/commit/34d62e5a3553e2e676e1b2e2f826dbec507a5c9c) Simplified GetKeyMapping - [`8d9f26e`](https://github.com/microsoft/terminal/commit/8d9f26ed3ea87927766ac27cfa306df8ebe72a1f) Removed a redundant assignment - [`9cdc19c`](https://github.com/microsoft/terminal/commit/9cdc19c5155148372f7730989b2d62b0e3742616) Added auto deduction to some variables - [`ed084e6`](https://github.com/microsoft/terminal/commit/ed084e6d8582072615d65c294e517219488a21f4) Merged the public sections of TerminalInput - [`3b590e2`](https://github.com/microsoft/terminal/commit/3b590e220645097c7dd9575279e7a932c461e05c) Implied the destructor for TerminalInput - [`075abc4`](https://github.com/microsoft/terminal/commit/075abc4d6ec542cdf5146bd7313344d3fc815bca) Removed GetKeyMappingLength and GetKeyMapping from public interface - [`497463b`](https://github.com/microsoft/terminal/commit/497463b365097566dda920caf623a62951c5c1d7) Deleted or defaulted all six special member functions. - [`6665feb`](https://github.com/microsoft/terminal/commit/6665febe214529216fe8526fd6c99bff610f14e0) Removed extraneous newlines ### 📊 Changes **2 files changed** (+28 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/terminal/input/terminalInput.cpp` (+9 -24) 📝 `src/terminal/input/terminalInput.hpp` (+19 -4) </details> ### 📄 Description Modernization and light cleanup of `TerminalInput.cpp` and `.hpp`. Addresses Issue #685 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24253
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?