starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-23 23:45:08 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #695] [CLOSED] Added code to include WSL distros in profiles. #24255

New Issue
Open
opened 2026-01-31 09:02:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:14 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/695
Author: @JBanks
Created: 5/11/2019
Status: ❌ Closed

Base: master ← Head: WSLProfiles

📝 Commits (10+)

  • de7a97b Added code to include WSL distros in profiles.
  • 4fbdf9f Updates recommended by BinaryCrusader
  • ad359c1 Merge pull request #1 from microsoft/master
  • 281d0ac Merge branch 'WSLProfiles' into master
  • ace3400 Revert changes
  • b4ed9bc Merge pull request #3 from microsoft/master
  • d887eef Merge pull request #4 from JBanks/master
  • 0b5a104 Updated to receive distributions from console output.
  • a49aa37 Updates from server
  • 74ace39 Removed buffer after figuring out how to implement a stream to pull data from the pipe. Plus a few changes requested by BenHillis

📊 Changes

2 files changed (+62 additions, -88 deletions)

View changed files

📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+61 -79)
📝 src/cascadia/TerminalApp/TerminalApp.vcxproj (+1 -9)

📄 Description

For #441

Differences from #679 :

  • Variable names are now more descriptive;
  • Excess test code has been removed;
  • Code has been reorganized to make it easier to read;
  • vcxproj has been updated to allow registry functions to be used.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/695 **Author:** [@JBanks](https://github.com/JBanks) **Created:** 5/11/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `WSLProfiles` --- ### 📝 Commits (10+) - [`de7a97b`](https://github.com/microsoft/terminal/commit/de7a97b2d1458fdecff73288d3bd6cc0c2ad9d66) Added code to include WSL distros in profiles. - [`4fbdf9f`](https://github.com/microsoft/terminal/commit/4fbdf9fd4b0bb9d61ea19ce0a94120c387924e43) Updates recommended by BinaryCrusader - [`ad359c1`](https://github.com/microsoft/terminal/commit/ad359c1eb7abc841720700c5904b20e92da04d3c) Merge pull request #1 from microsoft/master - [`281d0ac`](https://github.com/microsoft/terminal/commit/281d0ac56a4c535bbca513e0f0f2209fed1aa722) Merge branch 'WSLProfiles' into master - [`ace3400`](https://github.com/microsoft/terminal/commit/ace3400a4b0bda478052fc153407e11837ae6f36) Revert changes - [`b4ed9bc`](https://github.com/microsoft/terminal/commit/b4ed9bc0b2dba20641df60e6c8f9b3eab6318607) Merge pull request #3 from microsoft/master - [`d887eef`](https://github.com/microsoft/terminal/commit/d887eef4e5015813bd3cda22b3de9b9436dc40e0) Merge pull request #4 from JBanks/master - [`0b5a104`](https://github.com/microsoft/terminal/commit/0b5a1042e5763953904fa8f4876e0f18db22da4c) Updated to receive distributions from console output. - [`a49aa37`](https://github.com/microsoft/terminal/commit/a49aa375ecd5e50a1968d442c2653a3096d330ea) Updates from server - [`74ace39`](https://github.com/microsoft/terminal/commit/74ace393f2a8f7d485acbf1972e9521e972ab355) Removed buffer after figuring out how to implement a stream to pull data from the pipe. Plus a few changes requested by BenHillis ### 📊 Changes **2 files changed** (+62 additions, -88 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+61 -79) 📝 `src/cascadia/TerminalApp/TerminalApp.vcxproj` (+1 -9) </details> ### 📄 Description For #441 Differences from #679 : - Variable names are now more descriptive; - Excess test code has been removed; - Code has been reorganized to make it easier to read; - vcxproj has been updated to allow registry functions to be used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24255
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?