starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #719] [MERGED] Remove ATL dependencies (#676) #24263

New Issue
Open
opened 2026-01-31 09:02:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:17 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/719
Author: @ysc3839
Created: 5/12/2019
Status: ✅ Merged
Merged: 5/21/2019
Merged by: @DHowett-MSFT

Base: master ← Head: rm-atl-deps

📝 Commits (7)

  • 1d80fb7 Remove CComBSTR dependency.
  • 70e1ac2 Replace CStructureArray with std::vector.
  • 440c094 Remove CComPtr dependency.
  • cdbe69b Add try blocks.
  • f0ccc19 Remove CString dependency.
  • 4d40832 Add comments for string helper functions.
  • 3a8e0a7 Remove CComAllocator dependency.

📊 Changes

25 files changed (+487 additions, -711 deletions)

View changed files

📝 src/inc/LibraryIncludes.h (+1 -0)
📝 src/terminal/parser/ft_fuzzer/VTCommandFuzzer.cpp (+172 -175)
📝 src/terminal/parser/ft_fuzzer/VTCommandFuzzer.vcxproj (+2 -0)
📝 src/terminal/parser/ft_fuzzer/VTCommandFuzzer.vcxproj.filters (+6 -0)
📝 src/terminal/parser/ft_fuzzer/fuzzing_directed.h (+4 -2)
📝 src/terminal/parser/ft_fuzzer/fuzzing_logic.h (+8 -5)
➕ src/terminal/parser/ft_fuzzer/memallocator.h (+32 -0)
📝 src/terminal/parser/ft_fuzzer/stdafx.h (+4 -1)
➕ src/terminal/parser/ft_fuzzer/string_helper.h (+67 -0)
📝 src/tsf/ConsoleTSF.cpp (+25 -24)
📝 src/tsf/ConsoleTSF.h (+5 -5)
➖ src/tsf/StructureArray.h (+0 -230)
📝 src/tsf/TfCatUtil.cpp (+1 -4)
📝 src/tsf/TfCatUtil.h (+2 -2)
📝 src/tsf/TfConvArea.cpp (+4 -8)
📝 src/tsf/TfConvArea.h (+2 -2)
📝 src/tsf/TfCtxtComp.h (+0 -62)
📝 src/tsf/TfDispAttr.cpp (+26 -47)
📝 src/tsf/TfDispAttr.h (+3 -5)
📝 src/tsf/TfEditses.cpp (+106 -111)

...and 5 more files

📄 Description

Related discussion #676.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/719 **Author:** [@ysc3839](https://github.com/ysc3839) **Created:** 5/12/2019 **Status:** ✅ Merged **Merged:** 5/21/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `rm-atl-deps` --- ### 📝 Commits (7) - [`1d80fb7`](https://github.com/microsoft/terminal/commit/1d80fb717c92b8b59b6f9fef9015507e5131668e) Remove CComBSTR dependency. - [`70e1ac2`](https://github.com/microsoft/terminal/commit/70e1ac2d64014ab2564e06dd8e6fa12f97d1fdde) Replace CStructureArray with std::vector. - [`440c094`](https://github.com/microsoft/terminal/commit/440c09474f55efc898f0f38642e083f56fcfc84a) Remove CComPtr dependency. - [`cdbe69b`](https://github.com/microsoft/terminal/commit/cdbe69be136d82670748056496f409a24091f554) Add try blocks. - [`f0ccc19`](https://github.com/microsoft/terminal/commit/f0ccc19b5c92069acf51a23d0be0e6685cabb3d6) Remove CString dependency. - [`4d40832`](https://github.com/microsoft/terminal/commit/4d408328ecc72537dd8c5e1e9a41d611fd2a5532) Add comments for string helper functions. - [`3a8e0a7`](https://github.com/microsoft/terminal/commit/3a8e0a78ef1f6b918a64a5c7a7e2d8978a51005c) Remove CComAllocator dependency. ### 📊 Changes **25 files changed** (+487 additions, -711 deletions) <details> <summary>View changed files</summary> 📝 `src/inc/LibraryIncludes.h` (+1 -0) 📝 `src/terminal/parser/ft_fuzzer/VTCommandFuzzer.cpp` (+172 -175) 📝 `src/terminal/parser/ft_fuzzer/VTCommandFuzzer.vcxproj` (+2 -0) 📝 `src/terminal/parser/ft_fuzzer/VTCommandFuzzer.vcxproj.filters` (+6 -0) 📝 `src/terminal/parser/ft_fuzzer/fuzzing_directed.h` (+4 -2) 📝 `src/terminal/parser/ft_fuzzer/fuzzing_logic.h` (+8 -5) ➕ `src/terminal/parser/ft_fuzzer/memallocator.h` (+32 -0) 📝 `src/terminal/parser/ft_fuzzer/stdafx.h` (+4 -1) ➕ `src/terminal/parser/ft_fuzzer/string_helper.h` (+67 -0) 📝 `src/tsf/ConsoleTSF.cpp` (+25 -24) 📝 `src/tsf/ConsoleTSF.h` (+5 -5) ➖ `src/tsf/StructureArray.h` (+0 -230) 📝 `src/tsf/TfCatUtil.cpp` (+1 -4) 📝 `src/tsf/TfCatUtil.h` (+2 -2) 📝 `src/tsf/TfConvArea.cpp` (+4 -8) 📝 `src/tsf/TfConvArea.h` (+2 -2) 📝 `src/tsf/TfCtxtComp.h` (+0 -62) 📝 `src/tsf/TfDispAttr.cpp` (+26 -47) 📝 `src/tsf/TfDispAttr.h` (+3 -5) 📝 `src/tsf/TfEditses.cpp` (+106 -111) _...and 5 more files_ </details> ### 📄 Description Related discussion #676. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24263
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?