starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #713] [CLOSED] Use operator*() for known non-empty optionals #24264

New Issue
Open
opened 2026-01-31 09:02:18 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:18 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/713
Author: @fghzxm
Created: 5/12/2019
Status: ❌ Closed

Base: master ← Head: push/fix-optional

📝 Commits (2)

  • 850e622 Use operator*() for known non-empty optionals
  • 93dfd53 Catch one more instance of optional::value()

📊 Changes

12 files changed (+49 additions, -49 deletions)

View changed files

📝 src/buffer/out/UnicodeStorage.cpp (+1 -1)
📝 src/buffer/out/textBuffer.cpp (+1 -1)
📝 src/cascadia/TerminalApp/App.cpp (+1 -1)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+1 -1)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+1 -1)
📝 src/cascadia/TerminalApp/Profile.cpp (+12 -12)
📝 src/cascadia/TerminalControl/TermControl.cpp (+4 -4)
📝 src/host/alias.cpp (+14 -14)
📝 src/host/getset.cpp (+4 -4)
📝 src/host/history.cpp (+1 -1)
📝 src/host/ut_host/ApiRoutinesTests.cpp (+8 -8)
📝 src/inc/conpty-universal.h (+1 -1)

📄 Description

This commit changes uses of std::optional::value() to operator*() and
operator->() for optionals known to contain values.

optional::value() throws while operator*() and operator->() do not.
Using the latters should help generating more efficient code at no
maintainability cost.

Signed-off-by: Fred Miller fghzxm@outlook.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/713 **Author:** [@fghzxm](https://github.com/fghzxm) **Created:** 5/12/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `push/fix-optional` --- ### 📝 Commits (2) - [`850e622`](https://github.com/microsoft/terminal/commit/850e622c264d00e6660965fb22d5e54840adadc7) Use operator*() for known non-empty optionals - [`93dfd53`](https://github.com/microsoft/terminal/commit/93dfd531ced2c37dfe41fad33d3130ba3251f907) Catch one more instance of optional::value() ### 📊 Changes **12 files changed** (+49 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/UnicodeStorage.cpp` (+1 -1) 📝 `src/buffer/out/textBuffer.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/App.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+12 -12) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+4 -4) 📝 `src/host/alias.cpp` (+14 -14) 📝 `src/host/getset.cpp` (+4 -4) 📝 `src/host/history.cpp` (+1 -1) 📝 `src/host/ut_host/ApiRoutinesTests.cpp` (+8 -8) 📝 `src/inc/conpty-universal.h` (+1 -1) </details> ### 📄 Description This commit changes uses of std::optional::value() to operator*() and operator->() for optionals known to contain values. optional::value() throws while operator*() and operator->() do not. Using the latters should help generating more efficient code at no maintainability cost. Signed-off-by: Fred Miller <fghzxm@outlook.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24264
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?