starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #742] [MERGED] Amend Color array to typed values #24285

New Issue
Open
opened 2026-01-31 09:02:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:24 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/742
Author: @ObsidianPhoenix
Created: 5/13/2019
Status: ✅ Merged
Merged: 5/15/2019
Merged by: @miniksa

Base: master ← Head: refactor_theme_colorarray

📝 Commits (8)

  • 5e3c33b Amend Color array to typed values
  • f23e555 Re-add the original deserialization code.
  • 47e79d6 Re-added original deserialization
  • 8718bc1 Update comment spacing
  • f8a08b2 Replace tabs with spaces
  • 15d682f Fix Merge Conflict
  • 15db6d5 Replace array definition and update for loops.
  • 8ea77c8 swapped _table calls to use .at()

📊 Changes

1 file changed (+44 additions, -8 deletions)

View changed files

📝 src/cascadia/TerminalApp/ColorScheme.cpp (+44 -8)

📄 Description

microsoft/Terminal#711

Refactoring the terminal color array to a list of typed values to remove confusion as to what the values represent.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/742 **Author:** [@ObsidianPhoenix](https://github.com/ObsidianPhoenix) **Created:** 5/13/2019 **Status:** ✅ Merged **Merged:** 5/15/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `refactor_theme_colorarray` --- ### 📝 Commits (8) - [`5e3c33b`](https://github.com/microsoft/terminal/commit/5e3c33bf9a553ac5d28f12a8f8ac8f51bb7b2f8d) Amend Color array to typed values - [`f23e555`](https://github.com/microsoft/terminal/commit/f23e555f9417b41ab72f0400947ac8f74e3dccbf) Re-add the original deserialization code. - [`47e79d6`](https://github.com/microsoft/terminal/commit/47e79d60a54c62c97ae6b714596498af1ccae9af) Re-added original deserialization - [`8718bc1`](https://github.com/microsoft/terminal/commit/8718bc17a03723d7f04625e23aa9b3e2f0bbf635) Update comment spacing - [`f8a08b2`](https://github.com/microsoft/terminal/commit/f8a08b284af01d49496da0f9a2b701c5766bfc80) Replace tabs with spaces - [`15d682f`](https://github.com/microsoft/terminal/commit/15d682fc1f8ae6ae15650749f1e15d8eb1750435) Fix Merge Conflict - [`15db6d5`](https://github.com/microsoft/terminal/commit/15db6d537a0c42cf8a428cca8ca2749cf65cda4e) Replace array definition and update for loops. - [`8ea77c8`](https://github.com/microsoft/terminal/commit/8ea77c88c467cf9b54919aa8ffc6f95dd03cf362) swapped _table calls to use .at() ### 📊 Changes **1 file changed** (+44 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/ColorScheme.cpp` (+44 -8) </details> ### 📄 Description microsoft/Terminal#711 Refactoring the terminal `color` array to a list of typed values to remove confusion as to what the values represent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?