starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #741] [MERGED] make copying of files windows localization agnostic #24286

New Issue
Open
opened 2026-01-31 09:02:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:24 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/741
Author: @hvoigt
Created: 5/13/2019
Status: ✅ Merged
Merged: 5/21/2019
Merged by: @undefined

Base: master ← Head: fix-copy-files

📝 Commits (3)

  • 9efc61b make copying of files windows localization agnostic
  • 92d3f90 start fixing commandline tools to run new windows terminal
  • 89fcb26 remove openterm command

📊 Changes

5 files changed (+11 additions, -73 deletions)

View changed files

📝 tools/echokey.cmd (+2 -2)
➖ tools/opencas.cmd (+0 -29)
📝 tools/opencon.cmd (+5 -5)
➖ tools/openterm.cmd (+0 -33)
📝 tools/openvt.cmd (+4 -4)

📄 Description

On a german Windows when building I get the following error:

(D = Datei, V = Verzeichnis)? Ist das Ziel ...\Terminal\x64\Debug\TerminalSettings.pdb ein Dateiname
oder ein Verzeichnisname
(D = Datei, V = Verzeichnis)? f

The trick with piping 'f' for folder into stdin does not work here, since in
german folder is called 'Verzeichnis'. Due to the fact that the UI is
translated a 'v' is expected.

Lets use plain 'copy' which does not have the problem of asking whether a
target is a folder, if the target does not exist.

NOTE: I discovered this because the xcopy in src/cppwinrt.build.post.props failed for x64. The other locations I just applied the same pattern and did not test, since I do not know the code base that thoroughly. But if one location works the others should be fine, right? ;) Please test if this also works for others.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/741 **Author:** [@hvoigt](https://github.com/hvoigt) **Created:** 5/13/2019 **Status:** ✅ Merged **Merged:** 5/21/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `fix-copy-files` --- ### 📝 Commits (3) - [`9efc61b`](https://github.com/microsoft/terminal/commit/9efc61b1b96163931b95f01e162fc46cf3f2bb2a) make copying of files windows localization agnostic - [`92d3f90`](https://github.com/microsoft/terminal/commit/92d3f90caed6f8fc9b2f268655df7b8c316a9fd5) start fixing commandline tools to run new windows terminal - [`89fcb26`](https://github.com/microsoft/terminal/commit/89fcb26e50b186c6cd7ae199eebf19eb2dedd5a7) remove openterm command ### 📊 Changes **5 files changed** (+11 additions, -73 deletions) <details> <summary>View changed files</summary> 📝 `tools/echokey.cmd` (+2 -2) ➖ `tools/opencas.cmd` (+0 -29) 📝 `tools/opencon.cmd` (+5 -5) ➖ `tools/openterm.cmd` (+0 -33) 📝 `tools/openvt.cmd` (+4 -4) </details> ### 📄 Description On a german Windows when building I get the following error: (D = Datei, V = Verzeichnis)? Ist das Ziel ...\Terminal\x64\Debug\TerminalSettings.pdb ein Dateiname oder ein Verzeichnisname (D = Datei, V = Verzeichnis)? f The trick with piping 'f' for folder into stdin does not work here, since in german folder is called 'Verzeichnis'. Due to the fact that the UI is translated a 'v' is expected. Lets use plain 'copy' which does not have the problem of asking whether a target is a folder, if the target does not exist. **NOTE**: I discovered this because the xcopy in `src/cppwinrt.build.post.props` failed for x64. The other locations I just applied the same pattern and did not test, since I do not know the code base that thoroughly. But if one location works the others should be fine, right? ;) Please test if this also works for others. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24286
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?