starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #746] [MERGED] Changes to be able to quit the application via exit inside a CLI prompt. #24295

New Issue
Open
opened 2026-01-31 09:02:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:27 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/746
Author: @woachk
Created: 5/13/2019
Status: ✅ Merged
Merged: 5/15/2019
Merged by: @zadjii-msft

Base: master ← Head: exit-window

📝 Commits (6)

  • a72a95c Changes to be able to quit the application via exit inside a CLI prompt.
  • 84127e7 Remove superfluous change. (earlier, just passing through the _interopWindowHandle was planned for closing the app, and so changing its protection status was done and then not reverted properly which is the cause of the change.
  • f91df56 Some more changes.
  • d54b174 Merge branch 'master' of https://github.com/Microsoft/Terminal into exit-window
  • af3926f Last change hopefully
  • fd70de3 Last change hopefully...

📊 Changes

7 files changed (+31 additions, -6 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+4 -4)
📝 src/cascadia/TerminalApp/App.h (+1 -0)
📝 src/cascadia/TerminalApp/App.idl (+2 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+11 -0)
📝 src/cascadia/WindowsTerminal/AppHost.h (+1 -1)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+11 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+1 -1)

📄 Description

Apologies for the indentation issues that might be visible here.

#627

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/746 **Author:** [@woachk](https://github.com/woachk) **Created:** 5/13/2019 **Status:** ✅ Merged **Merged:** 5/15/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `exit-window` --- ### 📝 Commits (6) - [`a72a95c`](https://github.com/microsoft/terminal/commit/a72a95cef4744090116fedbd8f41c2251977eb38) Changes to be able to quit the application via exit inside a CLI prompt. - [`84127e7`](https://github.com/microsoft/terminal/commit/84127e7858059268f0e7c7da0721546b5f2be8e7) Remove superfluous change. (earlier, just passing through the _interopWindowHandle was planned for closing the app, and so changing its protection status was done and then not reverted properly which is the cause of the change. - [`f91df56`](https://github.com/microsoft/terminal/commit/f91df568b2512a0587373c8cde124ae3cc47a77d) Some more changes. - [`d54b174`](https://github.com/microsoft/terminal/commit/d54b17489f65c1a58743a7bb5d9421ba3fc65141) Merge branch 'master' of https://github.com/Microsoft/Terminal into exit-window - [`af3926f`](https://github.com/microsoft/terminal/commit/af3926fdd17ca0fc4bbf5f23760c8248bb8d398d) Last change hopefully - [`fd70de3`](https://github.com/microsoft/terminal/commit/fd70de3081583e233ef8fc44b1261968a5af88d7) Last change hopefully... ### 📊 Changes **7 files changed** (+31 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+4 -4) 📝 `src/cascadia/TerminalApp/App.h` (+1 -0) 📝 `src/cascadia/TerminalApp/App.idl` (+2 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+11 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.h` (+1 -1) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+11 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+1 -1) </details> ### 📄 Description Apologies for the indentation issues that might be visible here. #627 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?