[PR #785] [MERGED] Fixed a bug where terminal won't build when local user folder has spaces #24306

Open
opened 2026-01-31 09:02:31 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/785
Author: @gilmishal
Created: 5/14/2019
Status: Merged
Merged: 5/14/2019
Merged by: @adiviness

Base: masterHead: fix-quotes


📝 Commits (1)

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 src/cppwinrt.build.post.props (+6 -6)

📄 Description

Added quotes to the commands that caused issues on my machine - Managed to build it and deploy with no issues.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/785 **Author:** [@gilmishal](https://github.com/gilmishal) **Created:** 5/14/2019 **Status:** ✅ Merged **Merged:** 5/14/2019 **Merged by:** [@adiviness](https://github.com/adiviness) **Base:** `master` ← **Head:** `fix-quotes` --- ### 📝 Commits (1) - [`aebac50`](https://github.com/microsoft/terminal/commit/aebac506382848c7112717d19c7cf71b099ae4f7) added quotes to commands ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/cppwinrt.build.post.props` (+6 -6) </details> ### 📄 Description Added quotes to the commands that caused issues on my machine - Managed to build it and deploy with no issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:31 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24306