starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

x86 build is broken due to Microsoft.Toolkit.Win32.UI.XamlApplication #2432

New Issue
Closed
opened 2026-01-30 22:54:52 +00:00 by claunia · 9 comments
claunia commented 2026-01-30 22:54:52 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Jul 1, 2019).

For some reason, the auxiliary Xaml toolkit's winmd is not getting ingested by the AppxManifest generator. It complains with a warning that the winmd file has no Implementation, when it does in fact have one.

Looking at a binlog of the build, it definitely has an Implementation. It may be getting stripped off somewhere. Adding the package reference directly to the WAP packaging project doesn't help.

At build time, the toolkit package looks identical to Microsoft.UI.Xaml.

Originally created by @DHowett-MSFT on GitHub (Jul 1, 2019). For some reason, the auxiliary Xaml toolkit's winmd is _not_ getting ingested by the AppxManifest generator. It complains with a warning that the winmd file has no `Implementation`, when it does in fact have one. Looking at a binlog of the build, it definitely has an `Implementation`. It may be getting stripped off somewhere. Adding the package reference directly to the WAP packaging project doesn't help. At build time, the toolkit package looks identical to Microsoft.UI.Xaml.
claunia commented 2026-01-30 22:54:54 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 1, 2019):

/cc @ocalvo

Oscar, this will likely impact other consumers of the toolkit. The end result is that the inherited XamlApplication class can't be activated because it doesn't end up listed in the .appxmanifest.

@DHowett-MSFT commented on GitHub (Jul 1, 2019): /cc @ocalvo Oscar, this will likely impact other consumers of the toolkit. The end result is that the inherited `XamlApplication` class can't be activated because it doesn't end up listed in the `.appxmanifest`.
claunia commented 2026-01-30 22:54:54 +00:00
Author
Owner
Copy Link

@ocalvo commented on GitHub (Jul 3, 2019):

Looking....

@DHowett-MSFT how do I repro this?

@ocalvo commented on GitHub (Jul 3, 2019): Looking.... @DHowett-MSFT how do I repro this?
claunia commented 2026-01-30 22:54:54 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 5, 2019):

Implementation is being stripped by the <RemovePayloadDuplicates> task from Microsoft.Build.AppxPackage.dll. Why? No idea yet.

@DHowett-MSFT commented on GitHub (Jul 5, 2019): `Implementation` is being stripped by the `<RemovePayloadDuplicates>` task from `Microsoft.Build.AppxPackage.dll`. _Why? No idea yet._
claunia commented 2026-01-30 22:54:54 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 5, 2019):

@ocalvo, I've got it! Check this out.

In the toolkit package targets, on line 4, we are adding a <Reference> to the .winmd. This Reference has an <Implementation>.

On line 9, we are adding a <ReferenceCopyLocalPaths> with a wildcard that also includes the .winmd! This one is a standard file reference, so it has no <Implementation>.

The Appx Packaging task RemovePayloadDuplicates is receiving a list where ReferenceCopyLocalFiles comes before References, and the .winmd reference without the Implementation wins.

If we remove the wildcard reference, the warning goes away and the appx manifest is generated with the correct activatable class entry:

    <Extension Category="windows.activatableClass.inProcessServer">
      <InProcessServer>
        <Path>Microsoft.Toolkit.Win32.UI.XamlHost.dll</Path>
        <ActivatableClass ActivatableClassId="Microsoft.Toolkit.Win32.UI.XamlHost.XamlApplication" ThreadingModel="both" />
      </InProcessServer>
    </Extension>
@DHowett-MSFT commented on GitHub (Jul 5, 2019): @ocalvo, I've got it! Check this out. In the toolkit package `targets`, on [line 4](https://github.com/windows-toolkit/Microsoft.Toolkit.Win32/blob/e308cd3ecd834632253a11158e5609968ab18c1b/Microsoft.Toolkit.Win32.UI.XamlApplication.Package/native/Microsoft.Toolkit.Win32.UI.XamlApplication.targets#L4), we are adding a `<Reference>` to the `.winmd`. This Reference has an `<Implementation>`. On [line 9](https://github.com/windows-toolkit/Microsoft.Toolkit.Win32/blob/e308cd3ecd834632253a11158e5609968ab18c1b/Microsoft.Toolkit.Win32.UI.XamlApplication.Package/native/Microsoft.Toolkit.Win32.UI.XamlApplication.targets#L9), we are adding a `<ReferenceCopyLocalPaths>` with a wildcard that _also includes the `.winmd`_! This one is a standard file reference, so it has **no** `<Implementation>`. The Appx Packaging task `RemovePayloadDuplicates` is receiving a list where `ReferenceCopyLocalFiles` comes before `References`, and the `.winmd` reference _without_ the Implementation wins. If we remove the wildcard reference, the warning goes away and the appx manifest is generated with the correct activatable class entry: ```xml <Extension Category="windows.activatableClass.inProcessServer"> <InProcessServer> <Path>Microsoft.Toolkit.Win32.UI.XamlHost.dll</Path> <ActivatableClass ActivatableClassId="Microsoft.Toolkit.Win32.UI.XamlHost.XamlApplication" ThreadingModel="both" /> </InProcessServer> </Extension> ```
claunia commented 2026-01-30 22:54:54 +00:00
Author
Owner
Copy Link

@azchohfi commented on GitHub (Jul 8, 2019):

Version 6.0.0-preview6.3 was just pushed.

@azchohfi commented on GitHub (Jul 8, 2019): Version 6.0.0-preview6.3 was just pushed.
claunia commented 2026-01-30 22:54:55 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 13, 2019):

image

@DHowett-MSFT commented on GitHub (Jul 13, 2019): ![image](https://user-images.githubusercontent.com/14316954/61177036-527f9280-a580-11e9-855e-6deeef71dc48.png)
claunia commented 2026-01-30 22:54:55 +00:00
Author
Owner
Copy Link

@lindexi commented on GitHub (Jul 28, 2021):

Fail in 6.1.2

@lindexi commented on GitHub (Jul 28, 2021): Fail in 6.1.2
claunia commented 2026-01-30 22:54:55 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 28, 2021):

@lindexi I'm sorry what? This issue was tracking a very specific issue in the Terminal's build tooling two years ago. Could you provide more context?

@zadjii-msft commented on GitHub (Jul 28, 2021): @lindexi I'm sorry what? This issue was tracking a very specific issue in the Terminal's build tooling _two years ago_. Could you provide more context?
claunia commented 2026-01-30 22:54:55 +00:00
Author
Owner
Copy Link

@lindexi commented on GitHub (Jul 29, 2021):

@zadjii-msft Sorry, I do not have a Visual Studio with English version. This is my output windows message:

图片

Package.appxmanifest : error APPX0703: 清单引用了不属于负载的一部分的文件“Microsoft.Toolkit.Win32.UI.XamlHost.dll”

Could you try me demo code: 739665b601/LaykearduchuNachairgurharhear

Building the solution in Visual Studio.

@lindexi commented on GitHub (Jul 29, 2021): @zadjii-msft Sorry, I do not have a Visual Studio with English version. This is my output windows message: ![图片](https://user-images.githubusercontent.com/16054566/127414646-c30514d9-f738-4392-81e8-b0ad98185b45.png) > Package.appxmanifest : error APPX0703: 清单引用了不属于负载的一部分的文件“Microsoft.Toolkit.Win32.UI.XamlHost.dll” Could you try me demo code: https://github.com/lindexi/lindexi_gd/tree/739665b601d4af8a021fd30960278ed7cbe2b441/LaykearduchuNachairgurharhear Building the solution in Visual Studio.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Bug Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2432
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?