starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #829] [MERGED] Simplify DPI logic #24335

New Issue
Open
opened 2026-01-31 09:02:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:40 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/829
Author: @ocalvo
Created: 5/15/2019
Status: ✅ Merged
Merged: 5/20/2019
Merged by: @undefined

Base: master ← Head: master

📝 Commits (7)

📊 Changes

4 files changed (+68 additions, -114 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/BaseWindow.h (+42 -6)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+11 -93)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+0 -7)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+15 -8)

📄 Description

This change simplify the code that deals with sizing of the main xaml content.

Win32 API like SetWindowPos are always in physical coordinates (a.k.a screen coordinates)
while Xaml/UWP apis are always in logical coordinates (a.k.a client coordinates divided vi monitor DPI)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/829 **Author:** [@ocalvo](https://github.com/ocalvo) **Created:** 5/15/2019 **Status:** ✅ Merged **Merged:** 5/20/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`0a2d7cf`](https://github.com/microsoft/terminal/commit/0a2d7cfadcb941997c59c2d8c43223f4fbcd2c36) Simply DPI logic - [`3deb149`](https://github.com/microsoft/terminal/commit/3deb149d2732ec66751dcf083563a57119ee7835) Apply PR comments - [`e0c3676`](https://github.com/microsoft/terminal/commit/e0c36763cab31c2464a9e8250e86700921abce1d) Update src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp - [`dad0bd8`](https://github.com/microsoft/terminal/commit/dad0bd8a70d4a792b33627f603e85cdc65fe96ee) Add comments - [`8a6ca87`](https://github.com/microsoft/terminal/commit/8a6ca8753030c74e3a7944cd75ce82e1b2d5b467) Merge branch 'master' of https://github.com/ocalvo/terminal - [`039372e`](https://github.com/microsoft/terminal/commit/039372ec295a0d2f1188af831ceb6b7f4c3a8c7b) Update src/cascadia/WindowsTerminal/BaseWindow.h - [`342d16a`](https://github.com/microsoft/terminal/commit/342d16ae1fe2e0710de2d992e62112f026b4f05f) Apply PR feedback ### 📊 Changes **4 files changed** (+68 additions, -114 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/BaseWindow.h` (+42 -6) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+11 -93) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+0 -7) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+15 -8) </details> ### 📄 Description This change simplify the code that deals with sizing of the main xaml content. Win32 API like SetWindowPos are always in physical coordinates (a.k.a screen coordinates) while Xaml/UWP apis are always in logical coordinates (a.k.a client coordinates divided vi monitor DPI) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24335
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?