[PR #903] Add an error dialog when we fail to parse settings #24377

Open
opened 2026-01-31 09:02:53 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/903

State: closed
Merged: Yes


Summary of the Pull Request

Add an error dialog when we fail to parse settings.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Sneak peek:
image

  • If we fail to load the settings, we'll temporarily use the default settings. These defaults won't get written back to the profiles.json file, so people don't need to worry about blowing their settings away with a simple typo.
  • This includes a bit of a XAML hack to make the button appear correctly when the app's theme is opposite that of the system theme. ContentDialog does a weird thing where it takes its child and moves that to the popup and leaves itself in the tree. That causes things like ElementTheme inheritance to break. So instead, we're theming the CloseButton manually, to make sure it's always visible.
**Original Pull Request:** https://github.com/microsoft/terminal/pull/903 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Add an error dialog when we fail to parse settings. ## PR Checklist * [x] Closes #622 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tested manually. * [x] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments Sneak peek: ![image](https://user-images.githubusercontent.com/18356694/58040776-f3f7e400-7afb-11e9-804a-656defc238c1.png) * If we fail to load the settings, we'll temporarily use the default settings. These defaults won't get written back to the profiles.json file, so people don't need to worry about blowing their settings away with a simple typo. * This includes a bit of a XAML hack to make the button appear correctly when the app's theme is opposite that of the system theme. `ContentDialog` does a weird thing where it takes its child and moves that to the popup and leaves itself in the tree. That causes things like `ElementTheme` inheritance to break. So instead, we're theming the `CloseButton` manually, to make sure it's always visible.
claunia added the pull-request label 2026-01-31 09:02:53 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24377