starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #906] [MERGED] Bugfix: padding offsets selection #24385

New Issue
Open
opened 2026-01-31 09:02:57 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:02:57 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/906
Author: @carlos-zamora
Created: 5/20/2019
Status: ✅ Merged
Merged: 5/22/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/cazamor/bugfix-selection-padding

📝 Commits (4)

  • a18a3eb Bugfix: padding offsets selection
  • 05af56e Bugfix: padding offsets selection - PR changes
  • 8fe0884 Bugfix: padding offsets selection - PR changes 2
  • cd9ba53 Bugfix: padding offsets selection - update with FAIL_FAST_IF

📊 Changes

2 files changed (+32 additions, -14 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+31 -14)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)

📄 Description

Summary of the Pull Request

Padding used to offset selection.

References

PR Checklist

  • Closes Does not detect wsl distro (#660)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. (I am a core contributor)

Detailed Description of the Pull Request / Additional comments

Created _GetTerminalPosition() to encompass some of this logic and prevent this kind of stuff from happening again. Also, just nice to wrap everything up into a function call.

To the team: this was already somewhat reviewed back before we went on GitHub. So if you have a deja vu feeling, that's why.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/906 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 5/20/2019 **Status:** ✅ Merged **Merged:** 5/22/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/cazamor/bugfix-selection-padding` --- ### 📝 Commits (4) - [`a18a3eb`](https://github.com/microsoft/terminal/commit/a18a3ebb5583f0b946fc53e70d1d57aafbecbef3) Bugfix: padding offsets selection - [`05af56e`](https://github.com/microsoft/terminal/commit/05af56e921c3b23f2feb452c8a832d5d91c482cf) Bugfix: padding offsets selection - PR changes - [`8fe0884`](https://github.com/microsoft/terminal/commit/8fe088408e50cbc6d598af2a1d8fed52b4cd5ef7) Bugfix: padding offsets selection - PR changes 2 - [`cd9ba53`](https://github.com/microsoft/terminal/commit/cd9ba537a2cf39255098e9525de9c394871fb0a4) Bugfix: padding offsets selection - update with FAIL_FAST_IF ### 📊 Changes **2 files changed** (+32 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+31 -14) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Padding used to offset selection. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #660 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [x] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. (I am a core contributor) <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Created `_GetTerminalPosition()` to encompass some of this logic and prevent this kind of stuff from happening again. Also, just nice to wrap everything up into a function call. To the team: this was already somewhat reviewed back before we went on GitHub. So if you have a deja vu feeling, that's why. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:02:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24385
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?