[PR #905] Selection for wide glyphs #24386

Open
opened 2026-01-31 09:02:57 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/905

State: closed
Merged: Yes


Summary of the Pull Request

Fixes a bug/feature to select wide glyphs (#935 ). Short summary of it is that selecting emojis and other wide glyphs should encompass the entire glyph, not just half.

Also moved selection logic to new file for cleanliness.

I had to rebase from the ADO branch but it looks good. And tested :)

References

PR Checklist

  • Closes Alt+Numpad not working (#935)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Basically, selection has to be covered in two cases: expand left and expand right. Made 2 similar looking functions.

To the team: this was already somewhat reviewed back before we went on GitHub. So if you have a deja vu feeling, that's why.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/905 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Fixes a bug/feature to select wide glyphs (#935 ). Short summary of it is that selecting emojis and other wide glyphs should encompass the entire glyph, not just half. Also moved selection logic to new file for cleanliness. I had to rebase from the ADO branch but it looks good. And tested :) ## References ## PR Checklist * [x] Closes #935 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [x] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Basically, selection has to be covered in two cases: expand left and expand right. Made 2 similar looking functions. To the team: this was already somewhat reviewed back before we went on GitHub. So if you have a deja vu feeling, that's why.
claunia added the pull-request label 2026-01-31 09:02:57 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24386