starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #920] [MERGED] Update scroll bar with scroll #24393

New Issue
Open
opened 2026-01-31 09:03:01 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:01 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/920
Author: @Kapperchino
Created: 5/21/2019
Status: ✅ Merged
Merged: 5/23/2019
Merged by: @miniksa

Base: master ← Head: UpdateScrollBarWithScroll

📝 Commits (6)

📊 Changes

4 files changed (+17 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/Tab.cpp (+1 -1)
📝 src/cascadia/TerminalControl/TermControl.cpp (+14 -0)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.idl (+1 -0)

📄 Description

Summary of the Pull Request

Fixes the problem where the scrollbar doesn't update when scrolling with keyboard shortcuts

References

#821

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Manually tested
  • Doesn't require documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #821

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/920 **Author:** [@Kapperchino](https://github.com/Kapperchino) **Created:** 5/21/2019 **Status:** ✅ Merged **Merged:** 5/23/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `UpdateScrollBarWithScroll` --- ### 📝 Commits (6) - [`a9d7cb0`](https://github.com/microsoft/terminal/commit/a9d7cb0319c4432332be7359d3611b7e4b18a4cd) added another method to scroll with keyboard - [`1e4fbc4`](https://github.com/microsoft/terminal/commit/1e4fbc456f1c3677e481172d4d7dc433feaae53c) set lastscrolloffset to 0 - [`b3bbd94`](https://github.com/microsoft/terminal/commit/b3bbd943e099abeb2a1d7b466030049a5b8affb2) fixed unused variable - [`e9b311f`](https://github.com/microsoft/terminal/commit/e9b311fc6beffe126f5217d45041af3c6472dd37) renamed ViewPort to Viewport - [`da7a8a6`](https://github.com/microsoft/terminal/commit/da7a8a6081636edff0fd0806b8c44a3acef5342b) Merge branch 'master' of https://github.com/microsoft/Terminal into UpdateScrollBarWithScroll - [`afe7d60`](https://github.com/microsoft/terminal/commit/afe7d60aad28f3bb64047c872e8d7849b393329a) changed keyBoard to keyboard in the functions, and added expliantion for function ### 📊 Changes **4 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Tab.cpp` (+1 -1) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+14 -0) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.idl` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Fixes the problem where the scrollbar doesn't update when scrolling with keyboard shortcuts ## References #821 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Manually tested * [x] Doesn't require documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #821 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:01 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24393
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?