starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #925] [MERGED] Use wstring_view for constants instead of wstring #24401

New Issue
Closed
opened 2026-01-31 09:03:06 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:06 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/925
Author: @mauve
Created: 5/21/2019
Status: ✅ Merged
Merged: 5/21/2019
Merged by: @adiviness

Base: master ← Head: master

📝 Commits (1)

  • cd5eac0 Use wstring_view for constants instead of wstring

📊 Changes

9 files changed (+81 additions, -81 deletions)

View changed files

📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+5 -5)
📝 src/cascadia/TerminalApp/ColorScheme.cpp (+4 -4)
📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+11 -11)
📝 src/cascadia/TerminalApp/GlobalAppSettings.h (+1 -1)
📝 src/cascadia/TerminalApp/Profile.cpp (+31 -31)
📝 src/cascadia/TerminalApp/Profile.h (+1 -1)
📝 src/host/ConsoleArguments.cpp (+13 -13)
📝 src/host/ConsoleArguments.hpp (+13 -13)
📝 src/host/ut_host/CodepointWidthDetectorTests.cpp (+2 -2)

📄 Description

Instead of creating const static wstring objects which call malloc in the constructor, use wstring_view instead which just wraps the constant.

Summary of the Pull Request

Simple code refactoring.

References

PR Checklist

  • Closes no bug
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/925 **Author:** [@mauve](https://github.com/mauve) **Created:** 5/21/2019 **Status:** ✅ Merged **Merged:** 5/21/2019 **Merged by:** [@adiviness](https://github.com/adiviness) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`cd5eac0`](https://github.com/microsoft/terminal/commit/cd5eac0ca26cbeee4c046484268eba19e8ce1de7) Use wstring_view for constants instead of wstring ### 📊 Changes **9 files changed** (+81 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+5 -5) 📝 `src/cascadia/TerminalApp/ColorScheme.cpp` (+4 -4) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+11 -11) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.h` (+1 -1) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+31 -31) 📝 `src/cascadia/TerminalApp/Profile.h` (+1 -1) 📝 `src/host/ConsoleArguments.cpp` (+13 -13) 📝 `src/host/ConsoleArguments.hpp` (+13 -13) 📝 `src/host/ut_host/CodepointWidthDetectorTests.cpp` (+2 -2) </details> ### 📄 Description Instead of creating const static wstring objects which call malloc in the constructor, use wstring_view instead which just wraps the constant. ## Summary of the Pull Request Simple code refactoring. ## References ## PR Checklist * [ ] Closes no bug * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?