starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #948] [MERGED] add audit mode to ci #24408

New Issue
Closed
opened 2026-01-31 09:03:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:09 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/948
Author: @adiviness
Created: 5/22/2019
Status: ✅ Merged
Merged: 5/24/2019
Merged by: @adiviness

Base: master ← Head: dev/austdi/staticAnalysis

📝 Commits (9)

  • b7a2f2a add audit mode to ci
  • 36c0278 ignore static analysis warnings in wil
  • 65050c5 exclude dep directory from static analysis
  • 8fdd3e1 audit mode won't run tests
  • f2907d0 fix build yaml
  • 4120c3a split job in two for audit mode
  • 00c6091 reference configuration correctly
  • 128c51e change quotes on strings
  • c55daa8 move audit mode steps to own job

📊 Changes

16 files changed (+92 additions, -28 deletions)

View changed files

📝 .gitignore (+0 -1)
📝 build/pipelines/ci.yml (+4 -0)
📝 build/pipelines/release.yml (+4 -0)
➕ build/pipelines/templates/build-console-audit-job.yml (+53 -0)
📝 build/pipelines/templates/build-console-ci.yml (+2 -2)
📝 build/pipelines/templates/build-console-int.yml (+2 -2)
📝 build/pipelines/templates/release-sign-and-bundle.yml (+9 -7)
📝 src/StaticAnalysis.ruleset (+7 -0)
📝 src/buffer/out/precomp.h (+0 -1)
📝 src/cascadia/TerminalApp/App.h (+0 -2)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+0 -2)
📝 src/cascadia/TerminalConnection/pch.h (+0 -1)
📝 src/common.build.post.props (+5 -0)
📝 src/common.build.pre.props (+2 -2)
📝 src/inc/LibraryIncludes.h (+4 -3)
📝 src/propsheet/precomp.h (+0 -5)

📄 Description

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Adds AuditMode to ci. AuditMode will perform static analysis across the entire project.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/948 **Author:** [@adiviness](https://github.com/adiviness) **Created:** 5/22/2019 **Status:** ✅ Merged **Merged:** 5/24/2019 **Merged by:** [@adiviness](https://github.com/adiviness) **Base:** `master` ← **Head:** `dev/austdi/staticAnalysis` --- ### 📝 Commits (9) - [`b7a2f2a`](https://github.com/microsoft/terminal/commit/b7a2f2a3a1af0be9218052f10346e9b702ff5fa0) add audit mode to ci - [`36c0278`](https://github.com/microsoft/terminal/commit/36c0278a927cb12e489da712038846764b9018a7) ignore static analysis warnings in wil - [`65050c5`](https://github.com/microsoft/terminal/commit/65050c59dc4d58489dcbc3f89c1815b6eb35cf85) exclude dep directory from static analysis - [`8fdd3e1`](https://github.com/microsoft/terminal/commit/8fdd3e1b78d8584fa5001cc35ce5505c0376aab0) audit mode won't run tests - [`f2907d0`](https://github.com/microsoft/terminal/commit/f2907d0f0c86b86eb5995150354d835203c309cf) fix build yaml - [`4120c3a`](https://github.com/microsoft/terminal/commit/4120c3a1e88d2928804228a9cb62d5154a70db16) split job in two for audit mode - [`00c6091`](https://github.com/microsoft/terminal/commit/00c609125d00ae7b54c964e552418a42782a7cc1) reference configuration correctly - [`128c51e`](https://github.com/microsoft/terminal/commit/128c51e5b52a84156197da60f4aae247c3354881) change quotes on strings - [`c55daa8`](https://github.com/microsoft/terminal/commit/c55daa8d9f236bad511a9f18c17b472d78d6373c) move audit mode steps to own job ### 📊 Changes **16 files changed** (+92 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+0 -1) 📝 `build/pipelines/ci.yml` (+4 -0) 📝 `build/pipelines/release.yml` (+4 -0) ➕ `build/pipelines/templates/build-console-audit-job.yml` (+53 -0) 📝 `build/pipelines/templates/build-console-ci.yml` (+2 -2) 📝 `build/pipelines/templates/build-console-int.yml` (+2 -2) 📝 `build/pipelines/templates/release-sign-and-bundle.yml` (+9 -7) 📝 `src/StaticAnalysis.ruleset` (+7 -0) 📝 `src/buffer/out/precomp.h` (+0 -1) 📝 `src/cascadia/TerminalApp/App.h` (+0 -2) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+0 -2) 📝 `src/cascadia/TerminalConnection/pch.h` (+0 -1) 📝 `src/common.build.post.props` (+5 -0) 📝 `src/common.build.pre.props` (+2 -2) 📝 `src/inc/LibraryIncludes.h` (+4 -3) 📝 `src/propsheet/precomp.h` (+0 -5) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #773 * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #773 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Adds AuditMode to ci. AuditMode will perform static analysis across the entire project. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24408
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?