starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #934] [MERGED] Add default icons for the default profiles #24410

New Issue
Open
opened 2026-01-31 09:03:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:09 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/934
Author: @DHowett-MSFT
Created: 5/22/2019
Status: ✅ Merged
Merged: 5/22/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/deficons

📝 Commits (5)

  • e150f27 Add default icons for a few of the default profiles
  • 236f672 unconstref the stringviews
  • d4ca9c1 I can only do this one file at a time, part 1/2
  • ad03112 I can only do this one file at a time, part 2/2
  • 3c2638b Apply suggestions from code review

📊 Changes

13 files changed (+38 additions, -14 deletions)

View changed files

📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+8 -0)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{0caa0dad-35be-5f56-a8ff-afceeeaa6101}.scale-100.png (+0 -0)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{0caa0dad-35be-5f56-a8ff-afceeeaa6101}.scale-200.png (+0 -0)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{574e775e-4f2a-5b96-ac1e-a2962a402336}.scale-100.png (+0 -0)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{574e775e-4f2a-5b96-ac1e-a2962a402336}.scale-200.png (+0 -0)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{61c54bbd-c2c6-5271-96e7-009a87ff44bf}.scale-100.png (+0 -0)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{61c54bbd-c2c6-5271-96e7-009a87ff44bf}.scale-200.png (+0 -0)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.scale-100.png (+0 -0)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.scale-200.png (+0 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+19 -13)
📝 src/cascadia/TerminalApp/CascadiaSettings.h (+1 -1)
📝 src/cascadia/TerminalApp/Profile.cpp (+9 -0)
📝 src/cascadia/TerminalApp/Profile.h (+1 -0)

📄 Description

This pull request introduces a handful of default icons whose paths will be
emitted into the default profiles.

Icons are named after the profile GUIDs, which for the default profiles
are stable v5 UUIDs based on the name of the profile. The plan is that
we'll never have a duplicate default profile, and if the user wants to
duplicate it they'll need to issue it a new GUID. Icons will by default
be unique for each profile (when the user saves their settings), but they
can of course be shared. It's just a file path.

Eventually, when icons can be inserted through the settings UI, we can
keep the GUID name (to unique them among all icons for all profiles) and
move them into ms-appdata:///roaming/.

The currently included icons are named for the following profiles:

"cmd" {0caa0dad-35be-5f56-a8ff-afceeeaa6101}
"PowerShell Core" {574e775e-4f2a-5b96-ac1e-a2962a402336}
"Windows PowerShell" {61c54bbd-c2c6-5271-96e7-009a87ff44bf}
"WSL" {9acb9455-ca41-5af7-950f-6bca1bc9722f}

The PowerShell profile names aren't being used yet, but this is in
preparation for #918 merging.

Fixes #933.

PR Checklist

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/934 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 5/22/2019 **Status:** ✅ Merged **Merged:** 5/22/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/deficons` --- ### 📝 Commits (5) - [`e150f27`](https://github.com/microsoft/terminal/commit/e150f279a81c50b2ba9a314e00405bb6d77756cf) Add default icons for a few of the default profiles - [`236f672`](https://github.com/microsoft/terminal/commit/236f6727ab8862cc9a663547855c5d8d12dd36ad) unconstref the stringviews - [`d4ca9c1`](https://github.com/microsoft/terminal/commit/d4ca9c197eee384678fe3882ebdaf9d5eeaa8f31) I can only do this one file at a time, part 1/2 - [`ad03112`](https://github.com/microsoft/terminal/commit/ad031125e719ecf729b9f1c54056d5880c4e9bff) I can only do this one file at a time, part 2/2 - [`3c2638b`](https://github.com/microsoft/terminal/commit/3c2638bb9f71034bf6588cc4b2c6410cda7e9453) Apply suggestions from code review ### 📊 Changes **13 files changed** (+38 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+8 -0) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{0caa0dad-35be-5f56-a8ff-afceeeaa6101}.scale-100.png` (+0 -0) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{0caa0dad-35be-5f56-a8ff-afceeeaa6101}.scale-200.png` (+0 -0) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{574e775e-4f2a-5b96-ac1e-a2962a402336}.scale-100.png` (+0 -0) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{574e775e-4f2a-5b96-ac1e-a2962a402336}.scale-200.png` (+0 -0) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{61c54bbd-c2c6-5271-96e7-009a87ff44bf}.scale-100.png` (+0 -0) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{61c54bbd-c2c6-5271-96e7-009a87ff44bf}.scale-200.png` (+0 -0) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.scale-100.png` (+0 -0) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.scale-200.png` (+0 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+19 -13) 📝 `src/cascadia/TerminalApp/CascadiaSettings.h` (+1 -1) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+9 -0) 📝 `src/cascadia/TerminalApp/Profile.h` (+1 -0) </details> ### 📄 Description This pull request introduces a handful of default icons whose paths will be emitted into the default profiles. Icons are named after the profile GUIDs, which for the default profiles are stable v5 UUIDs based on the name of the profile. The plan is that we'll never have a duplicate default profile, and if the user wants to duplicate it they'll need to issue it a new GUID. Icons will _by default_ be unique for each profile (when the user saves their settings), but they can of course be shared. It's just a file path. Eventually, when icons can be inserted through the settings UI, we can keep the GUID name (to unique them among all icons for all profiles) and move them into ms-appdata:///roaming/. The currently included icons are named for the following profiles: "cmd" `{0caa0dad-35be-5f56-a8ff-afceeeaa6101}` "PowerShell Core" `{574e775e-4f2a-5b96-ac1e-a2962a402336}` "Windows PowerShell" `{61c54bbd-c2c6-5271-96e7-009a87ff44bf}` "WSL" `{9acb9455-ca41-5af7-950f-6bca1bc9722f}` The PowerShell profile names aren't being used yet, but this is in preparation for #918 merging. Fixes #933. ## PR Checklist * [x] Closes #933 * [x] CLA signed * [x] Tests added/passed/not required * [x] Documentation updated/not required * [x] I've discussed this with core contributors already. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24410
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?