starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #955] [MERGED] Removed using namespace directive from header files #24419

New Issue
Open
opened 2026-01-31 09:03:13 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:13 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/955
Author: @MelulekiDube
Created: 5/23/2019
Status: ✅ Merged
Merged: 5/30/2019
Merged by: @adiviness

Base: master ← Head: master

📝 Commits (5)

  • f8a006d Removed using namespace directive from header files and put these in cpp files where they are used
  • c3dc1b2 Fixed tabbing issues by replacing them with spaces.
  • 7a9134e Merge branch 'master' into master
  • 3ed1c22 Update src/host/exemain.cpp
  • 2638209 Update src/interactivity/win32/find.cpp

📊 Changes

96 files changed (+303 additions, -182 deletions)

View changed files

📝 src/host/CommandListPopup.cpp (+1 -1)
📝 src/host/CursorBlinker.cpp (+2 -0)
📝 src/host/PtySignalInputThread.cpp (+1 -0)
📝 src/host/ScreenBufferRenderTarget.cpp (+2 -0)
📝 src/host/VtInputThread.cpp (+2 -1)
📝 src/host/VtInputThread.hpp (+1 -1)
📝 src/host/VtIo.cpp (+2 -0)
📝 src/host/_output.cpp (+1 -0)
📝 src/host/_stream.cpp (+2 -1)
📝 src/host/alias.cpp (+2 -0)
📝 src/host/cmdline.cpp (+1 -1)
📝 src/host/conareainfo.cpp (+1 -0)
📝 src/host/conimeinfo.cpp (+2 -0)
📝 src/host/consoleInformation.cpp (+3 -0)
📝 src/host/convarea.cpp (+1 -0)
📝 src/host/dbcs.cpp (+1 -0)
📝 src/host/directio.cpp (+1 -0)
📝 src/host/exemain.cpp (+1 -1)
📝 src/host/ft_host/API_AliasTests.cpp (+3 -0)
📝 src/host/ft_host/API_AliasTestsHelpers.hpp (+8 -7)

...and 76 more files

📄 Description

Summary of the Pull Request

Removes the using directives from the header files more specifically the following header files:

  • src/host/ft_host/precomp.h
  • src/host/globals.h
  • src/host/renderData.hpp
  • src/host/renderFontDefaults.hpp
  • src/host/screenInfo.hpp
  • src/host/selection.hpp

The using namespace directive was then put into the cpp files that needed them.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/955 **Author:** [@MelulekiDube](https://github.com/MelulekiDube) **Created:** 5/23/2019 **Status:** ✅ Merged **Merged:** 5/30/2019 **Merged by:** [@adiviness](https://github.com/adiviness) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`f8a006d`](https://github.com/microsoft/terminal/commit/f8a006dadcb8498ba6cffeb5e6da25a1d22dbb36) Removed using namespace directive from header files and put these in cpp files where they are used - [`c3dc1b2`](https://github.com/microsoft/terminal/commit/c3dc1b292193435e9333fcac700e68f2b352f15a) Fixed tabbing issues by replacing them with spaces. - [`7a9134e`](https://github.com/microsoft/terminal/commit/7a9134e9d96d996e9533ca0522812369ce3015da) Merge branch 'master' into master - [`3ed1c22`](https://github.com/microsoft/terminal/commit/3ed1c22ac5fbfa8e2a369d26b7f838d1c83c258c) Update src/host/exemain.cpp - [`2638209`](https://github.com/microsoft/terminal/commit/263820990af74a61780099a25d8bf5112cf50853) Update src/interactivity/win32/find.cpp ### 📊 Changes **96 files changed** (+303 additions, -182 deletions) <details> <summary>View changed files</summary> 📝 `src/host/CommandListPopup.cpp` (+1 -1) 📝 `src/host/CursorBlinker.cpp` (+2 -0) 📝 `src/host/PtySignalInputThread.cpp` (+1 -0) 📝 `src/host/ScreenBufferRenderTarget.cpp` (+2 -0) 📝 `src/host/VtInputThread.cpp` (+2 -1) 📝 `src/host/VtInputThread.hpp` (+1 -1) 📝 `src/host/VtIo.cpp` (+2 -0) 📝 `src/host/_output.cpp` (+1 -0) 📝 `src/host/_stream.cpp` (+2 -1) 📝 `src/host/alias.cpp` (+2 -0) 📝 `src/host/cmdline.cpp` (+1 -1) 📝 `src/host/conareainfo.cpp` (+1 -0) 📝 `src/host/conimeinfo.cpp` (+2 -0) 📝 `src/host/consoleInformation.cpp` (+3 -0) 📝 `src/host/convarea.cpp` (+1 -0) 📝 `src/host/dbcs.cpp` (+1 -0) 📝 `src/host/directio.cpp` (+1 -0) 📝 `src/host/exemain.cpp` (+1 -1) 📝 `src/host/ft_host/API_AliasTests.cpp` (+3 -0) 📝 `src/host/ft_host/API_AliasTestsHelpers.hpp` (+8 -7) _...and 76 more files_ </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Removes the using directives from the header files more specifically the following header files: - src/host/ft_host/precomp.h - src/host/globals.h - src/host/renderData.hpp - src/host/renderFontDefaults.hpp - src/host/screenInfo.hpp - src/host/selection.hpp The using namespace directive was then put into the cpp files that needed them. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #822 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] Issue number where discussion took place: #822 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24419
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?