starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1012] [MERGED] move version to vs2019, the 1903 sdk, and the 14.2 build tools. #24439

New Issue
Open
opened 2026-01-31 09:03:20 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:20 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1012
Author: @miniksa
Created: 5/24/2019
Status: ✅ Merged
Merged: 6/26/2019
Merged by: @miniksa

Base: master ← Head: miniksa-vs2019

📝 Commits (8)

  • 2afcc7d move version to vs2019, the 1903 sdk, and the 14.2 build tools.
  • 4ed600e Use the 2019 hosted pool.
  • c036247 Fix weird spacing behavior for stomp wap project block.
  • 62fdd44 yml: bump vs version to 16 as well
  • ded8b81 Switch audit to 16.0 as well
  • f1fc679 once more into the breach
  • fa26273 Merge branch 'master' into miniksa-vs2019
  • f79d01e check formatting build onto 2019 too.

📊 Changes

8 files changed (+157 additions, -171 deletions)

View changed files

📝 build/pipelines/templates/build-console-audit-job.yml (+2 -2)
📝 build/pipelines/templates/build-console-ci.yml (+1 -1)
📝 build/pipelines/templates/build-console-steps.yml (+1 -1)
📝 build/pipelines/templates/check-formatting.yml (+1 -1)
📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+12 -27)
📝 src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj (+134 -134)
📝 src/common.build.pre.props (+2 -2)
📝 src/cppwinrt.build.pre.props (+4 -3)

📄 Description

Summary of the Pull Request

Moves the solution to VS2019 and the latest SDK/tools

PR Checklist

Detailed Description of the Pull Request / Additional comments

This is sitting here until we figure out what to do with the build agents regarding versioning and signing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1012 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 5/24/2019 **Status:** ✅ Merged **Merged:** 6/26/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `miniksa-vs2019` --- ### 📝 Commits (8) - [`2afcc7d`](https://github.com/microsoft/terminal/commit/2afcc7dfa1cd3f6bfdf38b9c94e3b6bff07f3120) move version to vs2019, the 1903 sdk, and the 14.2 build tools. - [`4ed600e`](https://github.com/microsoft/terminal/commit/4ed600efd36158f40b1b90643cf42d20c36b494a) Use the 2019 hosted pool. - [`c036247`](https://github.com/microsoft/terminal/commit/c0362471927974ff6bbca19f4b2741fad99ce554) Fix weird spacing behavior for stomp wap project block. - [`62fdd44`](https://github.com/microsoft/terminal/commit/62fdd44f0b693915c183ffa651ea3b9dbc147f08) yml: bump vs version to 16 as well - [`ded8b81`](https://github.com/microsoft/terminal/commit/ded8b812f117feba82957e7a902a72129c26653b) Switch audit to 16.0 as well - [`f1fc679`](https://github.com/microsoft/terminal/commit/f1fc679074fa7afc6283101e1fef82ac786441f4) once more into the breach - [`fa26273`](https://github.com/microsoft/terminal/commit/fa26273120ced10b0c412a3452d7caa3a16102ba) Merge branch 'master' into miniksa-vs2019 - [`f79d01e`](https://github.com/microsoft/terminal/commit/f79d01ee7a9071694b5af74345c5d63f02d9e9a5) check formatting build onto 2019 too. ### 📊 Changes **8 files changed** (+157 additions, -171 deletions) <details> <summary>View changed files</summary> 📝 `build/pipelines/templates/build-console-audit-job.yml` (+2 -2) 📝 `build/pipelines/templates/build-console-ci.yml` (+1 -1) 📝 `build/pipelines/templates/build-console-steps.yml` (+1 -1) 📝 `build/pipelines/templates/check-formatting.yml` (+1 -1) 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+12 -27) 📝 `src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj` (+134 -134) 📝 `src/common.build.pre.props` (+2 -2) 📝 `src/cppwinrt.build.pre.props` (+4 -3) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Moves the solution to VS2019 and the latest SDK/tools <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #565 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [x] Does not require documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #565 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments This is sitting here until we figure out what to do with the build agents regarding versioning and signing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:20 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?