[PR #1048] [CLOSED] Dev/migrie/b/1042 refactor app to lib #24450

Open
opened 2026-01-31 09:03:23 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1048
Author: @administratort
Created: 5/29/2019
Status: Closed

Base: masterHead: dev/migrie/b/1042-refactor-app-to-lib


📝 Commits (10+)

  • d0121a1 start work on an error dialog
  • effefeb Continue work on an error dialog
  • 00a8da4 This unfortunately didn't work
  • 643a177 Merge remote-tracking branch 'origin/master' into dev/migrie/f/gh-error-dialog
  • b51d03f I'm just committing all of this, even though I really don't need most of it.
  • c1d17f6 Cleanup for PR
  • cb55215 Merge remote-tracking branch 'origin/master' into dev/migrie/f/gh-error-dialog
  • 809a180 Include jsoncpp in the solution
  • e8f5fb8 Merge branch 'master' into dev/migrie/f/gh-error-dialog
  • 5547ca5 PR feedback

📊 Changes

35 files changed (+9051 additions, -561 deletions)

View changed files

📝 OpenConsole.sln (+42 -0)
dep/jsoncpp/README.md (+7 -0)
dep/jsoncpp/json/json-forwards.h (+333 -0)
dep/jsoncpp/json/json.h (+2207 -0)
dep/jsoncpp/jsoncpp.cpp (+5386 -0)
📝 src/cascadia/TerminalApp/App.cpp (+2 -2)
📝 src/cascadia/TerminalApp/App.h (+0 -1)
📝 src/cascadia/TerminalApp/AppKeyBindings.cpp (+20 -210)
📝 src/cascadia/TerminalApp/AppKeyBindings.h (+3 -5)
📝 src/cascadia/TerminalApp/AppKeyBindings.idl (+0 -3)
src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+206 -0)
src/cascadia/TerminalApp/AppKeyBindingsSerialization.h (+12 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.h (+6 -6)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+96 -77)
📝 src/cascadia/TerminalApp/ColorScheme.cpp (+45 -55)
📝 src/cascadia/TerminalApp/ColorScheme.h (+2 -3)
📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+41 -46)
📝 src/cascadia/TerminalApp/GlobalAppSettings.h (+2 -2)
📝 src/cascadia/TerminalApp/Profile.cpp (+105 -145)
📝 src/cascadia/TerminalApp/Profile.h (+2 -2)

...and 15 more files

📄 Description

Summary of the Pull Request

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1048 **Author:** [@administratort](https://github.com/administratort) **Created:** 5/29/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev/migrie/b/1042-refactor-app-to-lib` --- ### 📝 Commits (10+) - [`d0121a1`](https://github.com/microsoft/terminal/commit/d0121a10f4b238db28df7c7d76ced8cf37accef8) start work on an error dialog - [`effefeb`](https://github.com/microsoft/terminal/commit/effefeb95918abfc5775fad46dbb183227a22bd9) Continue work on an error dialog - [`00a8da4`](https://github.com/microsoft/terminal/commit/00a8da4045769f057ea32e64c06fc837e9070496) This unfortunately didn't work - [`643a177`](https://github.com/microsoft/terminal/commit/643a17798ca3dab5c9d86a48b7032b4d38306e10) Merge remote-tracking branch 'origin/master' into dev/migrie/f/gh-error-dialog - [`b51d03f`](https://github.com/microsoft/terminal/commit/b51d03fa664d223db0ff76a23eba612324585977) I'm just committing all of this, even though I really don't need most of it. - [`c1d17f6`](https://github.com/microsoft/terminal/commit/c1d17f69103c9c022dcb32eb9097983f2501d068) Cleanup for PR - [`cb55215`](https://github.com/microsoft/terminal/commit/cb55215372987295e16e9bc0842bbe8a6c7c6bd3) Merge remote-tracking branch 'origin/master' into dev/migrie/f/gh-error-dialog - [`809a180`](https://github.com/microsoft/terminal/commit/809a180e7e9692b0f19cef4318b96cfe921e84de) Include jsoncpp in the solution - [`e8f5fb8`](https://github.com/microsoft/terminal/commit/e8f5fb8f97311a6ed56837a82099c9ebd81e1956) Merge branch 'master' into dev/migrie/f/gh-error-dialog - [`5547ca5`](https://github.com/microsoft/terminal/commit/5547ca56efeaa74b0b71176dd39cf408b53831a2) PR feedback ### 📊 Changes **35 files changed** (+9051 additions, -561 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+42 -0) ➕ `dep/jsoncpp/README.md` (+7 -0) ➕ `dep/jsoncpp/json/json-forwards.h` (+333 -0) ➕ `dep/jsoncpp/json/json.h` (+2207 -0) ➕ `dep/jsoncpp/jsoncpp.cpp` (+5386 -0) 📝 `src/cascadia/TerminalApp/App.cpp` (+2 -2) 📝 `src/cascadia/TerminalApp/App.h` (+0 -1) 📝 `src/cascadia/TerminalApp/AppKeyBindings.cpp` (+20 -210) 📝 `src/cascadia/TerminalApp/AppKeyBindings.h` (+3 -5) 📝 `src/cascadia/TerminalApp/AppKeyBindings.idl` (+0 -3) ➕ `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+206 -0) ➕ `src/cascadia/TerminalApp/AppKeyBindingsSerialization.h` (+12 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.h` (+6 -6) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+96 -77) 📝 `src/cascadia/TerminalApp/ColorScheme.cpp` (+45 -55) 📝 `src/cascadia/TerminalApp/ColorScheme.h` (+2 -3) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+41 -46) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.h` (+2 -2) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+105 -145) 📝 `src/cascadia/TerminalApp/Profile.h` (+2 -2) _...and 15 more files_ </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [x] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:23 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24450