starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1050] [MERGED] Code to add WSLProfiles. #24458

New Issue
Open
opened 2026-01-31 09:03:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:26 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1050
Author: @JBanks
Created: 5/29/2019
Status: ✅ Merged
Merged: 6/7/2019
Merged by: @zadjii-msft

Base: master ← Head: WSLProfiles

📝 Commits (10+)

  • 376ecff Code to add WSLProfiles.
  • f2c6ea6 Updates recomended by miniksa
  • 20c62a9 Corrections from Mauve
  • ab30297 More updates from miniska (clarified WaitForSingleObject errors, and moved the try block to the calling function)
  • a74edff Added THROW_LAST_ERROR for WAIT_FAILED instead of passing an unhandled exception.
  • e197555 Migrate STL dependancies to LibraryIncludes.h
  • 6af7f1f Renamed function to provide more clarity
  • 548c453 Set WSL starting directory.
  • 1664d11 Default Linux icon and brackets on new lines.
  • f61df86 Added system path so we don't rely on execution from the PATH environment variable. Removed incorrect error useage. Removed variable that was not required.

📊 Changes

3 files changed (+82 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+80 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.h (+1 -0)
📝 src/inc/LibraryIncludes.h (+1 -0)

📄 Description

Summary of the Pull Request

This code generates a list of WSL Distributions to be added to the drop down list. It was tested manually with a setup holding a single WSL distribution.

References

PR Checklist

  • Closes Get rid of CP/M reserved file names (#441)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #441

Detailed Description of the Pull Request / Additional comments

While implementing the stream I was getting stuck in a loop inside of the wfstream functions when I ran past the end of the output. None of the wfstream's health functions seemed to be working properly (::rdstate(), ::eof(), etc) so I used peeknamedpipe to get the length and stopped reading from the pipe before this became an issue. I'd like to find a more clean method

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1050 **Author:** [@JBanks](https://github.com/JBanks) **Created:** 5/29/2019 **Status:** ✅ Merged **Merged:** 6/7/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `WSLProfiles` --- ### 📝 Commits (10+) - [`376ecff`](https://github.com/microsoft/terminal/commit/376ecff8cb73724825323192509b231d9adbf76e) Code to add WSLProfiles. - [`f2c6ea6`](https://github.com/microsoft/terminal/commit/f2c6ea66b8c9908ca3e2e372db1f1374f01ad0c7) Updates recomended by miniksa - [`20c62a9`](https://github.com/microsoft/terminal/commit/20c62a9b04e50a08aab97522d242427c6dd9fb0b) Corrections from Mauve - [`ab30297`](https://github.com/microsoft/terminal/commit/ab3029715eebfc1cc3b2df9f6578204f4ee537eb) More updates from miniska (clarified WaitForSingleObject errors, and moved the try block to the calling function) - [`a74edff`](https://github.com/microsoft/terminal/commit/a74edffbbab676d43ace1193d163b34cf73984a4) Added THROW_LAST_ERROR for WAIT_FAILED instead of passing an unhandled exception. - [`e197555`](https://github.com/microsoft/terminal/commit/e1975559d26ceda6b5bb56621ce16a57f90284b2) Migrate STL dependancies to LibraryIncludes.h - [`6af7f1f`](https://github.com/microsoft/terminal/commit/6af7f1f05ea5c515f5b52d9f5b2e891c64257e05) Renamed function to provide more clarity - [`548c453`](https://github.com/microsoft/terminal/commit/548c453f1cfb957e877ac55cda6d22130801deda) Set WSL starting directory. - [`1664d11`](https://github.com/microsoft/terminal/commit/1664d11a4c25e8c95051ba2af053ead34b7252f5) Default Linux icon and brackets on new lines. - [`f61df86`](https://github.com/microsoft/terminal/commit/f61df869f0778771dfa7d928c002f1fe9e5aa3a7) Added system path so we don't rely on execution from the PATH environment variable. Removed incorrect error useage. Removed variable that was not required. ### 📊 Changes **3 files changed** (+82 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+80 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.h` (+1 -0) 📝 `src/inc/LibraryIncludes.h` (+1 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This code generates a list of WSL Distributions to be added to the drop down list. It was tested manually with a setup holding a single WSL distribution. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #441 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #441 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments While implementing the stream I was getting stuck in a loop inside of the `wfstream `functions when I ran past the end of the output. None of the `wfstream`'s health functions seemed to be working properly (`::rdstate()`, `::eof()`, etc) so I used `peeknamedpipe `to get the length and stopped reading from the pipe before this became an issue. I'd like to find a more clean method --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24458
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?