starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1057] [MERGED] Turn on Text Buffer unit tests in Azure DevOps CI build #24459

New Issue
Open
opened 2026-01-31 09:03:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:26 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1057
Author: @metathinker
Created: 5/30/2019
Status: ✅ Merged
Merged: 5/30/2019
Merged by: @DHowett-MSFT

Base: master ← Head: ci-buffer-tests

📝 Commits (2)

  • 7be352b rename TextBuffer.UnitTests.dll -> TextBuffer.Unit.Tests.dll
  • 5909e82 renamed the project file as well

📊 Changes

6 files changed (+10 additions, -6 deletions)

View changed files

📝 OpenConsole.sln (+1 -1)
📝 src/buffer/out/ut_textbuffer/TextBuffer.Unit.Tests.vcxproj (+2 -2)
📝 tools/runft.cmd (+1 -0)
📝 tools/runuia.cmd (+1 -0)
📝 tools/runut.cmd (+2 -1)
📝 tools/tests.xml (+3 -2)

📄 Description

This small PR renames the text buffer unit test binary file from TextBuffer.UnitTests.dll to TextBuffer.Unit.Tests.dll, with a dot between "Unit" and "Tests". As per the discussion for issue #854, this should be enough to get those tests running in CI.

Detailed Description of the Pull Request / Additional comments

Though it was not strictly necessary, I also renamed the Visual Studio project for TextBuffer.Unit.Tests.dll and its .vcxproj project file.

I also noticed that the 2 tools\ folder commands used to run tests were inconsistent with each other. That is, the PowerShell Invoke-OpenConsoleTests cmdlet was missing some tests run by the {runut,runft,runuia}.cmd batch files (though not the same tests that Azure CI was missing!). So I took the liberty of updating the cmdlet to run those missing tests.

I did not touch the files used in the Windows OS build and test system (the sources file and testmd.definition file). I didn't think this was necessary because the DLLs built by the sources and .vcxproj files are already inconsistent in filename, for this DLL as well as some other binaries built in this repo.

PR Checklist

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1057 **Author:** [@metathinker](https://github.com/metathinker) **Created:** 5/30/2019 **Status:** ✅ Merged **Merged:** 5/30/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `ci-buffer-tests` --- ### 📝 Commits (2) - [`7be352b`](https://github.com/microsoft/terminal/commit/7be352b3a4acb6fc6130f6064412c0da422895c6) rename TextBuffer.UnitTests.dll -> TextBuffer.Unit.Tests.dll - [`5909e82`](https://github.com/microsoft/terminal/commit/5909e824a9509c42b1d8a4e5deab5c7d8286888c) renamed the project file as well ### 📊 Changes **6 files changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+1 -1) 📝 `src/buffer/out/ut_textbuffer/TextBuffer.Unit.Tests.vcxproj` (+2 -2) 📝 `tools/runft.cmd` (+1 -0) 📝 `tools/runuia.cmd` (+1 -0) 📝 `tools/runut.cmd` (+2 -1) 📝 `tools/tests.xml` (+3 -2) </details> ### 📄 Description This small PR renames the text buffer unit test binary file from `TextBuffer.UnitTests.dll` to `TextBuffer.Unit.Tests.dll`, with a dot between "Unit" and "Tests". As per the discussion for issue #854, this should be enough to get those tests running in CI. ### Detailed Description of the Pull Request / Additional comments Though it was not _strictly_ necessary, I also renamed the Visual Studio project for `TextBuffer.Unit.Tests.dll` and its `.vcxproj` project file. I also noticed that the 2 tools\ folder commands used to run tests were inconsistent with each other. That is, the PowerShell `Invoke-OpenConsoleTests` cmdlet was missing some tests run by the `{runut,runft,runuia}.cmd` batch files (though not the same tests that Azure CI was missing!). So I took the liberty of updating the cmdlet to run those missing tests. I did not touch the files used in the Windows OS build and test system (the [`sources` file](https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/converting-a-wdk-sources-file-to-a-visual-studio-project) and `testmd.definition` file). I didn't think this was necessary because the DLLs built by the `sources` and `.vcxproj` files are already inconsistent in filename, for this DLL as well as some other binaries built in this repo. ### PR Checklist * [x] Closes #854 * [x] CLA signed - N/A; I work for Microsoft * [x] Tests added/passed - manually verified that the Buffer unit tests now run and pass in CI build: https://github.com/microsoft/terminal/pull/1057/checks?check_run_id=138408795 * [x] Requires documentation to be updated - N/A; no doc changes needed * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24459
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?