starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1148] [CLOSED] Dev/austdi/new cooked read #24499

New Issue
Open
opened 2026-01-31 09:03:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:39 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1148
Author: @ChristophePichaud
Created: 6/5/2019
Status: ❌ Closed

Base: dev/austdi/NewCookedRead ← Head: dev/austdi/NewCookedRead

📝 Commits (2)

  • ca50f77 CommandHistory becomes a std::shared_ptr. Minor changes.
  • 1fd8ee4 CommandHistory becomes a std::shared_ptr. Minor changes in code and unit tests.

📊 Changes

74 files changed (+1399 additions, -172 deletions)

View changed files

📝 src/buffer/out/lib/bufferout.vcxproj (+30 -0)
📝 src/buffer/out/ut_textbuffer/TextBuffer.Unittests.vcxproj (+30 -0)
📝 src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj (+29 -8)
📝 src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj (+30 -0)
📝 src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj (+20 -4)
📝 src/host/CommandListPopup.cpp (+28 -28)
📝 src/host/CommandListPopup.hpp (+2 -2)
📝 src/host/CommandNumberPopup.cpp (+1 -1)
📝 src/host/CopyToCharPopup.cpp (+1 -1)
📝 src/host/cmdline.cpp (+6 -6)
📝 src/host/cookedRead.cpp (+3 -3)
📝 src/host/cookedRead.hpp (+3 -3)
📝 src/host/exe/Host.EXE.vcxproj (+30 -0)
📝 src/host/ft_host/Host.FeatureTests.vcxproj (+30 -0)
📝 src/host/history.cpp (+33 -33)
📝 src/host/history.h (+4 -4)
📝 src/host/lib/hostlib.vcxproj (+28 -0)
📝 src/host/lib/hostlib.vcxproj.filters (+18 -12)
📝 src/host/readDataCooked.cpp (+1 -0)
📝 src/host/stream.cpp (+1 -1)

...and 54 more files

📄 Description

Summary of the Pull Request

CommandHistory becomes a std::shared_ptr. Minor changes in code and unit tests.
Some ctor has been modified.
There is not weak_ptr usage. Every times a shared_ptr is passed, its using the ref counter of the = operator. It prevents unexpected behaviour and hangs.

References

PR Checklist

  • Closes Fix AuditMode for BufferOut project (#1058)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
    No yet, I need to configure it.
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #1058
    It is under discussion.

Detailed Description of the Pull Request / Additional comments

Previous commit was a mistake, it involves the migration to vs2019 and platform toolset v142. Forget about that.
Just take the H/CPP modifications.

Validation Steps Performed

Manuel test of running tab and ask for cmd and type command, and ask for history...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1148 **Author:** [@ChristophePichaud](https://github.com/ChristophePichaud) **Created:** 6/5/2019 **Status:** ❌ Closed **Base:** `dev/austdi/NewCookedRead` ← **Head:** `dev/austdi/NewCookedRead` --- ### 📝 Commits (2) - [`ca50f77`](https://github.com/microsoft/terminal/commit/ca50f773a0b73d23648603a8117621a059648d37) CommandHistory becomes a std::shared_ptr<CommandHistory>. Minor changes. - [`1fd8ee4`](https://github.com/microsoft/terminal/commit/1fd8ee4cee1325f45ee247596cef56dc01730f6e) CommandHistory becomes a std::shared_ptr<CommandHistory>. Minor changes in code and unit tests. ### 📊 Changes **74 files changed** (+1399 additions, -172 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/lib/bufferout.vcxproj` (+30 -0) 📝 `src/buffer/out/ut_textbuffer/TextBuffer.Unittests.vcxproj` (+30 -0) 📝 `src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj` (+29 -8) 📝 `src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj` (+30 -0) 📝 `src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj` (+20 -4) 📝 `src/host/CommandListPopup.cpp` (+28 -28) 📝 `src/host/CommandListPopup.hpp` (+2 -2) 📝 `src/host/CommandNumberPopup.cpp` (+1 -1) 📝 `src/host/CopyToCharPopup.cpp` (+1 -1) 📝 `src/host/cmdline.cpp` (+6 -6) 📝 `src/host/cookedRead.cpp` (+3 -3) 📝 `src/host/cookedRead.hpp` (+3 -3) 📝 `src/host/exe/Host.EXE.vcxproj` (+30 -0) 📝 `src/host/ft_host/Host.FeatureTests.vcxproj` (+30 -0) 📝 `src/host/history.cpp` (+33 -33) 📝 `src/host/history.h` (+4 -4) 📝 `src/host/lib/hostlib.vcxproj` (+28 -0) 📝 `src/host/lib/hostlib.vcxproj.filters` (+18 -12) 📝 `src/host/readDataCooked.cpp` (+1 -0) 📝 `src/host/stream.cpp` (+1 -1) _...and 54 more files_ </details> ### 📄 Description ## Summary of the Pull Request CommandHistory becomes a std::shared_ptr<CommandHistory>. Minor changes in code and unit tests. Some ctor has been modified. There is not weak_ptr usage. Every times a shared_ptr is passed, its using the ref counter of the = operator. It prevents unexpected behaviour and hangs. ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Closes #1058 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed No yet, I need to configure it. * [ ] Requires documentation to be updated * [X] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #1058 It is under discussion. <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Previous commit was a mistake, it involves the migration to vs2019 and platform toolset v142. Forget about that. Just take the H/CPP modifications. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Manuel test of running tab and ask for cmd and type command, and ask for history... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24499
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?