starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1191] [MERGED] Support any number of leading zeros in VT parameter values #24520

New Issue
Open
opened 2026-01-31 09:03:47 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:47 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1191
Author: @j4james
Created: 6/9/2019
Status: ✅ Merged
Merged: 6/10/2019
Merged by: @zadjii-msft

Base: master ← Head: fix-leading-zeros

📝 Commits (2)

  • 688a635 Support any number of leading zeros in VT parameter values.
  • dd4f0ae Add unit tests for leading zeros in VT parameter values.

📊 Changes

2 files changed (+67 additions, -6 deletions)

View changed files

📝 src/terminal/parser/stateMachine.cpp (+14 -6)
📝 src/terminal/parser/ut_parser/OutputEngineTest.cpp (+53 -0)

📄 Description

Summary of the Pull Request

Adds support for any number of leading zeros in the parameter values of VT escape sequences. Tested manually, with Vttest, and with unit tests.

PR Checklist

  • Closes A question (not an issue) about ConPTY feature. (#358)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #358

Detailed Description of the Pull Request / Additional comments

In the StateMachine::_ActionParam and StateMachine::_ActionOscParam methods, the parser would treat any parameter number with more than 5 digits as being the maximum value. This PR add checks which prevent leading zeros from contributing to that count, so the 5 digit limit now only applies to significant digits.

Validation Steps Performed

  • I've tested in the WSL bash shell with escape sequences containing many leading zeros, e.g.:
    printf "\033[0000000032mGREEN?\033[m\n".
  • I've confirmed that the leading zeros test in Vttest now works (the last screen in the Test of cursor movements).
  • I've added a couple of unit tests in Microsoft::Console::VirtualTerminal::OutputEngineTest for both the CSI and OSC sequences.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1191 **Author:** [@j4james](https://github.com/j4james) **Created:** 6/9/2019 **Status:** ✅ Merged **Merged:** 6/10/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `fix-leading-zeros` --- ### 📝 Commits (2) - [`688a635`](https://github.com/microsoft/terminal/commit/688a635d1617578a2d368150b0a96be5c2a2fe3e) Support any number of leading zeros in VT parameter values. - [`dd4f0ae`](https://github.com/microsoft/terminal/commit/dd4f0ae1c0fa1113ac3d45881d947eff1438e9ae) Add unit tests for leading zeros in VT parameter values. ### 📊 Changes **2 files changed** (+67 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/terminal/parser/stateMachine.cpp` (+14 -6) 📝 `src/terminal/parser/ut_parser/OutputEngineTest.cpp` (+53 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds support for any number of leading zeros in the parameter values of VT escape sequences. Tested manually, with [Vttest](https://invisible-island.net/vttest/), and with unit tests. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #358 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #358 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments In the `StateMachine::_ActionParam` and `StateMachine::_ActionOscParam` methods, the parser would treat any parameter number with more than 5 digits as being the maximum value. This PR add checks which prevent leading zeros from contributing to that count, so the 5 digit limit now only applies to _significant_ digits. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed * I've tested in the WSL bash shell with escape sequences containing many leading zeros, e.g.: `printf "\033[0000000032mGREEN?\033[m\n"`. * I've confirmed that the leading zeros test in [Vttest](https://invisible-island.net/vttest/) now works (the last screen in the _Test of cursor movements_). * I've added a couple of unit tests in `Microsoft::Console::VirtualTerminal::OutputEngineTest` for both the CSI and OSC sequences. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24520
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?