[PR #1214] [MERGED] Re-enable serialization for OpenSettings #24530

Open
opened 2026-01-31 09:03:50 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1214
Author: @timheuer
Created: 6/12/2019
Status: Merged
Merged: 6/12/2019
Merged by: @undefined

Base: masterHead: master


📝 Commits (10+)

  • e1fb796 Adding vsconfig file for VS2019 help to prompt for missing components requried.
  • 56ce0da Merge remote-tracking branch 'upstream/master'
  • c5cadf7 Adding a keybinding for launching the settings. Suggested fix for #683
  • f00e8ce merged with updstream and resolved conflict
  • 8833deb Merge remote-tracking branch 'upstream/master'
  • bd0c8e9 Modified to comma per PR feedback
  • 06a053d Merge remote-tracking branch 'upstream/master'
  • bd46e67 Merge remote-tracking branch 'upstream/master'
  • 12e2d2f Merge remote-tracking branch 'upstream/master'
  • 7cd78fe Implements 791 for profile and settings shortcuts (most frequent and have shortcuts)

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+1 -0)

📄 Description

Summary of the Pull Request

Re-enables serialization of the OpenSettings shortcut action.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Adds back in the map for OpenSettingsKey that was missed when moved to new JSON cpp lib

Validation Steps Performed

Added keybinding in new globals area and ensured it persisted and showed in menu.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1214 **Author:** [@timheuer](https://github.com/timheuer) **Created:** 6/12/2019 **Status:** ✅ Merged **Merged:** 6/12/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`e1fb796`](https://github.com/microsoft/terminal/commit/e1fb79698d276a5c650d240dfa99214a758a81b0) Adding vsconfig file for VS2019 help to prompt for missing components requried. - [`56ce0da`](https://github.com/microsoft/terminal/commit/56ce0da5121c0dd9db2f6b386583e884bf93a724) Merge remote-tracking branch 'upstream/master' - [`c5cadf7`](https://github.com/microsoft/terminal/commit/c5cadf7b004ab4c380dabfe52c3458935df7383e) Adding a keybinding for launching the settings. Suggested fix for #683 - [`f00e8ce`](https://github.com/microsoft/terminal/commit/f00e8ced0c38e92c6d550645082b4cf2e22ffb13) merged with updstream and resolved conflict - [`8833deb`](https://github.com/microsoft/terminal/commit/8833deb162903b6112418f9f3dfda00eb8db23e6) Merge remote-tracking branch 'upstream/master' - [`bd0c8e9`](https://github.com/microsoft/terminal/commit/bd0c8e992c3c72aad22358573ce72ec2f8657fee) Modified to comma per PR feedback - [`06a053d`](https://github.com/microsoft/terminal/commit/06a053d40b2e6b18219612d531035eca8b2c7815) Merge remote-tracking branch 'upstream/master' - [`bd46e67`](https://github.com/microsoft/terminal/commit/bd46e67291bc6c3f7311a1af8c70993a91f75517) Merge remote-tracking branch 'upstream/master' - [`12e2d2f`](https://github.com/microsoft/terminal/commit/12e2d2ffdb605dd8a8a928c573f6ce54928306ed) Merge remote-tracking branch 'upstream/master' - [`7cd78fe`](https://github.com/microsoft/terminal/commit/7cd78fef7d8c3a064750b056c4d9e6ce52405c0b) Implements 791 for profile and settings shortcuts (most frequent and have shortcuts) ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Re-enables serialization of the OpenSettings shortcut action. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #1213 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Detailed Description of the Pull Request / Additional comments Adds back in the map for OpenSettingsKey that was missed when moved to new JSON cpp lib ## Validation Steps Performed Added keybinding in new globals area and ensured it persisted and showed in menu. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:50 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24530